[M148] [Flatland] Early-exit if viable_memory_types is zero [chromium/src : refs/branch-heads/7778]

0 views
Skip to first unread message

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 11, 2026, 8:22:29 PMJun 11
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, David Worsham, Robert Kroeger, android-bu...@system.gserviceaccount.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org

Message from rubber-...@appspot.gserviceaccount.com

The change is not in the configured time window. Rubber Stamper is only allowed to review cherry-picks within 14 day(s). Learn more: go/rubber-stamper-user-guide.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7778
Gerrit-Change-Id: Iab4d5ed6315dc19551abbd636f860b9913ae45f2
Gerrit-Change-Number: 7929566
Gerrit-PatchSet: 2
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Wez <w...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Jun 2026 00:22:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Wez (Gerrit)

unread,
Jun 12, 2026, 3:34:41 AMJun 12
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Zijie He, David Dorwin, David Worsham, Robert Kroeger, android-bu...@system.gserviceaccount.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from David Dorwin and Zijie He

Wez voted

Commit-Queue+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Dorwin
  • Zijie He
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7778
Gerrit-Change-Id: Iab4d5ed6315dc19551abbd636f860b9913ae45f2
Gerrit-Change-Number: 7929566
Gerrit-PatchSet: 2
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: David Dorwin <ddo...@chromium.org>
Gerrit-Attention: Zijie He <zij...@google.com>
Gerrit-Comment-Date: Fri, 12 Jun 2026 07:34:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

David Dorwin (Gerrit)

unread,
Jun 12, 2026, 11:27:50 AMJun 12
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, Zijie He, David Worsham, Robert Kroeger, android-bu...@system.gserviceaccount.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Zijie He

David Dorwin voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Zijie He
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7778
Gerrit-Change-Id: Iab4d5ed6315dc19551abbd636f860b9913ae45f2
Gerrit-Change-Number: 7929566
Gerrit-PatchSet: 2
Gerrit-Reviewer: David Dorwin <ddo...@chromium.org>
Gerrit-Reviewer: Wez <w...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-Attention: Zijie He <zij...@google.com>
Gerrit-Comment-Date: Fri, 12 Jun 2026 15:27:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Zijie He (Gerrit)

unread,
Jun 22, 2026, 4:02:33 PM (7 days ago) Jun 22
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, David Dorwin, Chromium LUCI CQ, David Worsham, Robert Kroeger, android-bu...@system.gserviceaccount.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from David Dorwin

Zijie He voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • David Dorwin
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7778
Gerrit-Change-Id: Iab4d5ed6315dc19551abbd636f860b9913ae45f2
Gerrit-Change-Number: 7929566
Gerrit-PatchSet: 2
Gerrit-Reviewer: David Dorwin <ddo...@chromium.org>
Gerrit-Reviewer: Wez <w...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: David Dorwin <ddo...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Jun 2026 20:02:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 22, 2026, 5:26:31 PM (7 days ago) Jun 22
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Zijie He, David Dorwin, David Worsham, Robert Kroeger, android-bu...@system.gserviceaccount.com, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[M148] [Flatland] Early-exit if viable_memory_types is zero

Original change's description:
> [Flatland] Early-exit if viable_memory_types is zero
>
> Early-exit if viable_memory_types is zero, rather than passing that to std::countr_zero().
>
> TAG=agy
> CONV=2445a381-fdbe-43e4-b252-645810ce8579
>
> Bug: 513746684
> Change-Id: Iab4d5ed6315dc19551abbd636f860b9913ae45f2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7863747
> Reviewed-by: David Song <winter...@google.com>
> Commit-Queue: David Song <winter...@google.com>
> Auto-Submit: Wez <w...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1633791}

(cherry picked from commit d1f8319c7b95240e54525e271542acb12d917a77)
Bug: 515275084,513746684
Change-Id: Iab4d5ed6315dc19551abbd636f860b9913ae45f2
Reviewed-by: David Dorwin <ddo...@chromium.org>
Reviewed-by: Zijie He <zij...@google.com>
Commit-Queue: Zijie He <zij...@google.com>
Owners-Override: Wez <w...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7778@{#4404}
Cr-Branched-From: 77f495ee216d4c3cc784d33658bad4778c0680ee-refs/heads/main@{#1610480}
Files:
  • M ui/ozone/platform/flatland/flatland_sysmem_buffer_collection.cc
Change size: XS
Delta: 1 file changed, 6 insertions(+), 0 deletions(-)
Branch: refs/branch-heads/7778
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by David Dorwin, +1 by Zijie He
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7778
Gerrit-Change-Id: Iab4d5ed6315dc19551abbd636f860b9913ae45f2
Gerrit-Change-Number: 7929566
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages