spanification: automatically spanify ui/events/ozone/evdev/event_device_util.h etc. [chromium/src : main]

[chromeperf@appspot.gserviceaccount.com (Gerrit)]

Attention needed from Bryan Enrique Gonzalez

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16c94657310000

Open in Gerrit

Related details

Attention is currently required from:

• Bryan Enrique Gonzalez

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Gerrit-Change-Number: 7257175

Gerrit-PatchSet: 2

Gerrit-Owner: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Comment-Date: Mon, 15 Dec 2025 20:16:44 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[chromeperf@appspot.gserviceaccount.com (Gerrit)]

Attention needed from Bryan Enrique Gonzalez

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/jetstream2 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/13208cf7310000

Open in Gerrit

Related details

Attention is currently required from:

• Bryan Enrique Gonzalez

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Gerrit-Change-Number: 7257175

Gerrit-PatchSet: 2

Gerrit-Owner: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Comment-Date: Mon, 15 Dec 2025 21:54:26 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Bryan Enrique Gonzalez (Gerrit)]

Attention needed from Jonathan Ross and Stephen Nusko

Bryan Enrique Gonzalez voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Jonathan Ross
• Stephen Nusko

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Gerrit-Change-Number: 7257175

Gerrit-PatchSet: 3

Gerrit-Owner: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Daniel Angulo <angd...@google.com>

Gerrit-CC: Roberto Torres <jr...@google.com>

Gerrit-CC: Sergio Solano <sergio...@google.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Jonathan Ross <jon...@chromium.org>

Gerrit-Attention: Stephen Nusko <nus...@chromium.org>

Gerrit-Comment-Date: Wed, 17 Dec 2025 21:44:15 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Jonathan Ross (Gerrit)]

Attention needed from Bryan Enrique Gonzalez and Stephen Nusko

Jonathan Ross voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Bryan Enrique Gonzalez
• Stephen Nusko

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Gerrit-Change-Number: 7257175

Gerrit-PatchSet: 3

Gerrit-Owner: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Daniel Angulo <angd...@google.com>

Gerrit-CC: Roberto Torres <jr...@google.com>

Gerrit-CC: Sergio Solano <sergio...@google.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Attention: Stephen Nusko <nus...@chromium.org>

Gerrit-Comment-Date: Wed, 17 Dec 2025 22:22:56 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Stephen Nusko (Gerrit)]

Attention needed from Bryan Enrique Gonzalez

Stephen Nusko added 3 comments

File ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h

Line 30, Patchset 3 (Latest):using EvdevKeyState = std::array<unsigned long, EVDEV_BITS_TO_LONGS(KEY_CNT)>;

Stephen Nusko . unresolved

This pollutes the ui namespace.

I would just inline this into the class? No need to declare a using statement is there?

File ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc

Line 703, Patchset 3 (Latest): base::span(prev_key_state_).copy_from(new_key_state);

Stephen Nusko . unresolved

nit: copy_from_nonoverlapping

Line 748, Patchset 3 (Latest): base::span(copy_key_state).copy_from(prev_key_state_);

Stephen Nusko . unresolved

nit: copy_from_nonoverlapping

Open in Gerrit

Related details

Attention is currently required from:

• Bryan Enrique Gonzalez

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Gerrit-Change-Number: 7257175

Gerrit-PatchSet: 3

Gerrit-Owner: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Daniel Angulo <angd...@google.com>

Gerrit-CC: Roberto Torres <jr...@google.com>

Gerrit-CC: Sergio Solano <sergio...@google.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Comment-Date: Thu, 18 Dec 2025 01:58:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Stephen Nusko (Gerrit)]

Attention needed from Bryan Enrique Gonzalez

Stephen Nusko voted and added 1 comment

Votes added by Stephen Nusko

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Stephen Nusko . resolved

Whoops forgot LGTM just minor nits anyway.

Open in Gerrit

Related details

Attention is currently required from:

• Bryan Enrique Gonzalez

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Gerrit-Change-Number: 7257175

Gerrit-PatchSet: 3

Gerrit-Owner: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Daniel Angulo <angd...@google.com>

Gerrit-CC: Roberto Torres <jr...@google.com>

Gerrit-CC: Sergio Solano <sergio...@google.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Comment-Date: Thu, 18 Dec 2025 01:59:05 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Bryan Enrique Gonzalez (Gerrit)]

Attention needed from Stephen Nusko

Bryan Enrique Gonzalez added 3 comments

File ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h

Line 30, Patchset 3 (Latest):using EvdevKeyState = std::array<unsigned long, EVDEV_BITS_TO_LONGS(KEY_CNT)>;

Stephen Nusko . unresolved

This pollutes the ui namespace.

I would just inline this into the class? No need to declare a using statement is there?

Bryan Enrique Gonzalez

Done. Inlined into the class.
I think the using statement is needed because we can control the type (unsigned long) and the size from a single place, which is more readable and maintainable.

File ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc

Line 703, Patchset 3 (Latest): base::span(prev_key_state_).copy_from(new_key_state);

Stephen Nusko . resolved

nit: copy_from_nonoverlapping

Bryan Enrique Gonzalez

Done

Line 748, Patchset 3 (Latest): base::span(copy_key_state).copy_from(prev_key_state_);

Stephen Nusko . resolved

nit: copy_from_nonoverlapping

Bryan Enrique Gonzalez

Done

Open in Gerrit

Related details

Attention is currently required from:

• Stephen Nusko

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Gerrit-Change-Number: 7257175

Gerrit-PatchSet: 3

Gerrit-Owner: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Daniel Angulo <angd...@google.com>

Gerrit-CC: Roberto Torres <jr...@google.com>

Gerrit-CC: Sergio Solano <sergio...@google.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Stephen Nusko <nus...@chromium.org>

Gerrit-Comment-Date: Thu, 18 Dec 2025 17:56:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Stephen Nusko <nus...@chromium.org>

[Stephen Nusko (Gerrit)]

Attention needed from Bryan Enrique Gonzalez and Jonathan Ross

Stephen Nusko voted and added 1 comment

Votes added by Stephen Nusko

Code-Review

+1

1 comment

File ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h

Line 30, Patchset 3:using EvdevKeyState = std::array<unsigned long, EVDEV_BITS_TO_LONGS(KEY_CNT)>;

Stephen Nusko . resolved

This pollutes the ui namespace.

I would just inline this into the class? No need to declare a using statement is there?

Bryan Enrique Gonzalez

Done. Inlined into the class.
I think the using statement is needed because we can control the type (unsigned long) and the size from a single place, which is more readable and maintainable.

Stephen Nusko

Sure as a private member this seems reasonable to me 😊 Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Bryan Enrique Gonzalez
• Jonathan Ross

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Gerrit-Change-Number: 7257175

Gerrit-PatchSet: 4

Gerrit-Owner: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Daniel Angulo <angd...@google.com>

Gerrit-CC: Roberto Torres <jr...@google.com>

Gerrit-CC: Sergio Solano <sergio...@google.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Jonathan Ross <jon...@chromium.org>

Gerrit-Attention: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Comment-Date: Fri, 19 Dec 2025 00:30:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Bryan Enrique Gonzalez <bryanen...@google.com>

Comment-In-Reply-To: Stephen Nusko <nus...@chromium.org>

[Jonathan Ross (Gerrit)]

Attention needed from Bryan Enrique Gonzalez

Jonathan Ross voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Bryan Enrique Gonzalez

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Gerrit-Change-Number: 7257175

Gerrit-PatchSet: 4

Gerrit-Owner: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Daniel Angulo <angd...@google.com>

Gerrit-CC: Roberto Torres <jr...@google.com>

Gerrit-CC: Sergio Solano <sergio...@google.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Comment-Date: Fri, 19 Dec 2025 15:00:12 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Bryan Enrique Gonzalez (Gerrit)]

Bryan Enrique Gonzalez voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Gerrit-Change-Number: 7257175

Gerrit-PatchSet: 4

Gerrit-Owner: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Daniel Angulo <angd...@google.com>

Gerrit-CC: Roberto Torres <jr...@google.com>

Gerrit-CC: Sergio Solano <sergio...@google.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Comment-Date: Fri, 19 Dec 2025 17:59:29 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

spanification: automatically spanify ui/events/ozone/evdev/event_device_util.h etc.

This is the result of running the automatic spanification on linux and
updating code to use and pass spans where size is known.

The original patch was fully automated using script:
//tools/clang/spanify/rewrite-multiple-platforms.sh -platforms=linux
Then refined with gemini-cli

gemini-run/batch-run-1761662609/group_199

BUG=439964610

Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7257175

Commit-Queue: Bryan Enrique Gonzalez <bryanen...@google.com>

Reviewed-by: Stephen Nusko <nus...@chromium.org>

Reviewed-by: Jonathan Ross <jon...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1561221}

Files:

• M ui/events/ozone/evdev/event_converter_evdev_impl.cc
• M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc
• M ui/events/ozone/evdev/event_device_info.cc
• M ui/events/ozone/evdev/event_device_test_util.cc
• M ui/events/ozone/evdev/event_device_util.h
• M ui/events/ozone/evdev/gamepad_event_converter_evdev.cc
• M ui/events/ozone/evdev/gamepad_event_converter_evdev_unittest.cc
• M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc
• M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h
• M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc

Change size: M

Delta: 10 files changed, 57 insertions(+), 54 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Jonathan Ross, +1 by Stephen Nusko

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I873194a09818b3a6b6bda4190bbc037368c6e5e5

Gerrit-Change-Number: 7257175

Gerrit-PatchSet: 5

Gerrit-Owner: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Bryan Enrique Gonzalez <bryanen...@google.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>

Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>