//ui: Eliminate X11SurfaceFactory::CreateNativePixmap(BufferFormat) [chromium/src : main]

0 views

Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,

Nov 3, 2025, 9:21:12 AM (3 days ago) Nov 3

to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Attention needed from Colin Blundell

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 4, 2025, 3:02:58 AM (2 days ago) Nov 4

to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

//ui: Eliminate X11SurfaceFactory::CreateNativePixmap(BufferFormat)

Instead, have it directly implement
CreateNativePixmap(SharedImageFormat), as the only usage of the former
is now in SurfaceFactoryOzone::CreateNativePixmap(SIF).

Bug: 450325664

Change-Id: I24e86bd808e04cc7932aefa3d0457905dc002375

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7109223

Commit-Queue: Colin Blundell <blun...@chromium.org>

Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1539812}

Files:

M ui/ozone/platform/x11/x11_surface_factory.cc
M ui/ozone/platform/x11/x11_surface_factory.h

Change size: S

Delta: 2 files changed, 11 insertions(+), 12 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Vasiliy Telezhnikov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages