Vincent Chiang (Gerrit)

unread,

Mar 27, 2026, 7:14:39 PM (6 days ago) Mar 27

to Mitsuru Oshima, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Attention needed from Mitsuru Oshima

Vincent Chiang added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Vincent Chiang . resolved

Please take a look!

Open in Gerrit

Related details

Attention is currently required from:

Mitsuru Oshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

Mar 27, 2026, 7:20:48 PM (6 days ago) Mar 27

to Vincent Chiang, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Attention needed from Vincent Chiang

Mitsuru Oshima voted and added 4 comments

Votes added by Mitsuru Oshima

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Mitsuru Oshima . resolved

lgtm with nits

File ui/events/ozone/evdev/input_device_opener_evdev.cc

Line 75, Patchset 4 (Latest): return base::WrapUnique<EventConverterEvdev>(

Mitsuru Oshima . unresolved

nit: make_unique

File ui/events/ozone/evdev/pen_tablet_event_converter_evdev_unittest.cc

Line 1636, Patchset 4 (Parent): struct input_event mock_kernel_queue[] = {

Mitsuru Oshima . unresolved

can you disable clang format (add // clang-format off ... // clang-format on ) ?

Line 1759, Patchset 4 (Parent): struct input_event mock_kernel_queue[] = {

Mitsuru Oshima . unresolved

ditto

Open in Gerrit

Related details

Attention is currently required from:

Vincent Chiang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vincent Chiang (Gerrit)

unread,

Mar 27, 2026, 7:50:48 PM (6 days ago) Mar 27

to Mitsuru Oshima, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Vincent Chiang voted and added 3 comments

Votes added by Vincent Chiang

Commit-Queue

+2

3 comments

File ui/events/ozone/evdev/input_device_opener_evdev.cc

Line 75, Patchset 4: return base::WrapUnique<EventConverterEvdev>(

Mitsuru Oshima . resolved

nit: make_unique

Vincent Chiang

Done, and also changed the ones below.

File ui/events/ozone/evdev/pen_tablet_event_converter_evdev_unittest.cc

Line 1636, Patchset 4 (Parent): struct input_event mock_kernel_queue[] = {

Mitsuru Oshima . resolved

can you disable clang format (add // clang-format off ... // clang-format on ) ?

Vincent Chiang

Done

Line 1759, Patchset 4 (Parent): struct input_event mock_kernel_queue[] = {

Mitsuru Oshima . resolved

ditto

Vincent Chiang

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 27, 2026, 9:11:29 PM (6 days ago) Mar 27

to Vincent Chiang, Mitsuru Oshima, Achuith Bhandarkar, chromium...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: ui/events/ozone/evdev/pen_tablet_event_converter_evdev_unittest.cc
Insertions: 34, Deletions: 15.

@@ -1638,29 +1638,39 @@
       CreateDevice(WacomOneByWacomSPenCTC472);
 
   struct input_event mock_kernel_queue[] = {
-      {{0, 0}, EV_ABS, ABS_X, 8430},      {{0, 0}, EV_ABS, ABS_Y, 3571},
-      {{0, 0}, EV_ABS, ABS_DISTANCE, 46}, {{0, 0}, EV_KEY, BTN_TOOL_PEN, 1},
+      // clang-format off
+      {{0, 0}, EV_ABS, ABS_X, 8430},
+      {{0, 0}, EV_ABS, ABS_Y, 3571},
+      {{0, 0}, EV_ABS, ABS_DISTANCE, 46},
+      {{0, 0}, EV_KEY, BTN_TOOL_PEN, 1},
       {{0, 0}, EV_SYN, SYN_REPORT, 0},  // Event 0
 
       {{0, 0}, EV_KEY, BTN_STYLUS2, 1},  // Event 1
-      {{0, 0}, EV_ABS, ABS_X, 8464},      {{0, 0}, EV_ABS, ABS_Y, 3587},
+      {{0, 0}, EV_ABS, ABS_X, 8464},
+      {{0, 0}, EV_ABS, ABS_Y, 3587},
       {{0, 0}, EV_SYN, SYN_REPORT, 0},  // Event 2
 
       {{0, 0}, EV_KEY, BTN_TOUCH, 1},  // Event 3
-      {{0, 0}, EV_ABS, ABS_X, 8585},      {{0, 0}, EV_ABS, ABS_PRESSURE, 489},
+      {{0, 0}, EV_ABS, ABS_X, 8585},
+      {{0, 0}, EV_ABS, ABS_PRESSURE, 489},
       {{0, 0}, EV_SYN, SYN_REPORT, 0},  // Event 4
 
       {{0, 0}, EV_KEY, BTN_TOUCH, 0},  // Event 5
-      {{0, 0}, EV_ABS, ABS_X, 8167},      {{0, 0}, EV_ABS, ABS_PRESSURE, 0},
+      {{0, 0}, EV_ABS, ABS_X, 8167},
+      {{0, 0}, EV_ABS, ABS_PRESSURE, 0},
       {{0, 0}, EV_SYN, SYN_REPORT, 0},  // Event 6
 
       {{0, 0}, EV_KEY, BTN_STYLUS2, 0},  // Event 7
-      {{0, 0}, EV_ABS, ABS_X, 8029},      {{0, 0}, EV_ABS, ABS_Y, 4274},
+      {{0, 0}, EV_ABS, ABS_X, 8029},
+      {{0, 0}, EV_ABS, ABS_Y, 4274},
       {{0, 0}, EV_SYN, SYN_REPORT, 0},  // Event 8
 
-      {{0, 0}, EV_ABS, ABS_X, 0},         {{0, 0}, EV_ABS, ABS_Y, 0},
-      {{0, 0}, EV_ABS, ABS_DISTANCE, 0},  {{0, 0}, EV_KEY, BTN_TOOL_PEN, 0},
+      {{0, 0}, EV_ABS, ABS_X, 0},
+      {{0, 0}, EV_ABS, ABS_Y, 0},
+      {{0, 0}, EV_ABS, ABS_DISTANCE, 0},
+      {{0, 0}, EV_KEY, BTN_TOOL_PEN, 0},
       {{0, 0}, EV_SYN, SYN_REPORT, 0},
+      // clang-format on
   };
 
   ExpectedEvent expected_events[] = {
@@ -1755,28 +1765,37 @@
       CreateDevice(WacomOneByWacomSPenCTC472);
 
   struct input_event mock_kernel_queue[] = {
-      {{0, 0}, EV_ABS, ABS_X, 9886},      {{0, 0}, EV_ABS, ABS_Y, 5154},
-      {{0, 0}, EV_ABS, ABS_DISTANCE, 46}, {{0, 0}, EV_KEY, BTN_TOOL_PEN, 1},
+      // clang-format off
+      {{0, 0}, EV_ABS, ABS_X, 9886},
+      {{0, 0}, EV_ABS, ABS_Y, 5154},
+      {{0, 0}, EV_ABS, ABS_DISTANCE, 46},
+      {{0, 0}, EV_KEY, BTN_TOOL_PEN, 1},
       {{0, 0}, EV_SYN, SYN_REPORT, 0},  // Event 0
 
       {{0, 0}, EV_KEY, BTN_TOUCH, 1},  // Event 1
-      {{0, 0}, EV_ABS, ABS_X, 10015},     {{0, 0}, EV_ABS, ABS_PRESSURE, 300},
+      {{0, 0}, EV_ABS, ABS_X, 10015},
+      {{0, 0}, EV_ABS, ABS_PRESSURE, 300},
       {{0, 0}, EV_SYN, SYN_REPORT, 0},  // Event 2
 
       {{0, 0}, EV_KEY, BTN_STYLUS2, 1},  // Event 3
       {{0, 0}, EV_SYN, SYN_REPORT, 0},
 
       {{0, 0}, EV_KEY, BTN_TOUCH, 0},  // Event 4
-      {{0, 0}, EV_ABS, ABS_X, 9265},      {{0, 0}, EV_ABS, ABS_X, 5278},
+      {{0, 0}, EV_ABS, ABS_X, 9265},
+      {{0, 0}, EV_ABS, ABS_X, 5278},
       {{0, 0}, EV_SYN, SYN_REPORT, 0},  // Event 5
 
       {{0, 0}, EV_KEY, BTN_STYLUS2, 0},  // Event 6
-      {{0, 0}, EV_ABS, ABS_X, 9351},      {{0, 0}, EV_ABS, ABS_Y, 5029},
+      {{0, 0}, EV_ABS, ABS_X, 9351},
+      {{0, 0}, EV_ABS, ABS_Y, 5029},
       {{0, 0}, EV_SYN, SYN_REPORT, 0},  // Event 7
 
-      {{0, 0}, EV_ABS, ABS_X, 0},         {{0, 0}, EV_ABS, ABS_Y, 0},
-      {{0, 0}, EV_ABS, ABS_DISTANCE, 0},  {{0, 0}, EV_KEY, BTN_TOOL_PEN, 0},
+      {{0, 0}, EV_ABS, ABS_X, 0},
+      {{0, 0}, EV_ABS, ABS_Y, 0},
+      {{0, 0}, EV_ABS, ABS_DISTANCE, 0},
+      {{0, 0}, EV_KEY, BTN_TOOL_PEN, 0},
       {{0, 0}, EV_SYN, SYN_REPORT, 0},
+      // clang-format on
   };
 
   ExpectedEvent expected_events[] = {
```
```
The name of the file: ui/events/ozone/evdev/input_device_opener_evdev.cc
Insertions: 14, Deletions: 15.

@@ -6,6 +6,8 @@
 
 #include <fcntl.h>
 
+#include <memory>
+
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_file.h"
@@ -72,35 +74,32 @@
 
   // Graphics tablet
   if (devinfo.HasTablet()) {
-    return base::WrapUnique<EventConverterEvdev>(
-        new PenTabletEventConverterEvdev(std::move(fd), params.path, params.id,
-                                         params.cursor, devinfo,
-                                         params.dispatcher));
+    return std::make_unique<PenTabletEventConverterEvdev>(
+        std::move(fd), params.path, params.id, params.cursor, devinfo,
+        params.dispatcher);
   }
 
   if (devinfo.HasGamepad()) {
-    return base::WrapUnique<EventConverterEvdev>(new GamepadEventConverterEvdev(
-        std::move(fd), params.path, params.id, devinfo, params.dispatcher));
+    return std::make_unique<GamepadEventConverterEvdev>(
+        std::move(fd), params.path, params.id, devinfo, params.dispatcher);
   }
 
   if (devinfo.IsStylusButtonDevice()) {
-    return base::WrapUnique<EventConverterEvdev>(
-        new StylusButtonEventConverterEvdev(
-            std::move(fd), params.path, params.id, devinfo, params.dispatcher));
+    return std::make_unique<StylusButtonEventConverterEvdev>(
+        std::move(fd), params.path, params.id, devinfo, params.dispatcher);
   }
 
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableMicrophoneMuteSwitchDeviceSwitch) &&
       devinfo.IsMicrophoneMuteSwitchDevice()) {
-    return base::WrapUnique<EventConverterEvdev>(
-        new MicrophoneMuteSwitchEventConverterEvdev(
-            std::move(fd), params.path, params.id, devinfo, params.dispatcher));
+    return std::make_unique<MicrophoneMuteSwitchEventConverterEvdev>(
+        std::move(fd), params.path, params.id, devinfo, params.dispatcher);
   }
 
   // Everything else: use EventConverterEvdevImpl.
-  return base::WrapUnique<EventConverterEvdevImpl>(
-      new EventConverterEvdevImpl(std::move(fd), params.path, params.id,
-                                  devinfo, params.cursor, params.dispatcher));
+  return std::make_unique<EventConverterEvdevImpl>(
+      std::move(fd), params.path, params.id, devinfo, params.cursor,
+      params.dispatcher);
 }
 
 }  // namespace
```

Change information

Commit message:

Rename TabletEventConverterEvdev to PenTabletEventConverterEvdev

This rename is to avoid the confusion of what a `tablet` is and
explicitly name the devices as `Pen Tablet`.

Bug: b:494343565

Bypass-Check-License: Class rename only

Change-Id: I3a50ade9ac6ed7f648b0cd71f665b8ddf1f86855

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7708604

Reviewed-by: Mitsuru Oshima <osh...@chromium.org>

Commit-Queue: Vincent Chiang <vincen...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1606592}

Files:

M ui/events/ozone/evdev/BUILD.gn
M ui/events/ozone/evdev/input_device_factory_evdev.cc
M ui/events/ozone/evdev/input_device_opener_evdev.cc
R ui/events/ozone/evdev/pen_tablet_event_converter_evdev.cc
R ui/events/ozone/evdev/pen_tablet_event_converter_evdev.h
R ui/events/ozone/evdev/pen_tablet_event_converter_evdev_unittest.cc

Change size: L

Delta: 6 files changed, 198 insertions(+), 177 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mitsuru Oshima

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Rename TabletEventConverterEvdev to PenTabletEventConverterEvdev [chromium/src : main]

Vincent Chiang (Gerrit)

Vincent Chiang added 1 comment

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima voted and added 4 comments

Votes added by Mitsuru Oshima

4 comments

Related details

Vincent Chiang (Gerrit)

Vincent Chiang voted and added 3 comments

Votes added by Vincent Chiang

3 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information