url: Rename DecodeURLMode and DecodeURLEscapeSequences [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Feb 23, 2026, 10:46:42 PMFeb 23
to Kent Tamura, Hayato Ito, chromium...@chromium.org, devtools...@chromium.org, Stephen Chenney, Mathias Bynens, Fredrik Söderquist, David Bokan, Dirk Schulze, Menard, Alexis, Nate Chapin, AyeAye, Chromium LUCI CQ, webap...@microsoft.com, yhanada+...@chromium.org, oshima...@chromium.org, dmurph+wat...@chromium.org, chromium-a...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, android-web...@chromium.org, max+watc...@igalia.com, fmalit...@chromium.org, pdr+svgw...@chromium.org, feature-me...@chromium.org, net-r...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, kouhe...@chromium.org, arthursonzog...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, antoniosarto...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, knollr+wat...@chromium.org, dcheng+c...@chromium.org, mkwst+w...@chromium.org
Attention needed from Hayato Ito

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Kent Tamura . resolved

hayato@, would you review this almost-mechanical change please?
Please set Owners-Override as well.

Open in Gerrit

Related details

Attention is currently required from:
  • Hayato Ito
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29ac4456e9745f66a2cd9e1d733cacecfe683a88
Gerrit-Change-Number: 7593238
Gerrit-PatchSet: 5
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Hayato Ito <hay...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Feb 2026 03:46:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Hayato Ito (Gerrit)

unread,
Feb 23, 2026, 11:12:19 PMFeb 23
to Kent Tamura, chromium...@chromium.org, devtools...@chromium.org, Stephen Chenney, Mathias Bynens, Fredrik Söderquist, David Bokan, Dirk Schulze, Menard, Alexis, Nate Chapin, AyeAye, Chromium LUCI CQ, webap...@microsoft.com, yhanada+...@chromium.org, oshima...@chromium.org, dmurph+wat...@chromium.org, chromium-a...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, android-web...@chromium.org, max+watc...@igalia.com, fmalit...@chromium.org, pdr+svgw...@chromium.org, feature-me...@chromium.org, net-r...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, kouhe...@chromium.org, arthursonzog...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, antoniosarto...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, knollr+wat...@chromium.org, dcheng+c...@chromium.org, mkwst+w...@chromium.org
Attention needed from Kent Tamura

Hayato Ito voted and added 1 comment

Votes added by Hayato Ito

Code-Review+1
Commit-Queue+2
Owners-Override+1

1 comment

Patchset-level comments
Hayato Ito . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29ac4456e9745f66a2cd9e1d733cacecfe683a88
Gerrit-Change-Number: 7593238
Gerrit-PatchSet: 5
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Feb 2026 04:11:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 23, 2026, 11:18:58 PMFeb 23
to Kent Tamura, Hayato Ito, chromium...@chromium.org, devtools...@chromium.org, Stephen Chenney, Mathias Bynens, Fredrik Söderquist, David Bokan, Dirk Schulze, Menard, Alexis, Nate Chapin, AyeAye, webap...@microsoft.com, yhanada+...@chromium.org, oshima...@chromium.org, dmurph+wat...@chromium.org, chromium-a...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, android-web...@chromium.org, max+watc...@igalia.com, fmalit...@chromium.org, pdr+svgw...@chromium.org, feature-me...@chromium.org, net-r...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, bnc+...@chromium.org, kinuko+...@chromium.org, kouhe...@chromium.org, arthursonzog...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, antoniosarto...@chromium.org, blink-re...@chromium.org, network-ser...@chromium.org, blink-...@chromium.org, knollr+wat...@chromium.org, dcheng+c...@chromium.org, mkwst+w...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
url: Rename DecodeURLMode and DecodeURLEscapeSequences

This CL renames DecodeURLMode to DecodeUrlMode, and
DecodeURLEscapeSequences() to DecodeUrlEscapeSequences() to follow the
Google C++ style guide.

The style guide recommends treating acronyms as words in names (e.g.,
`StartRpc` instead of `StartRPC`). This change applies this convention
to the "URL" acronym in these names for consistency across the codebase.
Change-Id: I29ac4456e9745f66a2cd9e1d733cacecfe683a88
Reviewed-by: Hayato Ito <hay...@chromium.org>
Auto-Submit: Kent Tamura <tk...@chromium.org>
Commit-Queue: Hayato Ito <hay...@chromium.org>
Owners-Override: Hayato Ito <hay...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1589145}
Files:
  • M android_webview/renderer/aw_render_frame_ext.cc
  • M chrome/browser/apps/app_service/app_install/app_install_navigation_throttle.cc
  • M chrome/browser/devtools/devtools_file_helper.cc
  • M chrome/browser/sharing/click_to_call/click_to_call_utils.cc
  • M chrome/browser/ui/webui/new_tab_page/untrusted_source.cc
  • M chrome/browser/ui/webui/sanitized_image_source.cc
  • M chrome/test/chromedriver/server/http_handler.cc
  • M chromeos/ash/experiences/arc/intent_helper/link_handler_model.cc
  • M net/base/url_util.cc
  • M net/third_party/quiche/overrides/quiche_platform_impl/quiche_url_utils_impl.cc
  • M services/network/public/cpp/content_security_policy/content_security_policy.cc
  • M services/network/public/cpp/content_security_policy/csp_source.cc
  • M services/network/shared_storage/shared_storage_test_utils.cc
  • M third_party/blink/renderer/core/clipboard/data_object_item.cc
  • M third_party/blink/renderer/core/css/css_image_value.cc
  • M third_party/blink/renderer/core/css/css_uri_value.cc
  • M third_party/blink/renderer/core/dom/tree_scope.cc
  • M third_party/blink/renderer/core/fileapi/file.cc
  • M third_party/blink/renderer/core/fragment_directive/css_selector_directive.cc
  • M third_party/blink/renderer/core/fragment_directive/text_fragment_selector.cc
  • M third_party/blink/renderer/core/frame/csp/csp_source.cc
  • M third_party/blink/renderer/core/frame/local_dom_window.cc
  • M third_party/blink/renderer/core/html/image_document.cc
  • M third_party/blink/renderer/core/html/media/media_fragment_uri_parser.cc
  • M third_party/blink/renderer/core/loader/form_submission.cc
  • M third_party/blink/renderer/core/page/create_window.cc
  • M third_party/blink/renderer/core/page/scrolling/element_fragment_anchor.cc
  • M third_party/blink/renderer/core/svg/graphics/svg_image.cc
  • M third_party/blink/renderer/core/svg/svg_resource.cc
  • M third_party/blink/renderer/core/svg/svg_uri_reference.cc
  • M third_party/blink/renderer/core/svg/svg_use_element.cc
  • M third_party/blink/renderer/core/url/url_search_params.cc
  • M third_party/blink/renderer/platform/weborigin/kurl.cc
  • M third_party/blink/renderer/platform/weborigin/kurl.h
  • M third_party/blink/renderer/platform/weborigin/kurl_test.cc
  • M ui/ozone/platform/wayland/host/wayland_exchange_data_provider.cc
  • M ui/shell_dialogs/select_file_dialog_linux_portal.cc
  • M url/url_util.cc
  • M url/url_util.h
  • M url/url_util_unittest.cc
Change size: M
Delta: 40 files changed, 104 insertions(+), 108 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Hayato Ito
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29ac4456e9745f66a2cd9e1d733cacecfe683a88
Gerrit-Change-Number: 7593238
Gerrit-PatchSet: 6
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages