[9/12] ozone/drm: Add proper cursor support for tiled displays [chromium/src : main]

0 views
Skip to first unread message

Su Hong Koo (Gerrit)

unread,
Sep 4, 2024, 5:39:30 PM9/4/24
to Gil Dekel, Chromium LUCI CQ, Tricium, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Gil Dekel

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Gil Dekel
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib17515dbc1161742ab293f0d02ad8e8ef96c3a93
Gerrit-Change-Number: 5089088
Gerrit-PatchSet: 25
Gerrit-Owner: Su Hong Koo <su...@chromium.org>
Gerrit-Reviewer: Gil Dekel <gild...@chromium.org>
Gerrit-Reviewer: Su Hong Koo <su...@chromium.org>
Gerrit-Attention: Gil Dekel <gild...@chromium.org>
Gerrit-Comment-Date: Wed, 04 Sep 2024 17:39:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Gil Dekel (Gerrit)

unread,
Sep 5, 2024, 6:14:38 PM9/5/24
to Su Hong Koo, Chromium LUCI CQ, Tricium, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Su Hong Koo

Gil Dekel added 2 comments

Patchset-level comments
File-level comment, Patchset 26 (Latest):
Gil Dekel . resolved

Mostly LGTM. Just a question before.

File ui/ozone/platform/drm/gpu/crtc_controller.cc
Line 96, Patchset 26 (Latest): location.x() -
(tile_property_->tile_size.width() * tile_property_->location.x()),
location.y() - (tile_property_->tile_size.height() *
tile_property_->location.y()));
Gil Dekel . unresolved

Can you not use the `GetTileCrtcOffset` function you added in 8/12 for this?

Open in Gerrit

Related details

Attention is currently required from:
  • Su Hong Koo
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib17515dbc1161742ab293f0d02ad8e8ef96c3a93
    Gerrit-Change-Number: 5089088
    Gerrit-PatchSet: 26
    Gerrit-Owner: Su Hong Koo <su...@chromium.org>
    Gerrit-Reviewer: Gil Dekel <gild...@chromium.org>
    Gerrit-Reviewer: Su Hong Koo <su...@chromium.org>
    Gerrit-Attention: Su Hong Koo <su...@chromium.org>
    Gerrit-Comment-Date: Thu, 05 Sep 2024 18:14:30 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Su Hong Koo (Gerrit)

    unread,
    Sep 9, 2024, 5:21:25 PM9/9/24
    to Gil Dekel, Chromium LUCI CQ, Tricium, chromium...@chromium.org, ozone-...@chromium.org
    Attention needed from Gil Dekel

    Su Hong Koo added 1 comment

    File ui/ozone/platform/drm/gpu/crtc_controller.cc
    Line 96, Patchset 26: location.x() -

    (tile_property_->tile_size.width() * tile_property_->location.x()),
    location.y() - (tile_property_->tile_size.height() *
    tile_property_->location.y()));
    Gil Dekel . resolved

    Can you not use the `GetTileCrtcOffset` function you added in 8/12 for this?

    Su Hong Koo

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gil Dekel
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib17515dbc1161742ab293f0d02ad8e8ef96c3a93
    Gerrit-Change-Number: 5089088
    Gerrit-PatchSet: 27
    Gerrit-Owner: Su Hong Koo <su...@chromium.org>
    Gerrit-Reviewer: Gil Dekel <gild...@chromium.org>
    Gerrit-Reviewer: Su Hong Koo <su...@chromium.org>
    Gerrit-Attention: Gil Dekel <gild...@chromium.org>
    Gerrit-Comment-Date: Mon, 09 Sep 2024 17:21:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Gil Dekel <gild...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gil Dekel (Gerrit)

    unread,
    Sep 10, 2024, 6:29:02 PM9/10/24
    to Su Hong Koo, Chromium LUCI CQ, Tricium, chromium...@chromium.org, ozone-...@chromium.org
    Attention needed from Su Hong Koo

    Gil Dekel voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Su Hong Koo
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib17515dbc1161742ab293f0d02ad8e8ef96c3a93
    Gerrit-Change-Number: 5089088
    Gerrit-PatchSet: 27
    Gerrit-Owner: Su Hong Koo <su...@chromium.org>
    Gerrit-Reviewer: Gil Dekel <gild...@chromium.org>
    Gerrit-Reviewer: Su Hong Koo <su...@chromium.org>
    Gerrit-Attention: Su Hong Koo <su...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Sep 2024 18:28:53 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gil Dekel (Gerrit)

    unread,
    Sep 10, 2024, 6:37:33 PM9/10/24
    to Su Hong Koo, Chromium LUCI CQ, Tricium, chromium...@chromium.org, ozone-...@chromium.org
    Attention needed from Su Hong Koo

    Gil Dekel voted and added 2 comments

    Votes added by Gil Dekel

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 27 (Latest):
    Gil Dekel . resolved

    Oh whoops.. wrong button.
    LGTM.

    Commit Message
    Line 12, Patchset 27 (Latest):coordinate must be transformed relative to the individial tiles'
    Gil Dekel . unresolved

    "individial" is a possible misspelling of "individual".

    Please fix.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Su Hong Koo
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib17515dbc1161742ab293f0d02ad8e8ef96c3a93
    Gerrit-Change-Number: 5089088
    Gerrit-PatchSet: 27
    Gerrit-Owner: Su Hong Koo <su...@chromium.org>
    Gerrit-Reviewer: Gil Dekel <gild...@chromium.org>
    Gerrit-Reviewer: Su Hong Koo <su...@chromium.org>
    Gerrit-Attention: Su Hong Koo <su...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Sep 2024 18:37:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Su Hong Koo (Gerrit)

    unread,
    Sep 10, 2024, 6:46:11 PM9/10/24
    to Gil Dekel, Chromium LUCI CQ, Tricium, chromium...@chromium.org, ozone-...@chromium.org

    Su Hong Koo added 1 comment

    Commit Message
    Line 12, Patchset 27:coordinate must be transformed relative to the individial tiles'
    Gil Dekel . resolved

    "individial" is a possible misspelling of "individual".

    Please fix.

    Su Hong Koo

    Typing is hard 😞

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib17515dbc1161742ab293f0d02ad8e8ef96c3a93
    Gerrit-Change-Number: 5089088
    Gerrit-PatchSet: 28
    Gerrit-Owner: Su Hong Koo <su...@chromium.org>
    Gerrit-Reviewer: Gil Dekel <gild...@chromium.org>
    Gerrit-Reviewer: Su Hong Koo <su...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Sep 2024 18:46:01 +0000
    satisfied_requirement
    open
    diffy

    Su Hong Koo (Gerrit)

    unread,
    Sep 10, 2024, 6:51:22 PM9/10/24
    to Gil Dekel, Chromium LUCI CQ, Tricium, chromium...@chromium.org, ozone-...@chromium.org

    Su Hong Koo voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib17515dbc1161742ab293f0d02ad8e8ef96c3a93
    Gerrit-Change-Number: 5089088
    Gerrit-PatchSet: 29
    Gerrit-Owner: Su Hong Koo <su...@chromium.org>
    Gerrit-Reviewer: Gil Dekel <gild...@chromium.org>
    Gerrit-Reviewer: Su Hong Koo <su...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Sep 2024 18:51:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 10, 2024, 7:49:30 PM9/10/24
    to Su Hong Koo, Gil Dekel, Tricium, chromium...@chromium.org, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    27 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [9/12] ozone/drm: Add proper cursor support for tiled displays

    drmModeMoveCursor(), invoked by CrtcController, moves the cursor based
    on CRTC's coordinates, rather than the planes. This means that in order
    for the cursor to show up on the display accurately, the cursor
    coordinate must be transformed relative to the individual tiles'
    location.

    This transformation will ensure that only one tile has a cursor within
    its CRTC bounds.
    Bug: b:285923912, b:324237063
    Test: ozone_unittests
    Change-Id: Ib17515dbc1161742ab293f0d02ad8e8ef96c3a93
    Commit-Queue: Su Hong Koo <su...@chromium.org>
    Reviewed-by: Gil Dekel <gild...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1353547}
    Files:
    • M ui/ozone/platform/drm/gpu/crtc_controller.cc
    • M ui/ozone/platform/drm/gpu/fake_drm_device.cc
    • M ui/ozone/platform/drm/gpu/fake_drm_device.h
    • M ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc
    Change size: M
    Delta: 4 files changed, 54 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Gil Dekel
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib17515dbc1161742ab293f0d02ad8e8ef96c3a93
    Gerrit-Change-Number: 5089088
    Gerrit-PatchSet: 30
    Gerrit-Owner: Su Hong Koo <su...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Gil Dekel <gild...@chromium.org>
    Gerrit-Reviewer: Su Hong Koo <su...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages