Fred Shih (Gerrit)

unread,

Feb 5, 2026, 4:56:18 PMFeb 5

to Kevin McNee, Tom Lukaszewicz, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, jdonnel...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention needed from Tom Lukaszewicz

Fred Shih voted and added 1 comment

Votes added by Fred Shih

Commit-Queue

+1

1 comment

Commit Message

Line 7, Patchset 2:Introduce a static function to determine is ozone is wayland in test

Kevin McNee . resolved

if

Fred Shih

Done

Open in Gerrit

Related details

Attention is currently required from:

Tom Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tom Lukaszewicz (Gerrit)

unread,

Feb 5, 2026, 6:48:53 PMFeb 5

to Fred Shih, Kevin McNee, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, jdonnel...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention needed from Fred Shih

Tom Lukaszewicz voted and added 1 comment

Votes added by Tom Lukaszewicz

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Tom Lukaszewicz . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

Fred Shih

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Fred Shih (Gerrit)

unread,

Feb 5, 2026, 8:04:56 PMFeb 5

to Tom Lukaszewicz, Kevin McNee, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, jdonnel...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Fred Shih voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Feb 5, 2026, 8:08:10 PMFeb 5

to Fred Shih, Tom Lukaszewicz, Kevin McNee, Mitsuru Oshima, chromium...@chromium.org, dewitt...@chromium.org, jdonnel...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Introduce a static function to determine if ozone is wayland in test

It's not uncommon for gardeners to attempt to disable tests specifically
on the wayland platform. Instead of having all the callsites perform a
string comparison, this introduces a simple static function to determine
whether or not to GTEST_SKIP a test based on the ozone platform.

Change-Id: I6f60998398a178ea8e47cdd784644e316d2381bc

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7546965

Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>

Commit-Queue: Fred Shih <ff...@chromium.org>

Reviewed-by: Mitsuru Oshima <osh...@chromium.org>

Reviewed-by: Kevin McNee <mc...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1580518}

Files:

M chrome/browser/glic/glic_metrics_browsertest.cc
M chrome/browser/glic/host/glic_actor_task_management_interactive_uitest.cc
M chrome/browser/glic/host/glic_actor_window_management_tool_interactive_uitest.cc
M chrome/browser/picture_in_picture/document_picture_in_picture_window_controller_browsertest.cc
M chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
M chrome/browser/ui/toasts/toast_controller_interactive_ui_test.cc
M chrome/browser/ui/views/frame/browser_view_browsertest.cc
M chrome/browser/ui/views/frame/multi_contents_view_browsertest.cc
M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
M chrome/test/base/save_desktop_snapshot_browsertest.cc
M gpu/command_buffer/client/internal/mappable_buffer_test_template.h
M ui/ozone/public/ozone_platform.cc
M ui/ozone/public/ozone_platform.h
M ui/views/interaction/interaction_test_util_views.cc
M ui/views/test/widget_test_api.cc

Change size: S

Delta: 15 files changed, 24 insertions(+), 18 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mitsuru Oshima, +1 by Kevin McNee, +1 by Tom Lukaszewicz

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Introduce a static function to determine if ozone is wayland in test [chromium/src : main]

Fred Shih (Gerrit)

Fred Shih voted and added 1 comment

Votes added by Fred Shih

1 comment

Related details

Tom Lukaszewicz (Gerrit)

Tom Lukaszewicz voted and added 1 comment

Votes added by Tom Lukaszewicz

1 comment

Related details

Fred Shih (Gerrit)

Fred Shih voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information