Suppress initial set of unique_ptr<T[]>::operator[] unsafe warnings [chromium/src : main]

0 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
Nov 4, 2025, 1:11:05 PM (2 days ago) Nov 4
to Nico Weber, Lei Zhang, Tommy Li, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Rijubrata Bhaumik, Sadrul Chowdhury, Stephen Chenney, James Su, oshima...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, dewitt...@chromium.org, alexmo...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuzzin...@chromium.org, glazuno...@chromium.org, grt+...@chromium.org, jbauma...@chromium.org, kainin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, mpdento...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org
Attention needed from Nico Weber

Tom Sepez added 1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Tom Sepez . resolved

+Nico for +OO.

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibe0b56d77f51114715d655f137714950034ec955
Gerrit-Change-Number: 7106863
Gerrit-PatchSet: 10
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 18:10:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nico Weber (Gerrit)

unread,
Nov 4, 2025, 1:15:12 PM (2 days ago) Nov 4
to Tom Sepez, Sam Maier, Nico Weber, Lei Zhang, Tommy Li, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Rijubrata Bhaumik, Sadrul Chowdhury, Stephen Chenney, James Su, oshima...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, dewitt...@chromium.org, alexmo...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuzzin...@chromium.org, glazuno...@chromium.org, grt+...@chromium.org, jbauma...@chromium.org, kainin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, mpdento...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org
Attention needed from Sam Maier and Tom Sepez

Nico Weber voted and added 1 comment

Votes added by Nico Weber

Code-Review+1
Owners-Override+1

1 comment

Patchset-level comments
Nico Weber . resolved

Nice, that's less than I thought. +smaier for third_party/jni_zero; rest lg.

Open in Gerrit

Related details

Attention is currently required from:
  • Sam Maier
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibe0b56d77f51114715d655f137714950034ec955
Gerrit-Change-Number: 7106863
Gerrit-PatchSet: 10
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Sam Maier <sma...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-Attention: Sam Maier <sma...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 18:15:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Nov 4, 2025, 1:15:53 PM (2 days ago) Nov 4
to Sam Maier, Nico Weber, Lei Zhang, Tommy Li, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Rijubrata Bhaumik, Sadrul Chowdhury, Stephen Chenney, James Su, oshima...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, dewitt...@chromium.org, alexmo...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuzzin...@chromium.org, glazuno...@chromium.org, grt+...@chromium.org, jbauma...@chromium.org, kainin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, mpdento...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org
Attention needed from Sam Maier

Tom Sepez voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sam Maier
Gerrit-Comment-Date: Tue, 04 Nov 2025 18:15:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 4, 2025, 3:40:13 PM (2 days ago) Nov 4
to Tom Sepez, Sam Maier, Nico Weber, Lei Zhang, Tommy Li, AyeAye, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Rijubrata Bhaumik, Sadrul Chowdhury, Stephen Chenney, James Su, oshima...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, dewitt...@chromium.org, alexmo...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuzzin...@chromium.org, glazuno...@chromium.org, grt+...@chromium.org, jbauma...@chromium.org, kainin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, mpdento...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Suppress initial set of unique_ptr<T[]>::operator[] unsafe warnings

The clang compiler can now warn on another unsafe pattern: indexing
an element of unique_ptr<T[]>. This CL stops short of actually
enabling this warning for Chromium builds, but identifies some
usage which would trigger the new warning and suppresses it via the
UNSAFE_TODO() macro.

The warning itself can be enabled in a one-line follow-on, to ease
a revert if required.
Change-Id: Ibe0b56d77f51114715d655f137714950034ec955
Owners-Override: Nico Weber <tha...@chromium.org>
Reviewed-by: Nico Weber <tha...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540262}
Files:
  • M base/debug/handle_hooks_win.cc
  • M base/message_loop/message_pump_perftest.cc
  • M base/win/registry.cc
  • M chrome/browser/glic/browser_ui/glic_vector_icon_manager.cc
  • M chrome/enterprise_companion/crash_client.cc
  • M chrome/updater/crash_reporter.cc
  • M chromeos/ash/services/recording/rgb_video_frame.h
  • M components/feedback/redaction_tool_fuzzer.cc
  • M components/gwp_asan/client/guarded_page_allocator.cc
  • M components/zucchini/binary_data_histogram.cc
  • M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
  • M extensions/renderer/safe_builtins.cc
  • M gpu/command_buffer/client/cmd_buffer_helper_test.cc
  • M gpu/command_buffer/common/command_buffer_shared_test.cc
  • M gpu/command_buffer/service/framebuffer_manager.cc
  • M media/audio/win/audio_low_latency_output_win_unittest.cc
  • M media/muxers/mp4_muxer_delegate.cc
  • M services/network/web_transport_unittest.cc
  • M third_party/blink/renderer/core/css/robin_hood_map-inl.h
  • M third_party/blink/renderer/modules/webaudio/audio_buffer_source_handler.cc
  • M third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.cc
  • M third_party/blink/renderer/modules/webgpu/dawn_conversions.h
  • M third_party/blink/renderer/modules/webgpu/gpu_programmable_stage.cc
  • M third_party/blink/renderer/modules/webgpu/gpu_render_pipeline.cc
  • M third_party/blink/renderer/platform/audio/dynamics_compressor.cc
  • M third_party/blink/renderer/platform/fonts/font_custom_platform_data.cc
  • M third_party/blink/renderer/platform/fonts/opentype/open_type_cpal_lookup.cc
  • M third_party/blink/renderer/platform/fonts/opentype/variable_axes_names.cc
  • M third_party/blink/renderer/platform/geometry/stroke_data.cc
  • M third_party/jni_zero/default_conversions.cc
  • M ui/events/ozone/evdev/touch_evdev_debug_buffer.cc
Change size: L
Delta: 31 files changed, 224 insertions(+), 167 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nico Weber
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibe0b56d77f51114715d655f137714950034ec955
Gerrit-Change-Number: 7106863
Gerrit-PatchSet: 11
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Sam Maier <sma...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages