gfx::HDRMetadata: de-optionalize remains [chromium/src : main]
0 views
Skip to first unread message
ccameron chromium (Gerrit)
Dec 9, 2025, 4:53:04 PM (12 days ago) Dec 9
to ccameron chromium, Daniel Cheng, Dale Curtis, Vasiliy Telezhnikov, Antonio Rivera, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Antonio Rivera, Dale Curtis, Daniel Cheng and Vasiliy Telezhnikov
ccameron chromium added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 8 (Latest):
ccameron chromium . resolved
+dcheng for security OWNERship
+dalecurtis for media
+vasilyt for android_webview
+antoniori for chromecast
Related details
Attention is currently required from:
- Antonio Rivera
- Dale Curtis
- Daniel Cheng
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Rivera (Gerrit)
Dec 9, 2025, 4:57:07 PM (12 days ago) Dec 9
to ccameron chromium, Daniel Cheng, Dale Curtis, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Dale Curtis, Daniel Cheng, Vasiliy Telezhnikov and ccameron chromium
Antonio Rivera voted and added 1 comment![]( "Open in Gerrit")
Votes added by Antonio Rivera
| Code-Review | +1 |
1 comment
Patchset-level comments
Antonio Rivera . resolved
//chromecast change LGTM. Thanks for updating it!
Related details
Attention is currently required from:
- Dale Curtis
- Daniel Cheng
- Vasiliy Telezhnikov
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Dec 9, 2025, 4:58:12 PM (12 days ago) Dec 9
to ccameron chromium, Antonio Rivera, Daniel Cheng, Dale Curtis, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Dale Curtis, Daniel Cheng and ccameron chromium
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Dale Curtis
- Daniel Cheng
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Dec 9, 2025, 5:07:56 PM (12 days ago) Dec 9
to ccameron chromium, Daniel Cheng, Vasiliy Telezhnikov, Antonio Rivera, Dale Curtis, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Dale Curtis and ccameron chromium
Daniel Cheng voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dale Curtis
- ccameron chromium
Dale Curtis (Gerrit)
Dec 9, 2025, 5:40:29 PM (12 days ago) Dec 9
to ccameron chromium, Daniel Cheng, Vasiliy Telezhnikov, Antonio Rivera, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from ccameron chromium
Dale Curtis voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ccameron chromium (Gerrit)
Dec 10, 2025, 1:42:27 AM (12 days ago) Dec 10
to ccameron chromium, Dale Curtis, Daniel Cheng, Vasiliy Telezhnikov, Antonio Rivera, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org
ccameron chromium voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 10, 2025, 1:47:45 AM (12 days ago) Dec 10
to ccameron chromium, Dale Curtis, Daniel Cheng, Vasiliy Telezhnikov, Antonio Rivera, AyeAye, chromium...@chromium.org, android-web...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gfx::HDRMetadata: de-optionalize remains
The gfx::HDRMetadata structure is just a container of various types of
metadata, which can be empty (by having none of them). Putting a
gfx::HDRMetadata in a std::optional provides a redundant mechanism for
indicating that all of the fields are empty.
Replace most remaining instances of std::optional<gfx::HDRMetadata> with
gfx::HDRMetadata. Replace std::optional<gfx::HDRMetadata>::has_value
with !gfx::HDRMetadata::IsEmpty.
Leave in place the std::optional<gfx::HDRMetadata> in OverlayPlaneData's
constructor, to keep the size of the change manageable.
Bug: 395659818
Change-Id: I37ead8cc89afc4f8f265063aade447be25eab3ed
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Commit-Queue: ccameron chromium <ccam...@chromium.org>
Reviewed-by: Antonio Rivera <anto...@google.com>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1556544}
Files:
- M android_webview/browser/gfx/overlay_processor_webview.cc
- M chromecast/starboard/media/renderer/chromium_starboard_conversions.cc
- M components/metal_util/hdr_copier_layer.h
- M components/metal_util/hdr_copier_layer.mm
- M media/base/test_helpers.cc
- M media/gpu/mac/vt_config_util.h
- M media/gpu/mac/vt_config_util.mm
- M media/gpu/mac/vt_config_util_unittest.mm
- M ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
- M ui/gfx/android/android_surface_control_compat.cc
- M ui/gfx/android/android_surface_control_compat.h
- M ui/gfx/color_transform.cc
- M ui/gfx/color_transform.h
- M ui/gfx/hdr_metadata.cc
- M ui/gfx/hdr_metadata.h
- M ui/gfx/hdr_metadata_mac.h
- M ui/gfx/hdr_metadata_mac.mm
- M ui/gfx/overlay_plane_data.cc
- M ui/gfx/overlay_plane_data.h
- M ui/gl/gl_surface_egl_surface_control.h
- M ui/gl/swap_chain_presenter.cc
- M ui/ozone/platform/wayland/common/wayland_overlay_config.h
- M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc
- M ui/ozone/platform/wayland/host/wayland_frame_manager.cc
- M ui/ozone/platform/wayland/mojom/wayland_overlay_config.mojom
- M ui/ozone/platform/wayland/mojom/wayland_overlay_config_mojom_traits.h
Change size: M
Delta: 26 files changed, 76 insertions(+), 82 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dale Curtis, +1 by Antonio Rivera, +1 by Vasiliy Telezhnikov, +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages