[//ui] Remove SurfaceFactoryOzone::CreateNativePixmap(BufferFormat) [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
Nov 3, 2025, 9:21:29 AM (3 days ago) Nov 3
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Nov 4, 2025, 2:54:46 AM (2 days ago) Nov 4
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 4, 2025, 3:03:53 AM (2 days ago) Nov 4
to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[//ui] Remove SurfaceFactoryOzone::CreateNativePixmap(BufferFormat)
This method is no longer overridden by any subclasses.
Bug: 450325664
Change-Id: Iff9a40548d0996bebf5a38edde0983ce10f877c2
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1539813}
Files:
- M ui/ozone/public/surface_factory_ozone.cc
- M ui/ozone/public/surface_factory_ozone.h
Change size: S
Delta: 2 files changed, 1 insertion(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Nov 4, 2025, 3:17:23 AM (2 days ago) Nov 4
to Chromium LUCI CQ, Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org
luci-bi...@appspot.gserviceaccount.com has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Nov 4, 2025, 9:29:49 AM (2 days ago) Nov 4
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Vasiliy Telezhnikov . resolved
lgtm, thanks.
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 5, 2025, 2:55:22 AM (yesterday) Nov 5
to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[//ui] Remove SurfaceFactoryOzone::CreateNativePixmap(BufferFormat)
This method is no longer overridden by any subclasses.
Note: This is a reland on top of removing Cast's override.
Bug: 450325664
Change-Id: I8359d29e4f07c32c04da30fe87c585a7069325ac
Commit-Queue: Colin Blundell <blun...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540499}
Files:
- M ui/ozone/public/surface_factory_ozone.cc
- M ui/ozone/public/surface_factory_ozone.h
Change size: S
Delta: 2 files changed, 1 insertion(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages