Revert "CrOS: Remove the Peripheral Cust. flag." [chromium/src : main]

[Hidehiko Abe (Gerrit)]

Attention needed from James Hawkins, Michael Checo, Michael Spang and Ming-Ying Chung

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Hidehiko Abe . resolved

rslgtm for the reverting.

Open in Gerrit

Related details

Attention is currently required from:

• James Hawkins
• Michael Checo
• Michael Spang
• Ming-Ying Chung

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Icdc4f031e86ee5906381bd772c0fb67ebad3a064

Gerrit-Change-Number: 8190758

Gerrit-PatchSet: 1

Gerrit-Owner: Ming-Ying Chung <my...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: James Hawkins <jhaw...@chromium.org>

Gerrit-Reviewer: Michael Checo <michae...@google.com>

Gerrit-Reviewer: Michael Spang <sp...@chromium.org>

Gerrit-Reviewer: Ming-Ying Chung <my...@chromium.org>

Gerrit-Reviewer: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Michael Checo <michae...@google.com>

Gerrit-Attention: James Hawkins <jhaw...@chromium.org>

Gerrit-Attention: Michael Spang <sp...@chromium.org>

Gerrit-Attention: Ming-Ying Chung <my...@chromium.org>

Gerrit-Comment-Date: Tue, 04 Aug 2026 05:55:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Ming-Ying Chung (Gerrit)]

Attention needed from James Hawkins, Michael Checo and Michael Spang

Ming-Ying Chung voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• James Hawkins
• Michael Checo
• Michael Spang

Gerrit-Comment-Date: Tue, 04 Aug 2026 05:56:59 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Revert "CrOS: Remove the Peripheral Cust. flag."

This reverts commit 206225cd64c59a3e3f12439143bbc45c9aae74e8.

Reason for revert: breaks multiple chromeos builders

Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/105731/overview

Original change's description:
> CrOS: Remove the Peripheral Cust. flag.
>
> Which has been enabled for a while.
>
> Bug: none
> Test: none
> Change-Id: I055e0061c34c197f5e17b750214d09e6d61cd6ef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8184175
> Commit-Queue: James Hawkins <jhaw...@chromium.org>
> Reviewed-by: Michael Checo <michae...@google.com>
> Reviewed-by: Hidehiko Abe <hide...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1673042}

Bug: 542268670

No-Presubmit: true

No-Tree-Checks: true

No-Try: true

Bug: none

Change-Id: Icdc4f031e86ee5906381bd772c0fb67ebad3a064

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8190758

Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Owners-Override: Ming-Ying Chung <my...@chromium.org>

Reviewed-by: Hidehiko Abe <hide...@chromium.org>

Commit-Queue: Ming-Ying Chung <my...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1673120}

Files:

• M ash/accelerators/accelerator_controller_unittest.cc
• M ash/accelerators/shortcut_input_handler.cc
• M ash/constants/ash_features.cc
• M ash/constants/ash_features.h
• M ash/events/peripheral_customization_event_rewriter_unittest.cc
• M ash/shell.cc
• M ash/system/input_device_settings/input_device_notifier.cc
• M ash/system/input_device_settings/input_device_settings_controller_impl.cc
• M ash/system/input_device_settings/input_device_settings_controller_unittest.cc
• M ash/system/input_device_settings/input_device_settings_dispatcher.cc
• M ash/system/input_device_settings/input_device_settings_dispatcher_unittest.cc
• M ash/system/input_device_settings/pref_handlers/graphics_tablet_pref_handler_impl.cc
• M ash/system/input_device_settings/pref_handlers/graphics_tablet_pref_handler_unittest.cc
• M ash/system/input_device_settings/pref_handlers/mouse_pref_handler_impl.cc
• M ash/system/input_device_settings/pref_handlers/mouse_pref_handler_unittest.cc
• M ash/webui/common/backend/accelerator_fetcher_unittest.cc
• M ash/webui/common/backend/shortcut_input_provider.cc
• M ash/webui/common/backend/shortcut_input_provider_unittest.cc
• M chrome/browser/about_flags.cc
• M chrome/browser/ash/events/event_rewriter_delegate_impl.cc
• M chrome/browser/ash/events/event_rewriter_unittest.cc
• M chrome/browser/flag-metadata.json
• M chrome/browser/flag_descriptions.h
• M chrome/browser/resources/ash/settings/device_page/device_page.html
• M chrome/browser/resources/ash/settings/device_page/device_page.ts
• M chrome/browser/resources/ash/settings/device_page/per_device_mouse_subsection.html
• M chrome/browser/resources/ash/settings/device_page/per_device_mouse_subsection.ts
• M chrome/browser/resources/ash/settings/os_settings_routes.ts
• M chrome/browser/ui/ash/system/system_tray_client_impl.cc
• M chrome/browser/ui/ash/system/system_tray_client_impl_unittest.cc
• M chrome/browser/ui/webui/ash/settings/integration_tests/device_page/device_settings_interactive_uitest.cc
• M chrome/browser/ui/webui/ash/settings/os_settings_ui.cc
• M chrome/browser/ui/webui/ash/settings/pages/device/device_section.cc
• M chrome/browser/ui/webui/ash/settings/pages/device/input_device_settings/input_device_settings_provider.cc
• M chrome/browser/ui/webui/ash/settings/pages/device/input_device_settings/input_device_settings_provider_unittest.cc
• M chrome/browser/ui/webui/ash/settings/services/settings_manager/os_settings_manager_unittest.cc
• M chrome/test/data/webui/chromeos/settings/device_page/device_page_test.ts
• M chrome/test/data/webui/chromeos/settings/device_page/per_device_mouse_subsection_test.ts
• M chrome/test/data/webui/chromeos/settings/os_settings_browsertest.cc
• M ui/events/ozone/evdev/keyboard_evdev.cc
• M ui/events/ozone/evdev/pen_tablet_event_converter_evdev.cc
• M ui/events/ozone/evdev/pen_tablet_event_converter_evdev_unittest.cc

Change size: L

Delta: 42 files changed, 592 insertions(+), 128 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Hidehiko Abe, Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Icdc4f031e86ee5906381bd772c0fb67ebad3a064

Gerrit-Change-Number: 8190758

Gerrit-PatchSet: 2