ozone/wayland: Don't fold tablet tool buttons into pointer motion flags [chromium/src : main]
0 views
Skip to first unread message
The Techromancer (Gerrit)
Aug 5, 2026, 11:50:57 PM (7 days ago) Aug 5
to Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson
The Techromancer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
The Techromancer . resolved
A pesky little bug I discovered while building darkly.art. Sometimes, an extra pen event with 0.5 pressure would appear at the end of a stroke. Screenshot before and after the fix:
https://issues.chromium.org/action/issues/497284918/attachments/80276193
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Aug 6, 2026, 11:07:11 AM (7 days ago) Aug 6
to The Techromancer, Thomas Lukaszewicz, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from The Techromancer and Thomas Lukaszewicz
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Code-Review | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Thomas Anderson . resolved
+tluk for secondary approval (fangzhoug is OOO)
Related details
Attention is currently required from:
- The Techromancer
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
Aug 6, 2026, 2:56:12 PM (7 days ago) Aug 6
to The Techromancer, Chromium LUCI CQ, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from The Techromancer
Thomas Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Lukaszewicz
| Code-Review | +1 |
1 comment
Patchset-level comments
Thomas Lukaszewicz . resolved
lgtm
Related details
Attention is currently required from:
- The Techromancer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Aug 6, 2026, 5:31:06 PM (6 days ago) Aug 6
to The Techromancer, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from The Techromancer
Thomas Anderson voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- The Techromancer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
The Techromancer (Gerrit)
Aug 7, 2026, 1:05:10 AM (6 days ago) Aug 7
to Thomas Lukaszewicz, Chromium LUCI CQ, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson and Thomas Lukaszewicz
The Techromancer added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Thomas Anderson
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Aug 7, 2026, 10:50:00 AM (6 days ago) Aug 7
to The Techromancer, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from The Techromancer and Thomas Lukaszewicz
Thomas Anderson voted![]( "Open in Gerrit")
Attention is currently required from:
- The Techromancer
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
Aug 9, 2026, 2:16:24 PM (4 days ago) Aug 9
to The Techromancer, Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from The Techromancer
Thomas Lukaszewicz voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- The Techromancer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Aug 10, 2026, 12:17:02 PM (3 days ago) Aug 10
to The Techromancer, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from The Techromancer
Thomas Anderson voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Aug 10, 2026, 2:27:59 PM (3 days ago) Aug 10
to The Techromancer, Thomas Lukaszewicz, Thomas Anderson, chromium...@chromium.org, Kramer Ge, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
ozone/wayland: Don't fold tablet tool buttons into pointer motion flags
Some compositors warp the seat cursor to follow a tablet tool. Sway emits
a wl_pointer.motion 5us after zwp_tablet_tool_v2.up(), and
OnPointerMotionEvent folded tablet_tool_buttons_ into that event's flags.
The tool's button state is still latched at that point, because its up
sits in frame_data_ until the tablet frame arrives, so the mouse move
went out claiming a button was held that the mouse does not have held.
In Blink this surfaces as a pointerType:"mouse" sample with pointerId 1
and the spec-default pressure:0.5, injected between the last real pen
sample and pointerup -- the pointer type changing mid-stroke, as reported.
The tool's own button state already reaches Aura correctly through
OnTabletToolMotion(), which emits kMouseDragged with real PointerDetails.
Verified on an ILITEK ILIT2901 digitizer under Sway: a stroke now logs no
pointer type changes and no mouse-typed samples.
R=thomasa...@chromium.org
Fixed: 497284918
Change-Id: Ic5765fc650a6dd408f8ce6d01fe6cae07f8ece98
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1676595}
Files:
- M ui/ozone/platform/wayland/host/wayland_event_source.cc
- M ui/ozone/platform/wayland/host/wayland_event_source_unittest.cc
Change size: S
Delta: 2 files changed, 42 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Anderson, +1 by Thomas Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages