Add a flag to enable libinput to handle touchpad [chromium/src : main]

Marek Maślanka (Gerrit)

unread,

Sep 16, 2021, 5:27:56 PM9/16/21

to Jeffery Miller, Harry Cutts, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org

Attention is currently required from: Jeffery Miller, Harry Cutts.

Marek Maślanka would like Jeffery Miller and Harry Cutts to review this change.

View Change

Add a flag to enable libinput to handle touchpad

Add a new flag to chromium to allow uses libinput to handle touchpad
instead of libgestures.

Bug: b:192669240
Change-Id: Ib96d8dc3274133e9a7005c47499a28b41af16c45
---
M ash/constants/ash_features.cc
M ash/constants/ash_features.h
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
6 files changed, 26 insertions(+), 0 deletions(-)

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Marek Maślanka (Gerrit)

unread,

Sep 16, 2021, 5:28:03 PM9/16/21

to asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Harry Cutts, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Jeffery Miller, Harry Cutts.

View Change

1 comment:

Patchset:
- Patch Set #1:
  Hi,
  This first part of commit to control whether libinput should be uses to handle touchpad

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Sep 16, 2021, 6:02:37 PM9/16/21

to Marek Maślanka, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Harry Cutts, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Jeffery Miller, Marek Maślanka.

View Change

7 comments:

File chrome/browser/about_flags.cc:
- Patch Set #1, Line 5577: {"enable-libinput-to-handle-touchpad",
  New entries should be added to the end of this list (see the comment on line 2655).
File chrome/browser/flag-metadata.json:
- Patch Set #1, Line 2139: hcutts
  Add chromeo...@google.com instead of just me to the owners.
- Patch Set #1, Line 2140: "expiry_milestone": 98
  Since this is a developer flag, let's not add an expiry milestone. You can set it to -1 and add an entry in flag-never-expire-list.json. This will mean higher-level OWNERS have to review, but I think it should be fine.
File chrome/browser/flag_descriptions.cc:
- Patch Set #1, Line 4171: or mice
  I thought we were just going to use it for touchpads, did that change?
- Patch Set #1, Line 4171: libgesture library
  Nit: we normally call it "the gestures library"
- Patch Set #1, Line 4173: or not
  Nit: "or is not"
- Patch Set #1, Line 4173: input
  Nit: "an input device"

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Marek Maślanka (Gerrit)

unread,

Sep 20, 2021, 11:19:16 AM9/20/21

to asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Chromium Metrics Reviews, Harry Cutts, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Jeffery Miller, Harry Cutts.

View Change

7 comments:

File chrome/browser/about_flags.cc:

- Patch Set #1, Line 5577: {"enable-libinput-to-handle-touchpad",
  New entries should be added to the end of this list (see the comment on line 2655).

- Done
File chrome/browser/flag-metadata.json:

- Patch Set #1, Line 2139: hcutts
  Add chromeo...@google.com instead of just me to the owners.

- Done

- Patch Set #1, Line 2140: "expiry_milestone": 98

- Since this is a developer flag, let's not add an expiry milestone. […]
  Done
File chrome/browser/flag_descriptions.cc:
- Patch Set #1, Line 4171: libgesture library

- Nit: we normally call it "the gestures library"

- Done

- Patch Set #1, Line 4171: or mice
  I thought we were just going to use it for touchpads, did that change?

- It hasn't changed, my fault

- Patch Set #1, Line 4173: input
  Nit: "an input device"

- Done

- Patch Set #1, Line 4173: or not
  Nit: "or is not"

- Done

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Sep 21, 2021, 10:16:44 AM9/21/21

to Marek Maślanka, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Harry Cutts, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Jeffery Miller, Marek Maślanka.

Patch set 2:Code-Review +1

View Change

2 comments:

File chrome/browser/flag-metadata.json:
- Patch Set #2, Line 2140: it's
  Nit: typo ("it")
File chrome/browser/flag_descriptions.cc:
- Patch Set #2, Line 4171: libiput
  Nit: typo

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Sep 21, 2021, 10:17:09 AM9/21/21

to Elly Fong-Jones, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Marek Maślanka, Harry Cutts, Jeffery Miller

Attention is currently required from: Elly Fong-Jones, Jeffery Miller, Marek Maślanka.

Harry Cutts would like Elly Fong-Jones to review this change authored by Marek Maślanka.

View Change

Add a flag to enable libinput to handle touchpad

Add a new flag to chromium to allow uses libinput to handle touchpad
instead of libgestures.

Bug: b:192669240
Change-Id: Ib96d8dc3274133e9a7005c47499a28b41af16c45
---

M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag-never-expire-list.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M tools/metrics/histograms/enums.xml
M ui/events/ozone/evdev/libinput_event_converter.cc
M ui/events/ozone/features.cc
M ui/events/ozone/features.h
9 files changed, 56 insertions(+), 13 deletions(-)

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Sep 21, 2021, 10:17:20 AM9/21/21

to Marek Maślanka, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Elly Fong-Jones, Harry Cutts, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Elly Fong-Jones, Jeffery Miller, Marek Maślanka.

View Change

1 comment:

Patchset:
- Patch Set #2:
  Hi Elly, could you take a look at this never-expiring flag we'd like to add?

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Elly Fong-Jones (Gerrit)

unread,

Sep 21, 2021, 12:45:28 PM9/21/21

to Marek Maślanka, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Elly Fong-Jones, Harry Cutts, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Jeffery Miller, Marek Maślanka.

View Change

1 comment:

Patchset:
- Patch Set #2:
  does this flag actually need to be indefinite? currently it sounds like it's an experiment. can you imagine still wanting this flag to be present in, eg, 2025?

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Sep 21, 2021, 1:47:42 PM9/21/21

to Marek Maślanka, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Elly Fong-Jones, Harry Cutts, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Elly Fong-Jones, Jeffery Miller, Marek Maślanka.

View Change

1 comment:

Patchset:
- Patch Set #2:
  does this flag actually need to be indefinite? currently it sounds like it's an experiment. […]
  This isn't particularly experimental; we're merging this functionality in from CloudReady (a Chromium OS fork), which has been using it for older touchpads for years. This flag would be useful when we get reports of the touchpad not working well on an older laptop running CloudReady 2.0, as we could ask the user to flip the flag and see if that improves it.
  Thinking of 2025, though, I'm guessing people won't be using the old touchpads much by then. If we're happy to set the milestone that far into the future, that could be an option.

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Elly Fong-Jones (Gerrit)

unread,

Sep 21, 2021, 4:10:28 PM9/21/21

to Marek Maślanka, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Elly Fong-Jones, Harry Cutts, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Jeffery Miller, Marek Maślanka.

Patch set 2:Code-Review +1

View Change

2 comments:

Patchset:
- Patch Set #2:
  This isn't particularly experimental; we're merging this functionality in from CloudReady (a Chromiu […]
  Far-future milestones (like, 120) are fine with me, but this does also sound like a legit use case for a never-expire flag, so lgtm.
- Patch Set #2:
  lgtm!

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Marek Maślanka (Gerrit)

unread,

Sep 21, 2021, 5:42:23 PM9/21/21

to asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Elly Fong-Jones, Harry Cutts, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Jeffery Miller.

View Change

2 comments:

File chrome/browser/flag-metadata.json:

- Patch Set #2, Line 2140: it's
  Nit: typo ("it")

- Done
File chrome/browser/flag_descriptions.cc:

- Patch Set #2, Line 4171: libiput
  Nit: typo

- Done

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Marek Maślanka (Gerrit)

unread,

Sep 22, 2021, 12:57:34 PM9/22/21

to Michael Pobega, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Elly Fong-Jones, Harry Cutts, Jeffery Miller

Attention is currently required from: Michael Pobega, Jeffery Miller.

Marek Maślanka would like Michael Pobega to review this change.

View Change

Add a flag to enable libinput to handle touchpad

Add a new flag to chromium to allow uses libinput to handle touchpad
instead of libgestures.

Bug: b:192669240
Change-Id: Ib96d8dc3274133e9a7005c47499a28b41af16c45
---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag-never-expire-list.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M tools/metrics/histograms/enums.xml
M ui/events/ozone/evdev/libinput_event_converter.cc
M ui/events/ozone/features.cc
M ui/events/ozone/features.h
9 files changed, 56 insertions(+), 13 deletions(-)

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Oct 4, 2021, 6:07:30 AM10/4/21

to Marek Maślanka, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Harry Cutts, Michael Pobega, Elly Fong-Jones, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Michael Pobega, Jeffery Miller, Marek Maślanka.

Patch set 6:Code-Review +1Commit-Queue +2

View Change

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Oct 6, 2021, 8:20:17 AM10/6/21

to Marek Maślanka, Harry Cutts, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Chromium LUCI CQ, Michael Pobega, Elly Fong-Jones, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Marek Maślanka.

Patch set 9:Code-Review +1

View Change

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Oct 6, 2021, 8:21:48 AM10/6/21

to Marek Maślanka, Harry Cutts, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Chromium LUCI CQ, Michael Pobega, Elly Fong-Jones, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Marek Maślanka.

View Change

1 comment:

Patchset:
- Patch Set #9:
  Hi Sean, I had to manually rebase this, which seems to mean my owners votes on Ozone don't count anymore because it's my patchset. Could you take a quick look?

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Oct 7, 2021, 7:08:14 AM10/7/21

to Sean O'Brien, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Marek Maślanka, Harry Cutts, Michael Pobega, Elly Fong-Jones, Jeffery Miller

Attention is currently required from: Sean O'Brien, Marek Maślanka.

Harry Cutts would like Sean O'Brien to review this change authored by Marek Maślanka.

View Change

Add a flag to enable libinput to handle touchpad

Add a new flag to chromium to allow uses libinput to handle touchpad

instead of the gestures library.



Bug: b:192669240
Change-Id: Ib96d8dc3274133e9a7005c47499a28b41af16c45
---

M chrome/browser/flag_descriptions.cc
M chrome/browser/about_flags.cc
M chrome/browser/flag_descriptions.h
M chrome/browser/flag-metadata.json
M ui/events/ozone/features.cc
M ui/events/ozone/features.h
M tools/metrics/histograms/enums.xml
M chrome/browser/flag-never-expire-list.json
M ui/events/ozone/evdev/input_device_factory_evdev.cc
9 files changed, 60 insertions(+), 3 deletions(-)

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Oct 7, 2021, 7:08:22 AM10/7/21

to Marek Maślanka, Harry Cutts, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Sean O'Brien, Chromium LUCI CQ, Michael Pobega, Elly Fong-Jones, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Sean O'Brien, Marek Maślanka.

Patch set 10:Code-Review +1Commit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #10:
  Oops, it appears I forgot to actually add Sean to the reviewers last time...

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Sean O'Brien (Gerrit)

unread,

Oct 7, 2021, 10:54:08 AM10/7/21

to Marek Maślanka, Harry Cutts, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Chromium LUCI CQ, Michael Pobega, Elly Fong-Jones, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Marek Maślanka, Harry Cutts.

Patch set 10:Code-Review +1Commit-Queue +2

View Change

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Oct 7, 2021, 11:00:56 AM10/7/21

to Marek Maślanka, Harry Cutts, asvitkine...@chromium.org, lucmult...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Sean O'Brien, Michael Pobega, Elly Fong-Jones, Chromium Metrics Reviews, Jeffery Miller, chromium...@chromium.org, Sadrul Chowdhury

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Elly Fong-Jones: Looks good to me
  Sean O'Brien: Looks good to me; Commit
  Harry Cutts: Looks good to me

Add a flag to enable libinput to handle touchpad

Add a new flag to chromium to allow uses libinput to handle touchpad
instead of the gestures library.

Bug: b:192669240
Change-Id: Ib96d8dc3274133e9a7005c47499a28b41af16c45

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3166630
Reviewed-by: Harry Cutts <hcu...@chromium.org>
Reviewed-by: Sean O'Brien <seob...@chromium.org>
Reviewed-by: Elly Fong-Jones <elly...@chromium.org>
Commit-Queue: Sean O'Brien <seob...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929195}


---
M chrome/browser/flag_descriptions.cc
M chrome/browser/about_flags.cc
M chrome/browser/flag_descriptions.h
M chrome/browser/flag-metadata.json
M ui/events/ozone/features.cc
M ui/events/ozone/features.h
M tools/metrics/histograms/enums.xml
M chrome/browser/flag-never-expire-list.json
M ui/events/ozone/evdev/input_device_factory_evdev.cc

9 files changed, 66 insertions(+), 3 deletions(-)

To view, visit change 3166630. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward