[//gpu] Eliminate clone of handle in ClientSharedImage [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
Jan 8, 2026, 11:57:47 AMJan 8
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, Zijie He, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 8, 2026, 11:58:49 AMJan 8
to Colin Blundell, Antonio Sartori, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, Zijie He, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Antonio Sartori
Colin Blundell added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Colin Blundell . resolved
Thanks! +Antonio for mappable_buffer_native_pixmap.h
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Jan 9, 2026, 2:03:30 AMJan 9
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, Zijie He, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell
Antonio Sartori voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 9, 2026, 2:49:23 AMJan 9
to Colin Blundell, Antonio Sartori, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, Zijie He, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 3:07:37 AMJan 9
to Colin Blundell, Antonio Sartori, Vasiliy Telezhnikov, chromium...@chromium.org, David Worsham, Robert Kroeger, Zijie He, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[//gpu] Eliminate clone of handle in ClientSharedImage
Our hypothesis is that crbug.com/472087363 is arising due to the clone
of the handle failing. This CL avoids the clone by adding an API to get
the needed information directly from the existing handle.
Bug: 472087363
Change-Id: I4ac7d911a80fb55e1a622befa7fefc91bc21c263
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Reviewed-by: Antonio Sartori <antonio...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566776}
Files:
- M gpu/command_buffer/client/client_shared_image.cc
- M gpu/command_buffer/client/internal/mappable_buffer_native_pixmap.h
- M media/fuchsia/video/fuchsia_video_decoder_unittest.cc
- M ui/gfx/client_native_pixmap.h
- M ui/gfx/linux/client_native_pixmap_dmabuf.cc
- M ui/gfx/linux/client_native_pixmap_dmabuf.h
- M ui/gfx/linux/client_native_pixmap_factory_dmabuf.cc
- M ui/ozone/platform/flatland/client_native_pixmap_factory_flatland.cc
Change size: S
Delta: 8 files changed, 20 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov, +1 by Antonio Sartori
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Battre (Gerrit)
Jan 9, 2026, 3:29:08 AMJan 9
to Chromium LUCI CQ, Colin Blundell, Antonio Sartori, Vasiliy Telezhnikov, chromium...@chromium.org, David Worsham, Robert Kroeger, Zijie He, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Dominic Battre has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 9, 2026, 8:36:37 AMJan 9
to Colin Blundell, Vasiliy Telezhnikov, Antonio Sartori, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, Zijie He, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Antonio Sartori and Vasiliy Telezhnikov
Colin Blundell added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Colin Blundell . resolved
Diff for the reland is between PS1 and PS2: https://chromium-review.googlesource.com/c/chromium/src/+/7415166/1..2
Related details
Attention is currently required from:
- Antonio Sartori
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Jan 9, 2026, 8:56:23 AMJan 9
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, Zijie He, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell and Vasiliy Telezhnikov
Antonio Sartori voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Colin Blundell
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Jan 9, 2026, 9:41:12 AMJan 9
to Colin Blundell, Antonio Sartori, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, Zijie He, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Vasiliy Telezhnikov . resolved
lgtm, thanks.
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 12, 2026, 10:13:00 AMJan 12
to Colin Blundell, Vasiliy Telezhnikov, Antonio Sartori, Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, Zijie He, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Colin Blundell . resolved
Thanks!
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 12, 2026, 11:58:36 AMJan 12
to Colin Blundell, Vasiliy Telezhnikov, Antonio Sartori, chromium...@chromium.org, David Worsham, Robert Kroeger, Zijie He, emi...@google.com, feature-me...@chromium.org, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[//gpu] Eliminate clone of handle in ClientSharedImage
Our hypothesis is that crbug.com/472087363 is arising due to the clone
of the handle failing. This CL avoids the clone by adding an API to get
the needed information directly from the existing handle.
Bug: 472087363
Change-Id: I9c5c7d2db7a18762cd545c9a57892740b3a14ac6
Reviewed-by: Antonio Sartori <antonio...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567824}
Files:
- M gpu/command_buffer/client/client_shared_image.cc
- M gpu/command_buffer/client/internal/mappable_buffer_native_pixmap.h
- M media/fuchsia/video/fuchsia_video_decoder_unittest.cc
- M ui/gfx/client_native_pixmap.h
- M ui/gfx/linux/client_native_pixmap_dmabuf.cc
- M ui/gfx/linux/client_native_pixmap_dmabuf.h
- M ui/gfx/linux/client_native_pixmap_factory_dmabuf.cc
- M ui/ozone/platform/cast/client_native_pixmap_factory_cast.cc
- M ui/ozone/platform/flatland/client_native_pixmap_factory_flatland.cc
Change size: S
Delta: 9 files changed, 21 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov, +1 by Antonio Sartori
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages