Reland "Move logging::LoggingSettings to base/logging/logging_settings.h" [chromium/src : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Nov 20, 2025, 6:06:44 PM (10 days ago) Nov 20
to Lei Zhang, Chromium LUCI CQ, Francois Pierre Doray, AyeAye, Enterprise Policy Reviews, Mathias Bynens, Stephen Chenney, chromotin...@chromium.org, Zijie He, chromium...@chromium.org, (Julie)Jeongeun Kim, Fumitoshi Ukai, Dirk Schulze, Peter Beverloo, vaapi-...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, kuragin+web-ap...@chromium.org, net-r...@chromium.org, mgiuca...@chromium.org, dtseng...@chromium.org, loyso...@chromium.org, sky+...@chromium.org, josiah...@chromium.org, ios-r...@chromium.org, abigailbk...@google.com, oshima...@chromium.org, wfh+...@chromium.org, kinuko...@chromium.org, dmurph+watc...@chromium.org, blink-...@chromium.org, extension...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, jshin...@chromium.org, roblia...@chromium.org, feature-me...@chromium.org, nektar...@chromium.org, ios-web-view...@google.com, fserb...@chromium.org, media-cro...@chromium.org, lcwu+...@chromium.org, ozone-...@chromium.org, fuchsia...@chromium.org, fmalit...@chromium.org, jdeblas...@chromium.org, zelin+watch-we...@chromium.org, mac-r...@chromium.org, chromium-a...@chromium.org, agriev...@chromium.org, halliwe...@chromium.org, drott+bl...@chromium.org, webap...@microsoft.com, headless...@chromium.org, francisjp...@google.com, yuzo+...@chromium.org, kyungjunle...@google.com, chromeos-gfx-...@google.com, blink-reviews-p...@chromium.org, dibyapal+wa...@chromium.org, grt+...@chromium.org, fuzzin...@chromium.org
Attention needed from Francois Pierre Doray and Lei Zhang

Message from Lei Zhang

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie877c3c85cc3e1983fb8b2b065b0d09607442ce4
Gerrit-Change-Number: 7173024
Gerrit-PatchSet: 4
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Fumitoshi Ukai <uk...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Thu, 20 Nov 2025 23:06:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Nov 20, 2025, 6:13:16 PM (10 days ago) Nov 20
to Lei Zhang, Chromium LUCI CQ, Francois Pierre Doray, AyeAye, Enterprise Policy Reviews, Mathias Bynens, Stephen Chenney, chromotin...@chromium.org, Zijie He, chromium...@chromium.org, (Julie)Jeongeun Kim, Fumitoshi Ukai, Dirk Schulze, Peter Beverloo, vaapi-...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, kuragin+web-ap...@chromium.org, net-r...@chromium.org, mgiuca...@chromium.org, dtseng...@chromium.org, loyso...@chromium.org, sky+...@chromium.org, josiah...@chromium.org, ios-r...@chromium.org, abigailbk...@google.com, oshima...@chromium.org, wfh+...@chromium.org, kinuko...@chromium.org, dmurph+watc...@chromium.org, blink-...@chromium.org, extension...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, jshin...@chromium.org, roblia...@chromium.org, feature-me...@chromium.org, nektar...@chromium.org, ios-web-view...@google.com, fserb...@chromium.org, media-cro...@chromium.org, lcwu+...@chromium.org, ozone-...@chromium.org, fuchsia...@chromium.org, fmalit...@chromium.org, jdeblas...@chromium.org, zelin+watch-we...@chromium.org, mac-r...@chromium.org, chromium-a...@chromium.org, agriev...@chromium.org, halliwe...@chromium.org, drott+bl...@chromium.org, webap...@microsoft.com, headless...@chromium.org, francisjp...@google.com, yuzo+...@chromium.org, kyungjunle...@google.com, chromeos-gfx-...@google.com, blink-reviews-p...@chromium.org, dibyapal+wa...@chromium.org, grt+...@chromium.org, fuzzin...@chromium.org
Attention needed from Francois Pierre Doray

Lei Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Lei Zhang . resolved

I think all the kinks have been worked out separately, so ready for review again. Please OO+1 again.

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Thu, 20 Nov 2025 23:12:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Nov 20, 2025, 8:02:52 PM (10 days ago) Nov 20
to Lei Zhang, Chromium LUCI CQ, AyeAye, Enterprise Policy Reviews, Mathias Bynens, Stephen Chenney, chromotin...@chromium.org, Zijie He, chromium...@chromium.org, (Julie)Jeongeun Kim, Fumitoshi Ukai, Dirk Schulze, Peter Beverloo, vaapi-...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, kuragin+web-ap...@chromium.org, net-r...@chromium.org, mgiuca...@chromium.org, dtseng...@chromium.org, loyso...@chromium.org, sky+...@chromium.org, josiah...@chromium.org, ios-r...@chromium.org, abigailbk...@google.com, oshima...@chromium.org, wfh+...@chromium.org, kinuko...@chromium.org, dmurph+watc...@chromium.org, blink-...@chromium.org, extension...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, jshin...@chromium.org, roblia...@chromium.org, feature-me...@chromium.org, nektar...@chromium.org, ios-web-view...@google.com, fserb...@chromium.org, media-cro...@chromium.org, lcwu+...@chromium.org, ozone-...@chromium.org, fuchsia...@chromium.org, fmalit...@chromium.org, jdeblas...@chromium.org, zelin+watch-we...@chromium.org, mac-r...@chromium.org, chromium-a...@chromium.org, agriev...@chromium.org, halliwe...@chromium.org, drott+bl...@chromium.org, webap...@microsoft.com, headless...@chromium.org, francisjp...@google.com, yuzo+...@chromium.org, kyungjunle...@google.com, chromeos-gfx-...@google.com, blink-reviews-p...@chromium.org, dibyapal+wa...@chromium.org, grt+...@chromium.org, fuzzin...@chromium.org
Attention needed from Lei Zhang

Francois Pierre Doray voted and added 1 comment

Votes added by Francois Pierre Doray

Code-Review+1
Commit-Queue+2
Owners-Override+1

1 comment

Patchset-level comments
Francois Pierre Doray . resolved

CR+1
OO+1 for mechanical changes outside of //base to adapt to a //base change

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie877c3c85cc3e1983fb8b2b065b0d09607442ce4
Gerrit-Change-Number: 7173024
Gerrit-PatchSet: 4
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Fumitoshi Ukai <uk...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Fri, 21 Nov 2025 01:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 20, 2025, 10:40:24 PM (10 days ago) Nov 20
to Lei Zhang, Francois Pierre Doray, AyeAye, Enterprise Policy Reviews, Mathias Bynens, Stephen Chenney, chromotin...@chromium.org, Zijie He, chromium...@chromium.org, (Julie)Jeongeun Kim, Fumitoshi Ukai, Akihiro Ota, Dirk Schulze, Peter Beverloo, vaapi-...@chromium.org, philli...@chromium.org, ios-rev...@chromium.org, kuragin+web-ap...@chromium.org, net-r...@chromium.org, mgiuca...@chromium.org, dtseng...@chromium.org, loyso...@chromium.org, sky+...@chromium.org, josiah...@chromium.org, ios-r...@chromium.org, abigailbk...@google.com, oshima...@chromium.org, wfh+...@chromium.org, kinuko...@chromium.org, dmurph+watc...@chromium.org, blink-...@chromium.org, extension...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org, jshin...@chromium.org, roblia...@chromium.org, feature-me...@chromium.org, nektar...@chromium.org, ios-web-view...@google.com, fserb...@chromium.org, media-cro...@chromium.org, lcwu+...@chromium.org, ozone-...@chromium.org, fuchsia...@chromium.org, fmalit...@chromium.org, jdeblas...@chromium.org, zelin+watch-we...@chromium.org, mac-r...@chromium.org, chromium-a...@chromium.org, agriev...@chromium.org, halliwe...@chromium.org, drott+bl...@chromium.org, webap...@microsoft.com, headless...@chromium.org, francisjp...@google.com, yuzo+...@chromium.org, kyungjunle...@google.com, chromeos-gfx-...@google.com, blink-reviews-p...@chromium.org, dibyapal+wa...@chromium.org, grt+...@chromium.org, fuzzin...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Reland "Move logging::LoggingSettings to base/logging/logging_settings.h"

This is a reland of commit 6b79baf89a1d87407d4bafdc5d871061a81f80fc

The reland is the same CL. The difference is the problematic code in a
separate repo that did not do IWYU has been fixed.

Original change's description:
> Move logging::LoggingSettings to base/logging/logging_settings.h
>
> Move struct LoggingSettings, which is only used in a relatively small
> number of files, out of base/logging.h and into its own header. Update
> direct users and then do IWYU to fix the build. This effectively moves
> base/files/file_path.h out of base/logging.h.
>
> Change-Id: I04209f1063051b7399e335d7e30cb7abb9442c94
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7160150
> Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
> Commit-Queue: Lei Zhang <the...@chromium.org>
> Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1546655}
Change-Id: Ie877c3c85cc3e1983fb8b2b065b0d09607442ce4
Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Commit-Queue: Francois Pierre Doray <fdo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1548242}
Files:
  • M base/BUILD.gn
  • M base/fuchsia/fidl_event_handler_unittest.cc
  • M base/fuchsia/fuchsia_logging_unittest.cc
  • M base/i18n/build_utf8_validator_tables.cc
  • M base/logging.cc
  • M base/logging.h
  • A base/logging/logging_settings.h
  • M base/logging_unittest.cc
  • M base/logging_win.cc
  • M base/test/scoped_logging_settings.h
  • M base/test/test_suite.cc
  • M chrome/browser/ash/logging/logging.cc
  • M chrome/browser/os_crypt/app_bound_encryption_test_main.cc
  • M chrome/browser/web_applications/chrome_pwa_launcher/chrome_pwa_launcher_main.cc
  • M chrome/chrome_proxy/chrome_proxy_main_win.cc
  • M chrome/common/logging_chrome.cc
  • M chrome/common/logging_chrome.h
  • M chrome/credential_provider/extension/extension_main.cc
  • M chrome/credential_provider/gaiacp/gaia_credential_provider_module.cc
  • M chrome/credential_provider/setup/setup.cc
  • M chrome/enterprise_companion/enterprise_companion.cc
  • M chrome/enterprise_companion/test/run_all_integration_tests.cc
  • M chrome/enterprise_companion/test/run_all_unittests.cc
  • M chrome/enterprise_companion/test/test_crashpad_embedder.cc
  • M chrome/installer/gcapi/gcapi_dll.cc
  • M chrome/installer/util/logging_installer.cc
  • M chrome/test/accessibility/ax_client/ax_client_main.cc
  • M chrome/test/base/chromeos/crosier/helper/fake_chrome/fake_chrome_main.cc
  • M chrome/test/chromedriver/logging.cc
  • M chrome/updater/test/unit_test_util.cc
  • M chrome/updater/util/util.cc
  • M chrome/utility/safe_browsing/mac/dmg_fuzzer.cc
  • M chrome/windows_services/service_program/logging_support.cc
  • M chromecast/app/cast_main_delegate.cc
  • M chromecast/base/init_command_line_shlib.cc
  • M chromecast/crash/linux/crash_uploader.cc
  • M chromecast/external_mojo/external_service_support/process_setup.cc
  • M chromecast/tracing/tracing_service_main.cc
  • M components/chromeos_camera/jpeg_encode_accelerator_unittest.cc
  • M components/chromeos_camera/mjpeg_decode_accelerator_unittest.cc
  • M components/cronet/android/cronet_library_loader.cc
  • M components/policy/test_support/fake_dmserver.cc
  • M components/url_formatter/spoof_checks/top_domains/make_top_domain_list_variables.cc
  • M components/url_formatter/spoof_checks/top_domains/top_domain_generator.cc
  • M components/webrtc_logging/logging_unittest.cc
  • M components/wifi/wifi_test.cc
  • M components/zucchini/zucchini_main.cc
  • M content/app/android/library_loader_hooks.cc
  • M content/child/child_thread_impl.cc
  • M content/shell/app/shell_main_delegate.cc
  • M content/zygote/zygote_linux.cc
  • M extensions/shell/app/shell_main_delegate.cc
  • M fuchsia_web/common/init_logging.cc
  • M google_apis/gcm/tools/mcs_probe.cc
  • M headless/lib/headless_content_main_delegate.cc
  • M ios/chrome/app/startup/ios_chrome_main_delegate.mm
  • M ios/web_view/internal/web_view_web_main_delegate.mm
  • M media/gpu/test/video_test_environment.cc
  • M media/gpu/v4l2/test/v4l2_stateless_decoder.cc
  • M media/gpu/vaapi/test/decode.cc
  • M mojo/proxy/main.cc
  • M net/dns/dns_record_fuzzer.cc
  • M net/third_party/quiche/overrides/quiche_platform_impl/quiche_command_line_flags_impl.cc
  • M net/tools/cert_verify_tool/cert_verify_tool.cc
  • M net/tools/net_watcher/net_watcher.cc
  • M net/tools/root_store_tool/root_store_tool.cc
  • M net/tools/stress_cache/stress_cache.cc
  • M net/tools/testserver/run_testserver.cc
  • M net/tools/tld_cleanup/tld_cleanup.cc
  • M net/tools/transport_security_state_generator/transport_security_state_generator.cc
  • M remoting/base/logging_linux.cc
  • M remoting/base/logging_mac.cc
  • M remoting/base/logging_win.cc
  • M remoting/client/cli/remoting_client_main.cc
  • M remoting/host/setup/start_host_main.cc
  • M services/service_manager/public/cpp/service_executable/main.cc
  • M sql/fuzzers/recovery_lpm_fuzzer.cc
  • M third_party/blink/renderer/DEPS
  • M third_party/blink/renderer/platform/fonts/shaping/harfbuzz_shaper_fuzzer.cc
  • M third_party/crashpad/crashpad/handler/handler_main.cc
  • M third_party/crashpad/crashpad/test/gtest_main.cc
  • M third_party/puffin/src/chromium_main.cc
  • M third_party/win_virtual_display/controller/DEPS
  • M third_party/win_virtual_display/controller/display_driver_controller_main.cc
  • M tools/android/forwarder2/daemon.cc
  • M tools/mac/power/power_sampler/power_sampler_main.cc
  • M tools/memory/simulator/memory_simulator_main.cc
  • M ui/ozone/demo/ozone_demo.cc
  • M ui/ozone/demo/skia/skia_demo.cc
  • M ui/views_content_client/views_content_main_delegate.cc
  • M ui/webui/examples/app/main_delegate.cc
Change size: L
Delta: 91 files changed, 195 insertions(+), 82 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Francois Pierre Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie877c3c85cc3e1983fb8b2b065b0d09607442ce4
Gerrit-Change-Number: 7173024
Gerrit-PatchSet: 5
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages