[//gpu] Remove GpuExtraInfo::gpu_memory_buffer_format_x11 [chromium/src : main]

0 views
Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,
Nov 5, 2025, 10:22:59 AM (22 hours ago) Nov 5
to Colin Blundell, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, ipc-securi...@chromium.org
Attention needed from Colin Blundell

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I46279768ebeabf18602f6876ff018b49c1b5b9aa
Gerrit-Change-Number: 7123821
Gerrit-PatchSet: 4
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Nov 2025 15:22:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Nov 5, 2025, 10:33:29 AM (22 hours ago) Nov 5
to Colin Blundell, Antonio Sartori, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, ipc-securi...@chromium.org
Attention needed from Antonio Sartori

Colin Blundell added 1 comment

Patchset-level comments
Colin Blundell . resolved

Thanks! +Antonio for the mojom

Open in Gerrit

Related details

Attention is currently required from:
  • Antonio Sartori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I46279768ebeabf18602f6876ff018b49c1b5b9aa
Gerrit-Change-Number: 7123821
Gerrit-PatchSet: 4
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Antonio Sartori <antonio...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Nov 2025 15:33:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Antonio Sartori (Gerrit)

unread,
Nov 5, 2025, 12:15:22 PM (20 hours ago) Nov 5
to Colin Blundell, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, ipc-securi...@chromium.org
Attention needed from Colin Blundell

Antonio Sartori voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I46279768ebeabf18602f6876ff018b49c1b5b9aa
Gerrit-Change-Number: 7123821
Gerrit-PatchSet: 4
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Nov 2025 17:15:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
2:49 AM (6 hours ago) 2:49 AM
to Colin Blundell, Antonio Sartori, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, ipc-securi...@chromium.org

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I46279768ebeabf18602f6876ff018b49c1b5b9aa
Gerrit-Change-Number: 7123821
Gerrit-PatchSet: 4
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Nov 2025 07:48:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
3:27 AM (5 hours ago) 3:27 AM
to Colin Blundell, Antonio Sartori, Vasiliy Telezhnikov, AyeAye, chromium...@chromium.org, ozone-...@chromium.org, ipc-securi...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[//gpu] Remove GpuExtraInfo::gpu_memory_buffer_format_x11

This field is now never set.
Bug: 457646315
Change-Id: I46279768ebeabf18602f6876ff018b49c1b5b9aa
Reviewed-by: Antonio Sartori <antonio...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1541084}
Files:
  • M gpu/command_buffer/service/shared_image/shared_image_factory.cc
  • M ui/gfx/gpu_extra_info.h
  • M ui/gfx/mojom/gpu_extra_info.mojom
  • M ui/gfx/mojom/gpu_extra_info_mojom_traits.cc
  • M ui/gfx/mojom/gpu_extra_info_mojom_traits.h
  • M ui/ozone/platform/x11/ozone_platform_x11.cc
  • M ui/ozone/public/ozone_platform.h
Change size: S
Delta: 7 files changed, 0 insertions(+), 49 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Vasiliy Telezhnikov, +1 by Antonio Sartori
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I46279768ebeabf18602f6876ff018b49c1b5b9aa
Gerrit-Change-Number: 7123821
Gerrit-PatchSet: 5
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages