Validate extensions requested by glRequestExtensionCHROMIUM [chromium/src : main]
0 views
Skip to first unread message
Geoff Lang (Gerrit)
Apr 27, 2026, 10:19:10 AM (2 days ago) Apr 27
to Corentin Wallez, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org
Attention needed from Corentin Wallez
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Corentin Wallez
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Corentin Wallez (Gerrit)
Apr 27, 2026, 10:36:40 AM (2 days ago) Apr 27
to Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org
Attention needed from Geoff Lang
Corentin Wallez voted and added 3 comments![]( "Open in Gerrit")
Votes added by Corentin Wallez
| Code-Review | +1 |
3 comments
Patchset-level comments
File gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
Line 4074, Patchset 8 (Latest):
} else {Corentin Wallez . unresolved
nit: we could return an `error::InvalidArgument`
Line 4098, Patchset 8 (Latest):
BuildRequestableExtensionString();Corentin Wallez . unresolved
Is the reason that we rebuild the requestableExtensionString that the newly requested extensions are removed from it?
Related details
Attention is currently required from:
- Geoff Lang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Geoff Lang (Gerrit)
Apr 27, 2026, 11:45:26 AM (2 days ago) Apr 27
to Corentin Wallez, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org
Geoff Lang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Geoff Lang
| Commit-Queue | +2 |
2 comments
File gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
Line 4074, Patchset 8 (Latest):
} else {Corentin Wallez . resolved
nit: we could return an `error::InvalidArgument`
Geoff Lang
It is valid to request the same extension multiple times and the WebGL layers do this since there is some overlap in WebGL ext -> multiple native exts.
ANGLE just validates that the extension's type is requestable, not that it is in the requestable string.
Line 4098, Patchset 8 (Latest):
BuildRequestableExtensionString();Corentin Wallez . resolved
Is the reason that we rebuild the requestableExtensionString that the newly requested extensions are removed from it?
Geoff Lang
Yep, it's expected that the extension strings update after requesting extensions.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 27, 2026, 4:04:55 PM (2 days ago) Apr 27
to Geoff Lang, Corentin Wallez, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Validate extensions requested by glRequestExtensionCHROMIUM
glRequestExtensionCHROMIUM would forward extension requests to ANGLE for
enabling WebGL extensions but ANGLE hides many other extensions from the
user by marking them as requestable. A compromised renderer can request
these extensions.
Use a list of pre-validated extensions that are valid to request. This
list is generated from the extensions requested by the WebGL bindings
and the previous list of extensions needed for command decoder
functionality.
For non-WebGL command decoders, disable all extensions by default and
request all valid extensions after the context has been created.
Fixed: 505074145
Change-Id: I046a9f91bb2d1f99e92bc5c07610fd8f3c84c702
Commit-Queue: Geoff Lang <geof...@chromium.org>
Reviewed-by: Corentin Wallez <cwa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1621253}
Files:
- M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
- M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
- M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
- M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_unittest_framebuffers.cc
- M gpu/command_buffer/service/service_utils.cc
- M gpu/command_buffer/tests/gl_request_extension_unittest.cc
- M ui/gl/generate_bindings.py
- M ui/gl/gl_bindings_autogen_egl.cc
- M ui/gl/gl_bindings_autogen_egl.h
- M ui/gl/gl_context.h
- M ui/gl/gl_context_egl.cc
Change size: L
Delta: 11 files changed, 261 insertions(+), 77 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Corentin Wallez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages