Ozone/Wayland: Avoid reading non-existent MIME types from data offer [chromium/src : main]
0 views
Skip to first unread message
Thomas Anderson (Gerrit)
Jun 22, 2026, 4:43:32 PM (7 days ago) Jun 22
to Thomas Lukaszewicz, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Lukaszewicz
Thomas Anderson voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
Jun 22, 2026, 6:35:50 PM (6 days ago) Jun 22
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson
Thomas Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Lukaszewicz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Jun 22, 2026, 6:39:04 PM (6 days ago) Jun 22
to Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Thomas Anderson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 22, 2026, 6:42:55 PM (6 days ago) Jun 22
to Thomas Anderson, Thomas Lukaszewicz, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Ozone/Wayland: Avoid reading non-existent MIME types from data offer
Clipboard readers often probe multiple standard MIME types (e.g.,
text/plain, text/html, image/png) during paste or selection change
events to inspect available formats. When requesting an unsupported MIME
type, WaylandDataOffer::Receive returns an invalid file descriptor.
Because no system call actually fails inside Receive in this scenario,
logging an error using DPLOG with the invalid descriptor prints a
confusing and incorrect error message containing a stale thread errno
(e.g., "Resource temporarily unavailable").
Avoid calling Receive and log spamming by checking if the requested MIME
type is actually present in the data offer's list of available MIME
types before executing the request.
Bug: 40898398
Change-Id: I3d1e3dc4e4096a383d377d269fb4a97826b80345
Auto-Submit: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1650630}
Files:
- M ui/ozone/platform/wayland/host/wayland_clipboard_unittest.cc
- M ui/ozone/platform/wayland/host/wayland_data_device_base.cc
Change size: S
Delta: 2 files changed, 31 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages