Use `std::move` to avoid a vector copy. [chromium/src : main]

0 views
Skip to first unread message

Jimmy Gong (Gerrit)

unread,
Feb 25, 2026, 5:36:16 PMFeb 25
to Jeffrey Yu, AyeAye, Chromium LUCI CQ, print-rev...@chromium.org, cros-print...@google.com, ajayramamurthy+w...@google.com, extension...@chromium.org, andysjl...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, vakh+safe_br...@chromium.org, zackha...@chromium.org, chromium-a...@chromium.org, hansberry+wat...@chromium.org, borealis-re...@google.com, nwoked...@chromium.org, joeantonetti+wa...@google.com, oshima...@chromium.org, jackshira+wat...@google.com, jonmann+watc...@chromium.org, xinghui...@chromium.org, ozone-...@chromium.org, druber...@chromium.org
Attention needed from Jeffrey Yu

Jimmy Gong voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I519472bf9bbf2e96011f95ef3d8c8760246a6742
Gerrit-Change-Number: 7530584
Gerrit-PatchSet: 18
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Jimmy Gong <jimmy...@chromium.org>
Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
Gerrit-Comment-Date: Wed, 25 Feb 2026 22:36:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jeffrey Yu (Gerrit)

unread,
Feb 25, 2026, 6:11:34 PMFeb 25
to Piotr Pawliczek, Jimmy Gong, AyeAye, Chromium LUCI CQ, print-rev...@chromium.org, cros-print...@google.com, ajayramamurthy+w...@google.com, extension...@chromium.org, andysjl...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, vakh+safe_br...@chromium.org, zackha...@chromium.org, chromium-a...@chromium.org, hansberry+wat...@chromium.org, borealis-re...@google.com, nwoked...@chromium.org, joeantonetti+wa...@google.com, oshima...@chromium.org, jackshira+wat...@google.com, jonmann+watc...@chromium.org, xinghui...@chromium.org, ozone-...@chromium.org, druber...@chromium.org
Attention needed from Piotr Pawliczek

Jeffrey Yu voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Piotr Pawliczek
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I519472bf9bbf2e96011f95ef3d8c8760246a6742
Gerrit-Change-Number: 7530584
Gerrit-PatchSet: 18
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Jimmy Gong <jimmy...@chromium.org>
Gerrit-Reviewer: Piotr Pawliczek <pawl...@chromium.org>
Gerrit-Attention: Piotr Pawliczek <pawl...@chromium.org>
Gerrit-Comment-Date: Wed, 25 Feb 2026 23:11:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Piotr Pawliczek (Gerrit)

unread,
Feb 25, 2026, 6:18:04 PMFeb 25
to Jeffrey Yu, Jimmy Gong, AyeAye, Chromium LUCI CQ, print-rev...@chromium.org, cros-print...@google.com, ajayramamurthy+w...@google.com, extension...@chromium.org, andysjl...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, vakh+safe_br...@chromium.org, zackha...@chromium.org, chromium-a...@chromium.org, hansberry+wat...@chromium.org, borealis-re...@google.com, nwoked...@chromium.org, joeantonetti+wa...@google.com, oshima...@chromium.org, jackshira+wat...@google.com, jonmann+watc...@chromium.org, xinghui...@chromium.org, ozone-...@chromium.org, druber...@chromium.org
Attention needed from Jeffrey Yu

Piotr Pawliczek voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I519472bf9bbf2e96011f95ef3d8c8760246a6742
    Gerrit-Change-Number: 7530584
    Gerrit-PatchSet: 18
    Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Jimmy Gong <jimmy...@chromium.org>
    Gerrit-Reviewer: Piotr Pawliczek <pawl...@chromium.org>
    Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Comment-Date: Wed, 25 Feb 2026 23:17:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 25, 2026, 6:21:45 PMFeb 25
    to Jeffrey Yu, Piotr Pawliczek, Jimmy Gong, AyeAye, print-rev...@chromium.org, cros-print...@google.com, ajayramamurthy+w...@google.com, extension...@chromium.org, andysjl...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, vakh+safe_br...@chromium.org, zackha...@chromium.org, chromium-a...@chromium.org, hansberry+wat...@chromium.org, borealis-re...@google.com, nwoked...@chromium.org, joeantonetti+wa...@google.com, oshima...@chromium.org, jackshira+wat...@google.com, jonmann+watc...@chromium.org, xinghui...@chromium.org, ozone-...@chromium.org, druber...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Use `std::move` to avoid a vector copy.
    Change-Id: I519472bf9bbf2e96011f95ef3d8c8760246a6742
    Reviewed-by: Piotr Pawliczek <pawl...@chromium.org>
    Commit-Queue: Piotr Pawliczek <pawl...@chromium.org>
    Auto-Submit: Jeffrey Yu <yu...@chromium.org>
    Reviewed-by: Jimmy Gong <jimmy...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1590456}
    Files:
    • M chromeos/printing/usb_printer_id.cc
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Piotr Pawliczek, +1 by Jimmy Gong
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I519472bf9bbf2e96011f95ef3d8c8760246a6742
    Gerrit-Change-Number: 7530584
    Gerrit-PatchSet: 19
    Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages