Migrate "gfx::native_widget_types*" target to "gfx::native_ui_types*" [chromium/src : main]

0 views
Skip to first unread message

Mitsuru Oshima (Gerrit)

unread,
Jan 6, 2026, 12:42:17 PM (5 days ago) Jan 6
to Elly FJ, Colin Blundell, James Cook, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, James Su, headless...@chromium.org, cblume...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanad...@chromium.org
Attention needed from Colin Blundell, Elly FJ and James Cook

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Elly FJ
  • James Cook
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I44e6568b1b5f78050340b27e33257ce3b6aa09d1
Gerrit-Change-Number: 7396436
Gerrit-PatchSet: 8
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Attention: James Cook <jame...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Elly FJ <elly...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 17:42:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Jan 6, 2026, 12:43:29 PM (5 days ago) Jan 6
to Kim DongYoung, Elly FJ, Colin Blundell, James Cook, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, James Su, headless...@chromium.org, cblume...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanad...@chromium.org
Attention needed from Colin Blundell, Elly FJ and James Cook

Mitsuru Oshima added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Mitsuru Oshima . resolved

cc:dongyoungkim345@ FYI

Gerrit-CC: Kim DongYoung <dongyou...@gmail.com>
Gerrit-Attention: James Cook <jame...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Elly FJ <elly...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 17:43:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Jan 6, 2026, 12:45:23 PM (5 days ago) Jan 6
to Kim DongYoung, Elly FJ, Colin Blundell, James Cook, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, James Su, headless...@chromium.org, cblume...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanad...@chromium.org
Attention needed from Colin Blundell, Elly FJ and James Cook

Mitsuru Oshima added 1 comment

Patchset-level comments
Mitsuru Oshima . resolved

ellyjones@ -> chrome/
blundell@ -> components/, gpu/, ui/
jamescook@ -> extensions/

Gerrit-Comment-Date: Tue, 06 Jan 2026 17:45:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Elly FJ (Gerrit)

unread,
Jan 6, 2026, 1:44:15 PM (5 days ago) Jan 6
to Mitsuru Oshima, Elly FJ, Kim DongYoung, Colin Blundell, James Cook, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, James Su, headless...@chromium.org, cblume...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanad...@chromium.org
Attention needed from Colin Blundell, James Cook and Mitsuru Oshima

Elly FJ voted and added 1 comment

Votes added by Elly FJ

Code-Review+1

1 comment

Patchset-level comments
Elly FJ . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • James Cook
  • Mitsuru Oshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I44e6568b1b5f78050340b27e33257ce3b6aa09d1
    Gerrit-Change-Number: 7396436
    Gerrit-PatchSet: 8
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kim DongYoung <dongyou...@gmail.com>
    Gerrit-Attention: James Cook <jame...@chromium.org>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Tue, 06 Jan 2026 18:44:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    James Cook (Gerrit)

    unread,
    Jan 6, 2026, 2:07:19 PM (5 days ago) Jan 6
    to Mitsuru Oshima, Elly FJ, Kim DongYoung, Colin Blundell, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, James Su, headless...@chromium.org, cblume...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanad...@chromium.org
    Attention needed from Colin Blundell and Mitsuru Oshima

    James Cook voted and added 1 comment

    Votes added by James Cook

    Code-Review+1

    1 comment

    Patchset-level comments
    James Cook . resolved

    LGTM for extensions

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Colin Blundell
    • Mitsuru Oshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I44e6568b1b5f78050340b27e33257ce3b6aa09d1
    Gerrit-Change-Number: 7396436
    Gerrit-PatchSet: 8
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kim DongYoung <dongyou...@gmail.com>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Tue, 06 Jan 2026 19:07:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kim DongYoung (Gerrit)

    unread,
    Jan 7, 2026, 1:59:14 AM (5 days ago) Jan 7
    to Mitsuru Oshima, James Cook, Elly FJ, Colin Blundell, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, James Su, headless...@chromium.org, cblume...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanad...@chromium.org
    Attention needed from Colin Blundell and Mitsuru Oshima

    Kim DongYoung added 1 comment

    Patchset-level comments
    Mitsuru Oshima . resolved

    cc:dongyoungkim345@ FYI

    Kim DongYoung

    LGTM!

    Gerrit-Comment-Date: Wed, 07 Jan 2026 06:58:50 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Colin Blundell (Gerrit)

    unread,
    Jan 7, 2026, 3:30:28 AM (5 days ago) Jan 7
    to Mitsuru Oshima, Colin Blundell, James Cook, Elly FJ, Kim DongYoung, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, James Su, headless...@chromium.org, cblume...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanad...@chromium.org
    Attention needed from Mitsuru Oshima

    Colin Blundell voted and added 1 comment

    Votes added by Colin Blundell

    Code-Review+1

    1 comment

    Patchset-level comments
    Colin Blundell . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mitsuru Oshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I44e6568b1b5f78050340b27e33257ce3b6aa09d1
    Gerrit-Change-Number: 7396436
    Gerrit-PatchSet: 8
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kim DongYoung <dongyou...@gmail.com>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Wed, 07 Jan 2026 08:30:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Mitsuru Oshima (Gerrit)

    unread,
    Jan 7, 2026, 3:57:08 PM (4 days ago) Jan 7
    to Colin Blundell, James Cook, Elly FJ, Kim DongYoung, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, James Su, headless...@chromium.org, cblume...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanad...@chromium.org

    Mitsuru Oshima voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I44e6568b1b5f78050340b27e33257ce3b6aa09d1
    Gerrit-Change-Number: 7396436
    Gerrit-PatchSet: 8
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kim DongYoung <dongyou...@gmail.com>
    Gerrit-Comment-Date: Wed, 07 Jan 2026 20:57:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Mitsuru Oshima (Gerrit)

    unread,
    Jan 9, 2026, 2:43:35 PM (2 days ago) Jan 9
    to Colin Blundell, James Cook, Elly FJ, Kim DongYoung, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, James Su, headless...@chromium.org, cblume...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanad...@chromium.org
    Gerrit-Comment-Date: Fri, 09 Jan 2026 19:43:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 9, 2026, 4:33:49 PM (2 days ago) Jan 9
    to Mitsuru Oshima, Colin Blundell, James Cook, Elly FJ, Kim DongYoung, AyeAye, chromium...@chromium.org, James Su, headless...@chromium.org, cblume...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, keithle...@chromium.org, nicolas...@chromium.org, nona+...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, ydago...@chromium.org, yhanad...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Migrate "gfx::native_widget_types*" target to "gfx::native_ui_types*"

    the file ui/gfx/native_widget_types.h has beeb
    renamed to "native_ui_types.h", and so should the gn targets be.

    This also updates the reference in the comments.

    Bug: 440644556
    Change-Id: I44e6568b1b5f78050340b27e33257ce3b6aa09d1
    Reviewed-by: Elly FJ <elly...@chromium.org>
    Commit-Queue: Mitsuru Oshima <osh...@chromium.org>
    Reviewed-by: Colin Blundell <blun...@chromium.org>
    Reviewed-by: James Cook <jame...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1567187}
    Files:
    • M chrome/browser/apps/app_service/app_install/BUILD.gn
    • M chrome/browser/touch_to_fill/password_manager/password_generation/android/BUILD.gn
    • M chrome/browser/ui/omnibox/BUILD.gn
    • M chrome/browser/ui/pdf/infobar/BUILD.gn
    • M chrome/browser/ui/startup/default_browser_prompt/pin_infobar/BUILD.gn
    • M components/fullscreen_control/BUILD.gn
    • M components/headless/select_file_dialog/BUILD.gn
    • M extensions/browser/api/messaging/BUILD.gn
    • M extensions/browser/install/BUILD.gn
    • M gpu/ipc/common/BUILD.gn
    • M gpu/vulkan/BUILD.gn
    • M ui/base/ime/init/BUILD.gn
    • M ui/base/interaction/BUILD.gn
    • M ui/events/ozone/BUILD.gn
    • M ui/gfx/BUILD.gn
    • M ui/gfx/mojom/accelerated_widget.mojom
    • M ui/gtk/BUILD.gn
    • M ui/views/BUILD.gn
    • M ui/views/controls/webview/BUILD.gn
    Change size: M
    Delta: 19 files changed, 29 insertions(+), 29 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Colin Blundell, +1 by James Cook, +1 by Elly FJ
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I44e6568b1b5f78050340b27e33257ce3b6aa09d1
    Gerrit-Change-Number: 7396436
    Gerrit-PatchSet: 9
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages