ozone/wayland: Enable out-of-window clip delegation [chromium/src : main]

0 views
Skip to first unread message

Eriko Kurimoto (Gerrit)

unread,
Sep 8, 2023, 3:22:47 AMSep 8
to Mitsuru Oshima, ozone-...@chromium.org, Peter McNeeley

Attention is currently required from: Mitsuru Oshima.

Eriko Kurimoto would like Mitsuru Oshima to review this change.

View Change

ozone/wayland: Enable out-of-window clip delegation

This CL enables out-of-window clip delegation.

The known issues are resolved:
1. Window boundary jittery -> crrev.com/c/4825687
2. Incorrect input resgion -> crrev.com/c/4835455

Bug: 1476832
Change-Id: Id183cba525a3b5d86ec1968f000d2fd966c6bc92
---
M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.cc
M ui/ozone/platform/wayland/host/surface_augmenter.cc
M ui/ozone/platform/wayland/ozone_platform_wayland.cc
3 files changed, 8 insertions(+), 11 deletions(-)


To view, visit change 4852540. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id183cba525a3b5d86ec1968f000d2fd966c6bc92
Gerrit-Change-Number: 4852540
Gerrit-PatchSet: 1
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Peter McNeeley <peterm...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>

Eriko Kurimoto (Gerrit)

unread,
Sep 8, 2023, 3:22:54 AMSep 8
to ozone-...@chromium.org, Mitsuru Oshima, Peter McNeeley, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Mitsuru Oshima.

View Change

1 comment:

To view, visit change 4852540. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id183cba525a3b5d86ec1968f000d2fd966c6bc92
Gerrit-Change-Number: 4852540
Gerrit-PatchSet: 1
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: Peter McNeeley <peterm...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Fri, 08 Sep 2023 07:22:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Mitsuru Oshima (Gerrit)

unread,
Sep 8, 2023, 5:21:27 AMSep 8
to Eriko Kurimoto, ozone-...@chromium.org, Peter McNeeley, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Eriko Kurimoto.

Patch set 1:Code-Review +1

View Change

    To view, visit change 4852540. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id183cba525a3b5d86ec1968f000d2fd966c6bc92
    Gerrit-Change-Number: 4852540
    Gerrit-PatchSet: 1
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-CC: Peter McNeeley <peterm...@chromium.org>
    Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Comment-Date: Fri, 08 Sep 2023 09:21:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    Peter McNeeley (Gerrit)

    unread,
    Sep 8, 2023, 4:36:50 PMSep 8
    to Eriko Kurimoto, ozone-...@chromium.org, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Eriko Kurimoto.

    Patch set 1:Code-Review -1

    The change is no longer submittable: Code-Review is unsatisfied now.

    View Change

    1 comment:

    • Patchset:

      • Patch Set #1:

        This does not work and will cause missing inputs. Tested.

    To view, visit change 4852540. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id183cba525a3b5d86ec1968f000d2fd966c6bc92
    Gerrit-Change-Number: 4852540
    Gerrit-PatchSet: 1
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Peter McNeeley <peterm...@chromium.org>
    Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Comment-Date: Fri, 08 Sep 2023 20:36:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes

    Eriko Kurimoto (Gerrit)

    unread,
    Sep 8, 2023, 9:42:47 PMSep 8
    to ozone-...@chromium.org, Peter McNeeley, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Peter McNeeley.

    View Change

    1 comment:

    • Patchset:

      • Patch Set #1:

        This does not work and will cause missing inputs. Tested.

    To view, visit change 4852540. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id183cba525a3b5d86ec1968f000d2fd966c6bc92
    Gerrit-Change-Number: 4852540
    Gerrit-PatchSet: 1
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Peter McNeeley <peterm...@chromium.org>
    Gerrit-Attention: Peter McNeeley <peterm...@chromium.org>
    Gerrit-Comment-Date: Sat, 09 Sep 2023 01:42:33 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Peter McNeeley <peterm...@chromium.org>

    Peter McNeeley (Gerrit)

    unread,
    Sep 11, 2023, 11:44:09 AMSep 11
    to Eriko Kurimoto, ozone-...@chromium.org, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Eriko Kurimoto.

    Patch set 1:Code-Review +1

    View Change

    1 comment:

    To view, visit change 4852540. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id183cba525a3b5d86ec1968f000d2fd966c6bc92
    Gerrit-Change-Number: 4852540
    Gerrit-PatchSet: 1
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Peter McNeeley <peterm...@chromium.org>
    Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Comment-Date: Mon, 11 Sep 2023 15:43:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes

    Eriko Kurimoto (Gerrit)

    unread,
    Sep 11, 2023, 11:48:19 AMSep 11
    to ozone-...@chromium.org, Peter McNeeley, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

    Patch set 1:Commit-Queue +2

    View Change

    1 comment:

    • Patchset:

      • Thank you for the confirmation.

    To view, visit change 4852540. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id183cba525a3b5d86ec1968f000d2fd966c6bc92
    Gerrit-Change-Number: 4852540
    Gerrit-PatchSet: 1
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Peter McNeeley <peterm...@chromium.org>
    Gerrit-Comment-Date: Mon, 11 Sep 2023 15:48:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Peter McNeeley <peterm...@chromium.org>

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 11, 2023, 12:53:47 PMSep 11
    to Eriko Kurimoto, ozone-...@chromium.org, Peter McNeeley, Mitsuru Oshima, chromium...@chromium.org

    Chromium LUCI CQ submitted this change.

    View Change

    Approvals: Peter McNeeley: Looks good to me Eriko Kurimoto: Commit Mitsuru Oshima: Looks good to me
    ozone/wayland: Enable out-of-window clip delegation

    This CL enables out-of-window clip delegation.

    The known issues are resolved:
    1. Window boundary jittery -> crrev.com/c/4825687
    2. Incorrect input resgion -> crrev.com/c/4835455

    Bug: 1476832
    Change-Id: Id183cba525a3b5d86ec1968f000d2fd966c6bc92
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4852540
    Commit-Queue: Eriko Kurimoto <elk...@chromium.org>
    Reviewed-by: Peter McNeeley <peterm...@chromium.org>
    Reviewed-by: Mitsuru Oshima <osh...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1194905}

    ---
    M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.cc
    M ui/ozone/platform/wayland/host/surface_augmenter.cc
    M ui/ozone/platform/wayland/ozone_platform_wayland.cc
    3 files changed, 8 insertions(+), 11 deletions(-)


    To view, visit change 4852540. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id183cba525a3b5d86ec1968f000d2fd966c6bc92
    Gerrit-Change-Number: 4852540
    Gerrit-PatchSet: 2
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Peter McNeeley <peterm...@chromium.org>
    Reply all
    Reply to author
    Forward
    0 new messages