Rename native_widget_types -> native_window_types [chromium/src : main]

0 views
Skip to first unread message

Mitsuru Oshima (Gerrit)

unread,
Aug 28, 2025, 10:36:57 AM (11 days ago) Aug 28
to Avi Drissman, Chromium LUCI CQ, AJITH KUMAR V, AJITH KUMAR V, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, David Worsham, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Robert Kroeger, Sadrul Chowdhury, Simon Hangl, James Su, Ian Vollick, Zijie He, abigailbk...@google.com, ajayramamurthy+w...@google.com, alexmo...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, byronle...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-waff...@google.com, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-essential...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, emi...@google.com, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gavinwill+sc...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wat...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loyso...@chromium.org, lucasrada...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, mattreyno...@chromium.org, max+watc...@igalia.com, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, npnavarro+p...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, rsesek...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Avi Drissman

Mitsuru Oshima added 1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Avi Drissman . resolved

Hi. Please stop. I have serious objections to this rename. Please see http://b/440644556#comment8.

Mitsuru Oshima

Replied. PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is blockingCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If88ffebf3687775a6723669e2495b600e9c6af97
Gerrit-Change-Number: 6871204
Gerrit-PatchSet: 10
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Thu, 28 Aug 2025 14:36:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Avi Drissman <a...@chromium.org>
satisfied_requirement
unsatisfied_requirement
blocking_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Sep 5, 2025, 1:05:58 PM (3 days ago) Sep 5
to Avi Drissman, Chromium LUCI CQ, AJITH KUMAR V, AJITH KUMAR V, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, David Worsham, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Robert Kroeger, Sadrul Chowdhury, Simon Hangl, James Su, Ian Vollick, Zijie He, abigailbk...@google.com, ajayramamurthy+w...@google.com, alexmo...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, byronle...@chromium.org, cblume...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-waff...@google.com, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, croissant-...@chromium.org, cros-ed...@google.com, cros-essential...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, droger+w...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, emi...@google.com, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gavinwill+sc...@chromium.org, gcasto+w...@chromium.org, giovax...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wat...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loyso...@chromium.org, lucasrada...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, mattreyno...@chromium.org, max+watc...@igalia.com, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, nicolas...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, npnavarro+p...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghu...@chromium.org, penghuan...@chromium.org, philli...@chromium.org, phoglun...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, rsesek...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Mitsuru Oshima abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is blockingCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
blocking_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages