TabDragging tests: Set browser bounds using mouse emulation [chromium/src : main]

0 views
Skip to first unread message

Max Ihlenfeldt (Gerrit)

unread,
Sep 26, 2023, 8:28:04 AM9/26/23
to Maksim Sisov, Scott Violet, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention is currently required from: Maksim Sisov, Scott Violet.

Max Ihlenfeldt would like Maksim Sisov and Scott Violet to review this change.

View Change

TabDragging tests: Set browser bounds using mouse emulation

On Linux ozone/wayland we can't control the browser bounds, but many
TabDragging tests expect specific bounds and will fail if the actual
bounds are different.

This CL introduces a workaround that allows us to still set the browser
bounds on this platform. The idea is to use ui_controls to emulate mouse
events that will resize and move the browser to where we want (like a
regular user would do).

Bug: 1474921
Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
---
M chrome/browser/ui/views/tabs/tab_drag_controller.cc
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
M testing/buildbot/filters/ozone-linux.interactive_ui_tests_wayland.filter
M ui/base/test/ui_controls.h
M ui/ozone/platform/wayland/emulate/wayland_input_emulate.cc
M ui/ozone/platform/wayland/emulate/wayland_input_emulate.h
M ui/ozone/platform/wayland/test/wayland_ozone_ui_controls_test_helper.cc
M ui/ozone/platform/wayland/test/wayland_ozone_ui_controls_test_helper.h
M ui/ozone/public/ozone_ui_controls_test_helper.cc
M ui/ozone/public/ozone_ui_controls_test_helper.h
M ui/views/test/ui_controls_factory_desktop_aura_ozone.cc
11 files changed, 256 insertions(+), 44 deletions(-)


To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
Gerrit-Change-Number: 4738688
Gerrit-PatchSet: 13
Gerrit-Owner: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Maksim Sisov <msi...@igalia.com>
Gerrit-Attention: Scott Violet <s...@chromium.org>

Max Ihlenfeldt (Gerrit)

unread,
Sep 26, 2023, 8:28:10 AM9/26/23
to ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, Maksim Sisov, Scott Violet, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Maksim Sisov, Scott Violet.

View Change

1 comment:

  • Patchset:

    • Patch Set #13:

      Maksim, PTAL at the `//ui/ozone/platform/wayland` changes.

      Scott, PTAL at the rest. It's been a while, but maybe you remember that we shortly discussed this approach via email back in February.

To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
Gerrit-Change-Number: 4738688
Gerrit-PatchSet: 13
Gerrit-Owner: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Maksim Sisov <msi...@igalia.com>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Comment-Date: Tue, 26 Sep 2023 12:27:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Maksim Sisov (Gerrit)

unread,
Sep 28, 2023, 5:25:55 AM9/28/23
to Max Ihlenfeldt, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, Scott Violet, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Max Ihlenfeldt, Scott Violet.

Patch set 13:Code-Review +1

View Change

1 comment:

  • File ui/ozone/platform/wayland/emulate/wayland_input_emulate.cc:

To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
Gerrit-Change-Number: 4738688
Gerrit-PatchSet: 13
Gerrit-Owner: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Comment-Date: Thu, 28 Sep 2023 09:25:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Scott Violet (Gerrit)

unread,
Sep 28, 2023, 3:40:35 PM9/28/23
to Max Ihlenfeldt, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, Maksim Sisov, Scott Violet, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Max Ihlenfeldt.

View Change

3 comments:

  • File chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:

    • Patch Set #13, Line 249: void ResizeUsingMouseEmulation(Browser* browser, gfx::Rect target_bounds) {

      To simplify the call sites how about providing a function SetBrowserBounds(). The implementation for linux is what you have here, but for all other platforms it sets the bounds directly. This hopefully keeps the complexity in the function, not at every call sites.

    • Patch Set #13, Line 249: gfx::Rect

      const&

  • File ui/base/test/ui_controls.h:

    • Patch Set #13, Line 187: void ForceUseScreenCoordinates(bool use);

      Would it be better to provide this via OzonePlatform::InitParams? Toggling it part way through a test seems rather risky, in so far as it could effect a bunch of other random code.

To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
Gerrit-Change-Number: 4738688
Gerrit-PatchSet: 13
Gerrit-Owner: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Comment-Date: Thu, 28 Sep 2023 19:40:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Max Ihlenfeldt (Gerrit)

unread,
Oct 2, 2023, 8:56:23 AM10/2/23
to ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention is currently required from: Max Ihlenfeldt.

Max Ihlenfeldt uploaded patch set #14 to this change.

View Change

TabDragging tests: Set browser bounds using mouse emulation

On Linux ozone/wayland we can't control the browser bounds, but many
TabDragging tests expect specific bounds and will fail if the actual
bounds are different.

This CL introduces a workaround that allows us to still set the browser
bounds on this platform. The idea is to use ui_controls to emulate mouse
events that will resize and move the browser to where we want (like a
regular user would do).

Bug: 1474921
Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
---
M chrome/browser/ui/views/tabs/tab_drag_controller.cc
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
M testing/buildbot/filters/ozone-linux.interactive_ui_tests_wayland.filter
M ui/base/test/ui_controls.h
M ui/ozone/platform/wayland/emulate/wayland_input_emulate.cc
M ui/ozone/platform/wayland/emulate/wayland_input_emulate.h
M ui/ozone/platform/wayland/test/wayland_ozone_ui_controls_test_helper.cc
M ui/ozone/platform/wayland/test/wayland_ozone_ui_controls_test_helper.h
M ui/ozone/public/ozone_ui_controls_test_helper.cc
M ui/ozone/public/ozone_ui_controls_test_helper.h
M ui/views/test/ui_controls_factory_desktop_aura_ozone.cc
11 files changed, 254 insertions(+), 44 deletions(-)

To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
Gerrit-Change-Number: 4738688
Gerrit-PatchSet: 14

Max Ihlenfeldt (Gerrit)

unread,
Oct 2, 2023, 8:56:59 AM10/2/23
to ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, Maksim Sisov, Scott Violet, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Scott Violet.

View Change

4 comments:

  • File chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:

    • To simplify the call sites how about providing a function SetBrowserBounds(). […]

      Doesn't the new version of `CreateAnotherBrowserAndResize()` do what you describe? This is the only place where `ResizeUsingMouseEmulation()` is called, and I don't think we can reduce its complexity further.

      We could add back the original `Resize()` method (with a `CHECK(test::CanUseSetBounds())`) and use that in `DetachToBrowserTabDragControllerTestWithTabbedSystemApp.DragAppToAppWindow`, and possibly in other future tests as well.

      (A variant of `ResizeUsingMouseEmulation()` that takes two `Browser*` parameters, like the original `Resize()`, currently wouldn't be useful, because `CreateAnotherBrowserAndResize()` has to resize the first browser before creating the second one; else the second browser might occlude the first browser's bottom right corner or tab strip grab handle space.)

    • Done

  • File ui/base/test/ui_controls.h:

    • Would it be better to provide this via OzonePlatform::InitParams? Toggling it part way through a tes […]

      It might indeed be somewhat risky, but I'm not sure it's possible to avoid it. Forcing the use of screen coordinates will break all emulated mouse positioning except for the one `SendMouseMoveSync()` call in `ResizeUsingMouseEmulation()`, because we don't actually have screen coordinates available on Linux ozone/wayland.

      For example, if we want to move the mouse to (100, 100) relative to a given browser window's origin, we pass the coordinates (100, 100) and the window they are relative to as parameters. Forcing the use of screen coordinates would mean that this is interpreted as (100, 100) relative to the screen origin, which almost certainly will be the wrong location.

      Maybe we can still minimize the risk of this, though. For example, changing `void ForceUseScreenCoordinates(bool use)` to `void ForceUseScreenCoordinatesOnce()` and making it affect only the next `ui_controls::SendMouseMove()` / `SendMouseMoveNotifyWhenDone()` call could help with avoiding it affecting unwanted code?

  • File ui/ozone/platform/wayland/emulate/wayland_input_emulate.cc:

    • Done

To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
Gerrit-Change-Number: 4738688
Gerrit-PatchSet: 14
Gerrit-Owner: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Oct 2023 12:56:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maksim Sisov <msi...@igalia.com>
Comment-In-Reply-To: Scott Violet <s...@chromium.org>

Scott Violet (Gerrit)

unread,
Oct 2, 2023, 2:26:48 PM10/2/23
to Max Ihlenfeldt, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, Maksim Sisov, Scott Violet, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Max Ihlenfeldt.

View Change

2 comments:

  • File chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:

    • Doesn't the new version of `CreateAnotherBrowserAndResize()` do what you describe? This is the only place where `ResizeUsingMouseEmulation()` is called, and I don't think we can reduce its complexity further.


    • We could add back the original `Resize()` method (with a `CHECK(test::CanUseSetBounds())`) and use that in `DetachToBrowserTabDragControllerTestWithTabbedSystemApp.DragAppToAppWindow`, and possibly in other future tests as well.

    • (A variant of `ResizeUsingMouseEmulation()` that takes two `Browser*` parameters, like the original `Resize()`, currently wouldn't be useful, because `CreateAnotherBrowserAndResize()` has to resize the first browser before creating the second one; else the second browser might occlude the first browser's bottom right corner or tab strip grab handle space.)

    • You are absolutely right! I misread the places that needed to call

  • File ui/base/test/ui_controls.h:

    • It might indeed be somewhat risky, but I'm not sure it's possible to avoid it. […]

      I like the Once() idea!

To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
Gerrit-Change-Number: 4738688
Gerrit-PatchSet: 14
Gerrit-Owner: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Comment-Date: Mon, 02 Oct 2023 18:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Max Ihlenfeldt <m...@igalia.com>
Comment-In-Reply-To: Scott Violet <s...@chromium.org>

Max Ihlenfeldt (Gerrit)

unread,
Oct 3, 2023, 6:08:15 AM10/3/23
to ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

Attention is currently required from: Max Ihlenfeldt.

Max Ihlenfeldt uploaded patch set #15 to this change.

View Change

TabDragging tests: Set browser bounds using mouse emulation

On Linux ozone/wayland we can't control the browser bounds, but many
TabDragging tests expect specific bounds and will fail if the actual
bounds are different.

This CL introduces a workaround that allows us to still set the browser
bounds on this platform. The idea is to use ui_controls to emulate mouse
events that will resize and move the browser to where we want (like a
regular user would do).

Bug: 1474921
Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
---
M chrome/browser/ui/views/tabs/tab_drag_controller.cc
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
M testing/buildbot/filters/ozone-linux.interactive_ui_tests_wayland.filter
M ui/base/test/ui_controls.h
M ui/ozone/platform/wayland/emulate/wayland_input_emulate.cc
M ui/ozone/platform/wayland/emulate/wayland_input_emulate.h
M ui/ozone/platform/wayland/test/wayland_ozone_ui_controls_test_helper.cc
M ui/ozone/platform/wayland/test/wayland_ozone_ui_controls_test_helper.h
M ui/ozone/public/ozone_ui_controls_test_helper.cc
M ui/ozone/public/ozone_ui_controls_test_helper.h
M ui/views/test/ui_controls_factory_desktop_aura_ozone.cc
11 files changed, 259 insertions(+), 43 deletions(-)

To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
Gerrit-Change-Number: 4738688
Gerrit-PatchSet: 15

Max Ihlenfeldt (Gerrit)

unread,
Oct 3, 2023, 8:31:41 AM10/3/23
to ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, Maksim Sisov, Scott Violet, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Scott Violet.

View Change

3 comments:

  • Patchset:

    • Patch Set #15:

      @Maksim: could you please take another look at the changes from PS 15, as they also touch ozone/wayland code?

  • File chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:

    • > Doesn't the new version of `CreateAnotherBrowserAndResize()` do what you describe? This is the onl […]

      Acknowledged

  • File ui/base/test/ui_controls.h:

    • I like the Once() idea!

      Done

To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
Gerrit-Change-Number: 4738688
Gerrit-PatchSet: 15
Gerrit-Owner: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Oct 2023 12:31:29 +0000

Maksim Sisov (Gerrit)

unread,
Oct 3, 2023, 9:47:47 AM10/3/23
to Max Ihlenfeldt, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, Scott Violet, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Max Ihlenfeldt, Scott Violet.

Patch set 15:Code-Review +1

View Change

2 comments:

To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
Gerrit-Change-Number: 4738688
Gerrit-PatchSet: 15
Gerrit-Owner: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Oct 2023 13:47:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Scott Violet (Gerrit)

unread,
Oct 3, 2023, 11:57:04 AM10/3/23
to Max Ihlenfeldt, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, Scott Violet, Maksim Sisov, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Max Ihlenfeldt.

Patch set 15:Code-Review +1

View Change

    To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
    Gerrit-Change-Number: 4738688
    Gerrit-PatchSet: 15
    Gerrit-Owner: Max Ihlenfeldt <m...@igalia.com>
    Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
    Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
    Gerrit-Reviewer: Scott Violet <s...@chromium.org>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-Attention: Max Ihlenfeldt <m...@igalia.com>
    Gerrit-Comment-Date: Tue, 03 Oct 2023 15:56:53 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    Max Ihlenfeldt (Gerrit)

    unread,
    Oct 6, 2023, 4:10:33 AM10/6/23
    to ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

    Attention is currently required from: Max Ihlenfeldt.

    Max Ihlenfeldt uploaded patch set #16 to this change.

    View Change

    TabDragging tests: Set browser bounds using mouse emulation

    On Linux ozone/wayland we can't control the browser bounds, but many
    TabDragging tests expect specific bounds and will fail if the actual
    bounds are different.

    This CL introduces a workaround that allows us to still set the browser
    bounds on this platform. The idea is to use ui_controls to emulate mouse
    events that will resize and move the browser to where we want (like a
    regular user would do).

    Bug: 1474921
    Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
    ---
    M chrome/browser/ui/views/tabs/tab_drag_controller.cc
    M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
    M testing/buildbot/filters/ozone-linux.interactive_ui_tests_wayland.filter
    M ui/base/test/ui_controls.h
    M ui/ozone/platform/wayland/emulate/wayland_input_emulate.cc
    M ui/ozone/platform/wayland/emulate/wayland_input_emulate.h
    M ui/ozone/platform/wayland/test/wayland_ozone_ui_controls_test_helper.cc
    M ui/ozone/platform/wayland/test/wayland_ozone_ui_controls_test_helper.h
    M ui/ozone/public/ozone_ui_controls_test_helper.cc
    M ui/ozone/public/ozone_ui_controls_test_helper.h
    M ui/views/test/ui_controls_factory_desktop_aura_ozone.cc
    11 files changed, 259 insertions(+), 43 deletions(-)

    To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: newpatchset
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
    Gerrit-Change-Number: 4738688
    Gerrit-PatchSet: 16

    Max Ihlenfeldt (Gerrit)

    unread,
    Oct 6, 2023, 4:11:15 AM10/6/23
    to ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, Scott Violet, Maksim Sisov, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng

    Patch set 16:Commit-Queue +2

    View Change

    2 comments:

    • Patchset:

    • File ui/ozone/platform/wayland/emulate/wayland_input_emulate.h:

      • Done

    To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
    Gerrit-Change-Number: 4738688
    Gerrit-PatchSet: 16
    Gerrit-Owner: Max Ihlenfeldt <m...@igalia.com>
    Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
    Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
    Gerrit-Reviewer: Scott Violet <s...@chromium.org>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Oct 2023 08:11:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Maksim Sisov <msi...@igalia.com>

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 6, 2023, 5:04:43 AM10/6/23
    to Max Ihlenfeldt, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, Scott Violet, Maksim Sisov, chromium...@chromium.org, Daniel Cheng

    Chromium LUCI CQ submitted this change.

    View Change



    15 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: ui/ozone/platform/wayland/emulate/wayland_input_emulate.h
    Insertions: 1, Deletions: 1.

    @@ -180,7 +180,7 @@

    base::RepeatingCallback<void(uint32_t)> request_processed_callback_;

    - // If true, the next `EmulatePointerMotion` call will always use global screen
    + // If true, the next `EmulatePointerMotion` call will use global screen
    // coordinates, i.e. send zcr_ui_controls_v1.mouse_move with the `surface`
    // parameter set to NULL.
    // Note: this does not affect whether `EmulatePointerMotion` uses the
    ```

    Approvals: Maksim Sisov: Looks good to me Max Ihlenfeldt: Commit Scott Violet: Looks good to me
    TabDragging tests: Set browser bounds using mouse emulation

    On Linux ozone/wayland we can't control the browser bounds, but many
    TabDragging tests expect specific bounds and will fail if the actual
    bounds are different.

    This CL introduces a workaround that allows us to still set the browser
    bounds on this platform. The idea is to use ui_controls to emulate mouse
    events that will resize and move the browser to where we want (like a
    regular user would do).

    Bug: 1474921
    Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4738688
    Reviewed-by: Maksim Sisov <msi...@igalia.com>
    Reviewed-by: Scott Violet <s...@chromium.org>
    Commit-Queue: Max Ihlenfeldt <m...@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#1206297}

    ---
    M chrome/browser/ui/views/tabs/tab_drag_controller.cc
    M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
    M testing/buildbot/filters/ozone-linux.interactive_ui_tests_wayland.filter
    M ui/base/test/ui_controls.h
    M ui/ozone/platform/wayland/emulate/wayland_input_emulate.cc
    M ui/ozone/platform/wayland/emulate/wayland_input_emulate.h
    M ui/ozone/platform/wayland/test/wayland_ozone_ui_controls_test_helper.cc
    M ui/ozone/platform/wayland/test/wayland_ozone_ui_controls_test_helper.h
    M ui/ozone/public/ozone_ui_controls_test_helper.cc
    M ui/ozone/public/ozone_ui_controls_test_helper.h
    M ui/views/test/ui_controls_factory_desktop_aura_ozone.cc
    11 files changed, 259 insertions(+), 43 deletions(-)


    To view, visit change 4738688. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1e8c154b3f6d078b77e9900f60e7001aa329436
    Gerrit-Change-Number: 4738688
    Gerrit-PatchSet: 17
    Gerrit-Owner: Max Ihlenfeldt <m...@igalia.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
    Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
    Gerrit-Reviewer: Scott Violet <s...@chromium.org>
    Reply all
    Reply to author
    Forward
    0 new messages