gpu: DumpWithoutCrashing for no context gl call [chromium/src : main]
0 views
Skip to first unread message
Bo Liu (Gerrit)
Jan 22, 2026, 10:14:45 AM (11 days ago) Jan 22
to Bo Liu, Geoff Lang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org
Attention needed from Geoff Lang
Bo Liu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Geoff Lang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Geoff Lang (Gerrit)
Jan 22, 2026, 10:16:42 AM (11 days ago) Jan 22
to Bo Liu, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org
Attention needed from Bo Liu
Geoff Lang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Geoff Lang
| Code-Review | +1 |
2 comments
Patchset-level comments
Attention is currently required from:
- Bo Liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bo Liu (Gerrit)
Jan 22, 2026, 10:27:23 AM (11 days ago) Jan 22
to Bo Liu, Geoff Lang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org
Attention needed from Geoff Lang
Bo Liu added 1 comment![]( "Open in Gerrit")
Commit Message
Geoff Lang . unresolved
Was this related to some bug?
Bo Liu
Most recent was crbug.com/468321139, but there have been a few others. Do you prefer to use the most recent one, or just leave it blank?
Related details
Attention is currently required from:
- Geoff Lang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Geoff Lang (Gerrit)
Jan 22, 2026, 10:28:24 AM (11 days ago) Jan 22
to Bo Liu, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org
Attention needed from Bo Liu
Geoff Lang added 1 comment![]( "Open in Gerrit")
Commit Message
Geoff Lang . unresolved
Bo LiuWas this related to some bug?
Most recent was crbug.com/468321139, but there have been a few others. Do you prefer to use the most recent one, or just leave it blank?
Attention is currently required from:
- Bo Liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bo Liu (Gerrit)
Jan 22, 2026, 10:29:44 AM (11 days ago) Jan 22
to Bo Liu, Geoff Lang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org
Bo Liu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Bo Liu
| Commit-Queue | +2 |
Bo LiuWas this related to some bug?
Geoff LangMost recent was crbug.com/468321139, but there have been a few others. Do you prefer to use the most recent one, or just leave it blank?
Any is fine, helps to link the fix back to something.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 22, 2026, 10:32:45 AM (11 days ago) Jan 22
to Bo Liu, Geoff Lang, Vasiliy Telezhnikov, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
gpu: DumpWithoutCrashing for no context gl call
NOTREACHED is now fatal and does not include the log message in official
builds. Turn it into a DumpWithoutCrashing and add the method name to a
crash key.
Note previous log messages are discarded in official builds, so it's not
duplicated here.
Bug: 468321139
Change-Id: Ic8db1e0e7132ee9196740ec6ba09a0b737c5595e
Reviewed-by: Geoff Lang <geof...@chromium.org>
Commit-Queue: Bo Liu <bo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1572997}
Files:
- M android_webview/common/crash_reporter/crash_keys.cc
- M ui/gl/generate_bindings.py
- M ui/gl/gl_bindings_autogen_egl.cc
- M ui/gl/gl_bindings_autogen_gl.cc
Change size: S
Delta: 4 files changed, 18 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Geoff Lang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages