gpu: DumpWithoutCrashing for no context gl call [chromium/src : main]

0 views
Skip to first unread message

Bo Liu (Gerrit)

unread,
Jan 22, 2026, 10:14:45 AM (11 days ago) Jan 22
to Bo Liu, Geoff Lang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org
Attention needed from Geoff Lang

Bo Liu added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Geoff Lang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic8db1e0e7132ee9196740ec6ba09a0b737c5595e
Gerrit-Change-Number: 7504936
Gerrit-PatchSet: 3
Gerrit-Owner: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
Gerrit-CC: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Geoff Lang <geof...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Jan 2026 15:14:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Geoff Lang (Gerrit)

unread,
Jan 22, 2026, 10:16:42 AM (11 days ago) Jan 22
to Bo Liu, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org
Attention needed from Bo Liu

Geoff Lang voted and added 2 comments

Votes added by Geoff Lang

Code-Review+1

2 comments

Patchset-level comments
Geoff Lang . resolved

LGTM

Commit Message
Line 15, Patchset 3 (Latest):
Geoff Lang . unresolved

Was this related to some bug?

Open in Gerrit

Related details

Attention is currently required from:
  • Bo Liu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic8db1e0e7132ee9196740ec6ba09a0b737c5595e
Gerrit-Change-Number: 7504936
Gerrit-PatchSet: 3
Gerrit-Owner: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
Gerrit-CC: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Bo Liu <bo...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Jan 2026 15:16:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Bo Liu (Gerrit)

unread,
Jan 22, 2026, 10:27:23 AM (11 days ago) Jan 22
to Bo Liu, Geoff Lang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org
Attention needed from Geoff Lang

Bo Liu added 1 comment

Commit Message
Geoff Lang . unresolved

Was this related to some bug?

Bo Liu

Most recent was crbug.com/468321139, but there have been a few others. Do you prefer to use the most recent one, or just leave it blank?

Open in Gerrit

Related details

Attention is currently required from:
  • Geoff Lang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic8db1e0e7132ee9196740ec6ba09a0b737c5595e
Gerrit-Change-Number: 7504936
Gerrit-PatchSet: 3
Gerrit-Owner: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
Gerrit-CC: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Geoff Lang <geof...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Jan 2026 15:27:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Geoff Lang <geof...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Geoff Lang (Gerrit)

unread,
Jan 22, 2026, 10:28:24 AM (11 days ago) Jan 22
to Bo Liu, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org
Attention needed from Bo Liu

Geoff Lang added 1 comment

Commit Message
Geoff Lang . unresolved

Was this related to some bug?

Bo Liu

Most recent was crbug.com/468321139, but there have been a few others. Do you prefer to use the most recent one, or just leave it blank?

Geoff Lang

Any is fine, helps to link the fix back to something.

Open in Gerrit

Related details

Attention is currently required from:
  • Bo Liu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic8db1e0e7132ee9196740ec6ba09a0b737c5595e
Gerrit-Change-Number: 7504936
Gerrit-PatchSet: 3
Gerrit-Owner: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
Gerrit-CC: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Bo Liu <bo...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Jan 2026 15:28:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Geoff Lang <geof...@chromium.org>
Comment-In-Reply-To: Bo Liu <bo...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Bo Liu (Gerrit)

unread,
Jan 22, 2026, 10:29:44 AM (11 days ago) Jan 22
to Bo Liu, Geoff Lang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org

Bo Liu voted and added 1 comment

Votes added by Bo Liu

Commit-Queue+2

1 comment

Commit Message
Line 15, Patchset 3:
Geoff Lang . resolved

Was this related to some bug?

Bo Liu

Most recent was crbug.com/468321139, but there have been a few others. Do you prefer to use the most recent one, or just leave it blank?

Geoff Lang

Any is fine, helps to link the fix back to something.

Bo Liu

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic8db1e0e7132ee9196740ec6ba09a0b737c5595e
    Gerrit-Change-Number: 7504936
    Gerrit-PatchSet: 4
    Gerrit-Owner: Bo Liu <bo...@chromium.org>
    Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
    Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
    Gerrit-CC: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Comment-Date: Thu, 22 Jan 2026 15:29:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 22, 2026, 10:32:45 AM (11 days ago) Jan 22
    to Bo Liu, Geoff Lang, Vasiliy Telezhnikov, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    3 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    gpu: DumpWithoutCrashing for no context gl call

    NOTREACHED is now fatal and does not include the log message in official
    builds. Turn it into a DumpWithoutCrashing and add the method name to a
    crash key.

    Note previous log messages are discarded in official builds, so it's not
    duplicated here.
    Bug: 468321139
    Change-Id: Ic8db1e0e7132ee9196740ec6ba09a0b737c5595e
    Reviewed-by: Geoff Lang <geof...@chromium.org>
    Commit-Queue: Bo Liu <bo...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1572997}
    Files:
    • M android_webview/common/crash_reporter/crash_keys.cc
    • M ui/gl/generate_bindings.py
    • M ui/gl/gl_bindings_autogen_egl.cc
    • M ui/gl/gl_bindings_autogen_gl.cc
    Change size: S
    Delta: 4 files changed, 18 insertions(+), 5 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Geoff Lang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic8db1e0e7132ee9196740ec6ba09a0b737c5595e
    Gerrit-Change-Number: 7504936
    Gerrit-PatchSet: 5
    Gerrit-Owner: Bo Liu <bo...@chromium.org>
    Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages