[M143] Revert "Fix touchpad scroll sensitivity on Wayland." [chromium/src : refs/branch-heads/7499]
0 views
Skip to first unread message
Chrome Cherry Picker (Gerrit)
Nov 24, 2025, 6:16:09 PM (6 days ago) Nov 24
to Jamie Walch, AyeAye, nickdiego+wa...@igalia.com, max+watc...@igalia.com, ozone-...@chromium.org
Chrome Cherry Picker voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Nov 24, 2025, 6:17:23 PM (6 days ago) Nov 24
to Chrome Cherry Picker, Jamie Walch, AyeAye, nickdiego+wa...@igalia.com, max+watc...@igalia.com, ozone-...@chromium.org
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 24, 2025, 8:03:02 PM (6 days ago) Nov 24
to Chrome Cherry Picker, Jamie Walch, Rubber Stamper, AyeAye, nickdiego+wa...@igalia.com, max+watc...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M143] Revert "Fix touchpad scroll sensitivity on Wayland."
Original change's description:
> Revert "Fix touchpad scroll sensitivity on Wayland."
>
> This reverts commit ded09f2a729ad7d92f404bd9f86fac819f178f8b.
>
> Reason for revert: Users found the slower scroll speed relative to other Wayland applications to be disruptive.
>
> Original change's description:
> > Fix touchpad scroll sensitivity on Wayland.
> >
> > Chrome's scroll sensitivity with a touchpad is much higher on Wayland
> > than on other OSes. Chrome isn't alone in this--Terminal and several
> > other applications also scroll much faster than I'd expect--but one
> > notable exception is the "Test settings" page of the touchpad
> > configuration UI, the scroll sensitivity of which feels comparable to
> > using a touchpad on other OSes.
> >
> > I believe that axis events coming via `OnAxis` should not be scaled at
> > all. That feels right when using a physical touchpad, but more
> > importantly, if `ei_device_scroll_delta` is used to inject scroll
> > events, the magnitude of those events is specified in pixels. The
> > comment in `OnAxis` (that this CL deletes) mentioned wheel ticks, but
> > this CL doesn't affect wheel ticks at all, since they are delivered via
> > `OnAxis120`, which takes precedence.
> >
> > My ultimate goal is to have CRD host use `ei_device_scroll_delta` so
> > that we can support smooth scrolling. It's not currently possible due
> > to https://gitlab.freedesktop.org/libinput/libei/-/issues/88, but this
> > CL is a prerequisite. In particular, if the `OnAxis120` implementation
> > is removed in addition to this CL, then I can get the scroll distances
> > to match on client and host when Chrome Wayland is used at both ends.
> > Without this CL, Chrome running on the host scrolls 144 times too far
> > due to scroll distances being multiplied by 12 by Chrome at both ends.
> >
> > Change-Id: Id576c3a10e3dc1847ab278502b31baf51592ce55
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004208
> > Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
> > Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
> > Auto-Submit: Jamie Walch <jamie...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1524565}
>
> Change-Id: I8245e2ee835991cdfe082a6d34cd00a25603d155
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7171891
> Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
> Commit-Queue: Jamie Walch <jamie...@chromium.org>
> Reviewed-by: Orko Garai <or...@igalia.com>
> Cr-Commit-Position: refs/heads/main@{#1547498}
(cherry picked from commit b77b5ec93f72fb36c5e4f01bd90b456e6a17b9bc)
Bug: 462497327
Change-Id: I8245e2ee835991cdfe082a6d34cd00a25603d155
Auto-Submit: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7499@{#2642}
Cr-Branched-From: b30439823e5177773584139e72e0593e36863899-refs/heads/main@{#1536371}
Files:
- M ui/ozone/platform/wayland/host/wayland_pointer.cc
- M ui/ozone/platform/wayland/host/wayland_pointer_unittest.cc
Change size: M
Delta: 2 files changed, 10 insertions(+), 40 deletions(-)
Branch: refs/branch-heads/7499
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages