Attention is currently required from: Mitsuru Oshima.
Eriko Kurimoto would like Mitsuru Oshima to review this change.
ozone/wayland: Allow all_bug_fixes_sent_callback non-null
This CL allows WaitForAllBugFixIds called twice since it is expected to
be called from TestGpuServiceHolder to override the bind interface.
This fixes the flaky crash on compositor_unittests and
TabCapturePerformanceTest.
Bug: 1482740
Change-Id: I32b9c0a56f9ffdd515d5c28106d49c5a43ffd588
---
M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc b/ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
index 6f42199..aba5cd4 100644
--- a/ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
+++ b/ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
@@ -154,8 +154,11 @@
return;
}
+ if (all_bug_fixes_sent_callback_) {
+ LOG(WARNING) << "all_bug_fixes_sent_callback_ is overriden. You should not "
+ << "see this message except for testing.";
+ }
// If bug_fix_ids is not yet ready, wait until OnAllBugFixesSent is notified.
- CHECK(all_bug_fixes_sent_callback_.is_null());
all_bug_fixes_sent_callback_ = std::move(callback);
}
To view, visit change 4881242. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Mitsuru Oshima.
To view, visit change 4881242. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Eriko Kurimoto.
2 comments:
Patchset:
will it be difficult to pass callback in test?
File ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc:
Patch Set #1, Line 159: << "see this message except for testing.";
is it difficult to fix test?
To view, visit change 4881242. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Eriko Kurimoto.
Eriko Kurimoto uploaded patch set #2 to this change.
ozone/wayland: Allow all_bug_fixes_sent_callback non-null
This CL allows WaitForAllBugFixIds called twice since it is expected to
be called from TestGpuServiceHolder to override the bind interface.
This fixes the flaky crash on compositor_unittests and
TabCapturePerformanceTest.
Bug: 1482740
Change-Id: I32b9c0a56f9ffdd515d5c28106d49c5a43ffd588
---
M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
1 file changed, 1 insertion(+), 0 deletions(-)
To view, visit change 4881242. To unsubscribe, or for help writing mail filters, visit settings.