ozone/wayland: Allow all_bug_fixes_sent_callback non-null [chromium/src : main]

0 views
Skip to first unread message

Eriko Kurimoto (Gerrit)

unread,
Sep 21, 2023, 6:10:55 AM9/21/23
to Mitsuru Oshima, ozone-...@chromium.org

Attention is currently required from: Mitsuru Oshima.

Eriko Kurimoto would like Mitsuru Oshima to review this change.

View Change

ozone/wayland: Allow all_bug_fixes_sent_callback non-null

This CL allows WaitForAllBugFixIds called twice since it is expected to
be called from TestGpuServiceHolder to override the bind interface.

This fixes the flaky crash on compositor_unittests and
TabCapturePerformanceTest.

Bug: 1482740
Change-Id: I32b9c0a56f9ffdd515d5c28106d49c5a43ffd588
---
M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc b/ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
index 6f42199..aba5cd4 100644
--- a/ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
+++ b/ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
@@ -154,8 +154,11 @@
return;
}

+ if (all_bug_fixes_sent_callback_) {
+ LOG(WARNING) << "all_bug_fixes_sent_callback_ is overriden. You should not "
+ << "see this message except for testing.";
+ }
// If bug_fix_ids is not yet ready, wait until OnAllBugFixesSent is notified.
- CHECK(all_bug_fixes_sent_callback_.is_null());
all_bug_fixes_sent_callback_ = std::move(callback);
}


To view, visit change 4881242. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I32b9c0a56f9ffdd515d5c28106d49c5a43ffd588
Gerrit-Change-Number: 4881242
Gerrit-PatchSet: 1
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>

Eriko Kurimoto (Gerrit)

unread,
Sep 21, 2023, 6:11:02 AM9/21/23
to ozone-...@chromium.org, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Mitsuru Oshima.

View Change

1 comment:

To view, visit change 4881242. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I32b9c0a56f9ffdd515d5c28106d49c5a43ffd588
Gerrit-Change-Number: 4881242
Gerrit-PatchSet: 1
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Thu, 21 Sep 2023 10:10:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Mitsuru Oshima (Gerrit)

unread,
Sep 22, 2023, 2:04:07 AM9/22/23
to Eriko Kurimoto, ozone-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Eriko Kurimoto.

View Change

2 comments:

  • Patchset:

  • File ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc:

To view, visit change 4881242. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I32b9c0a56f9ffdd515d5c28106d49c5a43ffd588
Gerrit-Change-Number: 4881242
Gerrit-PatchSet: 1
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Comment-Date: Fri, 22 Sep 2023 06:03:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Eriko Kurimoto (Gerrit)

unread,
Sep 26, 2023, 10:02:52 AM9/26/23
to ozone-...@chromium.org

Attention is currently required from: Eriko Kurimoto.

Eriko Kurimoto uploaded patch set #2 to this change.

View Change

ozone/wayland: Allow all_bug_fixes_sent_callback non-null

This CL allows WaitForAllBugFixIds called twice since it is expected to
be called from TestGpuServiceHolder to override the bind interface.

This fixes the flaky crash on compositor_unittests and
TabCapturePerformanceTest.

Bug: 1482740
Change-Id: I32b9c0a56f9ffdd515d5c28106d49c5a43ffd588
---
M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.cc
1 file changed, 1 insertion(+), 0 deletions(-)

To view, visit change 4881242. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I32b9c0a56f9ffdd515d5c28106d49c5a43ffd588
Gerrit-Change-Number: 4881242
Gerrit-PatchSet: 2
Reply all
Reply to author
Forward
0 new messages