[gfx] Harden a plane count check in ui::gbm_wrapper::Device::CreateBufferFromHandle [chromium/src : main]

0 views
Skip to first unread message

Yuki Shiino (Gerrit)

unread,
Mar 27, 2026, 1:57:16 AM (7 days ago) Mar 27
to Yuki Shiino, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell

Yuki Shiino voted and added 1 comment

Votes added by Yuki Shiino

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Yuki Shiino . resolved

Would you review this patch?

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If9bec38baf397419cd5b57e4d8ea293ec9d425e4
Gerrit-Change-Number: 7707158
Gerrit-PatchSet: 1
Gerrit-Owner: Yuki Shiino <yukis...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Fri, 27 Mar 2026 05:56:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Mar 27, 2026, 4:10:18 AM (6 days ago) Mar 27
to Yuki Shiino, Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Vasiliy Telezhnikov and Yuki Shiino

Colin Blundell added 2 comments

Patchset-level comments
Colin Blundell . resolved

Thanks! +Vasiliy for expertise

File ui/gfx/linux/gbm_wrapper.cc
Line 442, Patchset 1 (Latest): CHECK_LE(handle.planes.size(), 3u);
Colin Blundell . unresolved

Vasiliy: Should this instead return nullptr if unexpected # of planes, like the cases above?

Open in Gerrit

Related details

Attention is currently required from:
  • Vasiliy Telezhnikov
  • Yuki Shiino
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If9bec38baf397419cd5b57e4d8ea293ec9d425e4
    Gerrit-Change-Number: 7707158
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yuki Shiino <yukis...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
    Gerrit-Attention: Yuki Shiino <yukis...@chromium.org>
    Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Comment-Date: Fri, 27 Mar 2026 08:10:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vasiliy Telezhnikov (Gerrit)

    unread,
    Mar 27, 2026, 9:05:21 AM (6 days ago) Mar 27
    to Yuki Shiino, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
    Attention needed from Yuki Shiino

    Vasiliy Telezhnikov added 1 comment

    File ui/gfx/linux/gbm_wrapper.cc
    Line 442, Patchset 1 (Latest): CHECK_LE(handle.planes.size(), 3u);
    Colin Blundell . unresolved

    Vasiliy: Should this instead return nullptr if unexpected # of planes, like the cases above?

    Vasiliy Telezhnikov

    Returning nullptr sounds good to me.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yuki Shiino
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If9bec38baf397419cd5b57e4d8ea293ec9d425e4
    Gerrit-Change-Number: 7707158
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yuki Shiino <yukis...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
    Gerrit-Attention: Yuki Shiino <yukis...@chromium.org>
    Gerrit-Comment-Date: Fri, 27 Mar 2026 13:05:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Colin Blundell <blun...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yuki Shiino (Gerrit)

    unread,
    Mar 30, 2026, 12:55:36 AM (4 days ago) Mar 30
    to Yuki Shiino, Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
    Attention needed from Colin Blundell and Vasiliy Telezhnikov

    Yuki Shiino voted and added 2 comments

    Votes added by Yuki Shiino

    Auto-Submit+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Yuki Shiino . resolved

    Would you take another look?

    File ui/gfx/linux/gbm_wrapper.cc
    Line 442, Patchset 1: CHECK_LE(handle.planes.size(), 3u);
    Colin Blundell . resolved

    Vasiliy: Should this instead return nullptr if unexpected # of planes, like the cases above?

    Vasiliy Telezhnikov

    Returning nullptr sounds good to me.

    Yuki Shiino

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Colin Blundell
    • Vasiliy Telezhnikov
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If9bec38baf397419cd5b57e4d8ea293ec9d425e4
      Gerrit-Change-Number: 7707158
      Gerrit-PatchSet: 4
      Gerrit-Owner: Yuki Shiino <yukis...@chromium.org>
      Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
      Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
      Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
      Gerrit-Attention: Colin Blundell <blun...@chromium.org>
      Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
      Gerrit-Comment-Date: Mon, 30 Mar 2026 04:55:07 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Colin Blundell <blun...@chromium.org>
      Comment-In-Reply-To: Vasiliy Telezhnikov <vas...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Colin Blundell (Gerrit)

      unread,
      Mar 30, 2026, 3:11:10 AM (4 days ago) Mar 30
      to Yuki Shiino, Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
      Attention needed from Vasiliy Telezhnikov and Yuki Shiino

      Colin Blundell voted and added 1 comment

      Votes added by Colin Blundell

      Code-Review+1
      Commit-Queue+2

      1 comment

      Patchset-level comments
      Colin Blundell . resolved

      Thanks!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Vasiliy Telezhnikov
      • Yuki Shiino
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If9bec38baf397419cd5b57e4d8ea293ec9d425e4
      Gerrit-Change-Number: 7707158
      Gerrit-PatchSet: 4
      Gerrit-Owner: Yuki Shiino <yukis...@chromium.org>
      Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
      Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
      Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
      Gerrit-Attention: Yuki Shiino <yukis...@chromium.org>
      Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
      Gerrit-Comment-Date: Mon, 30 Mar 2026 07:10:58 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Mar 30, 2026, 3:15:00 AM (4 days ago) Mar 30
      to Yuki Shiino, Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [gfx] Harden a plane count check in ui::gbm_wrapper::Device::CreateBufferFromHandle

      Turns a DCHECK_LE to a runtime check and early exit.
      Bug: 496387244
      Change-Id: If9bec38baf397419cd5b57e4d8ea293ec9d425e4
      Auto-Submit: Yuki Shiino <yukis...@chromium.org>
      Reviewed-by: Colin Blundell <blun...@chromium.org>
      Commit-Queue: Colin Blundell <blun...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1606912}
      Files:
      • M ui/gfx/linux/gbm_wrapper.cc
      Change size: XS
      Delta: 1 file changed, 5 insertions(+), 1 deletion(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Colin Blundell
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If9bec38baf397419cd5b57e4d8ea293ec9d425e4
      Gerrit-Change-Number: 7707158
      Gerrit-PatchSet: 5
      Gerrit-Owner: Yuki Shiino <yukis...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
      Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
      Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages