Revert "[//ui] Remove BufferFormat from ClientNativePixmapDmabuf interface" [chromium/src : main]

0 views
Skip to first unread message

Gabrielle Lau (Gerrit)

unread,
Jan 8, 2026, 6:55:21 AM (3 days ago) Jan 8
to Colin Blundell, AyeAye, Saifuddin Hitawala, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com
Attention needed from Colin Blundell and Saifuddin Hitawala

Gabrielle Lau voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Saifuddin Hitawala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I02a8f5e5377b39afb058974ad42e74a6fb01df49
Gerrit-Change-Number: 7414803
Gerrit-PatchSet: 1
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Gabrielle Lau <gabrie...@google.com>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 11:55:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Jan 8, 2026, 6:55:54 AM (3 days ago) Jan 8
to Colin Blundell, Gabrielle Lau, AyeAye, Saifuddin Hitawala, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com
Attention needed from Saifuddin Hitawala

Colin Blundell voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Saifuddin Hitawala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I02a8f5e5377b39afb058974ad42e74a6fb01df49
Gerrit-Change-Number: 7414803
Gerrit-PatchSet: 1
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Gabrielle Lau <gabrie...@google.com>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 11:55:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 8, 2026, 6:57:42 AM (3 days ago) Jan 8
to Colin Blundell, Gabrielle Lau, AyeAye, Saifuddin Hitawala, chromium...@chromium.org, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
Revert "[//ui] Remove BufferFormat from ClientNativePixmapDmabuf interface"

This reverts commit f661dadf88a076806d15fa2f2a28fa7a2b9c100a.

Reason for revert: CL chain broke compile on bot not covered by CQ

Original change's description:
> [//ui] Remove BufferFormat from ClientNativePixmapDmabuf interface
>
> Followup will remove it from the implementation.
>
> Bug: 356649879
> Change-Id: Icb18e2efc724e9b3dfce8bf9e2c98682fc561257
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7404141
> Reviewed-by: Saifuddin Hitawala <hita...@chromium.org>
> Commit-Queue: Colin Blundell <blun...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1566190}
Bug: 356649879
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I02a8f5e5377b39afb058974ad42e74a6fb01df49
Reviewed-by: Gabrielle Lau <gabrie...@google.com>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566206}
Files:
  • M ui/gfx/linux/client_native_pixmap_dmabuf.cc
  • M ui/gfx/linux/client_native_pixmap_dmabuf.h
  • M ui/ozone/platform/drm/ozone_platform_drm.cc
  • M ui/ozone/platform/wayland/ozone_platform_wayland.cc
Change size: S
Delta: 4 files changed, 6 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Gabrielle Lau
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I02a8f5e5377b39afb058974ad42e74a6fb01df49
Gerrit-Change-Number: 7414803
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages