Refactor shared memory switch handling. [chromium/src : main]
0 views
Skip to first unread message
gwsq (Gerrit)
Feb 12, 2026, 2:29:52 PM (8 days ago) Feb 12
to Alexei Svitkine, Chromium IPC Reviews, Dominic Farolino, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Dominic Farolino
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: d...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): d...@chromium.org
Reviewer source(s):
d...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Dominic Farolino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexei Svitkine (Gerrit)
Feb 12, 2026, 3:04:01 PM (8 days ago) Feb 12
to Chromium IPC Reviews, Dominic Farolino, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Dominic Farolino
Alexei Svitkine added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 31 (Latest):
Alexei Svitkine . resolved
Sorry, I still have some red bots, but they are some minor things due to IWYU that I'll address tomorrow, but I don't think this should affect the core change.
Alexei Svitkine (Gerrit)
Feb 13, 2026, 11:19:48 AM (7 days ago) Feb 13
to Chromium IPC Reviews, Dominic Farolino, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Dominic Farolino
Alexei Svitkine voted![]( "Open in Gerrit")
| Commit-Queue | +1 |
| Mega-CQ | +1 |
Related details
Attention is currently required from:
- Dominic Farolino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexei Svitkine (Gerrit)
Feb 13, 2026, 11:29:12 AM (7 days ago) Feb 13
to Chromium IPC Reviews, Dominic Farolino, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Dominic Farolino
Alexei Svitkine voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dominic Farolino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexei Svitkine (Gerrit)
Feb 13, 2026, 11:34:38 AM (7 days ago) Feb 13
to Roger McFarlane, Chromium IPC Reviews, Dominic Farolino, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Dominic Farolino and Roger McFarlane
Alexei Svitkine voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dominic Farolino
- Roger McFarlane
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexei Svitkine (Gerrit)
Feb 13, 2026, 11:42:18 AM (7 days ago) Feb 13
to Arthur Sonzogni, Roger McFarlane, Chromium IPC Reviews, Dominic Farolino, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Arthur Sonzogni, Dominic Farolino and Roger McFarlane
Alexei Svitkine added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 36 (Latest):
Alexei Svitkine . resolved
+arthursonzogni to cover more files
Related details
Attention is currently required from:
- Arthur Sonzogni
- Dominic Farolino
- Roger McFarlane
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexei Svitkine (Gerrit)
Feb 13, 2026, 1:14:26 PM (7 days ago) Feb 13
to Kyle Horimoto, Colin Blundell, Etienne Pierre-Doray, Arthur Sonzogni, Roger McFarlane, Chromium IPC Reviews, Dominic Farolino, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, Dominic Farolino, Etienne Pierre-Doray, Kyle Horimoto and Roger McFarlane
Alexei Svitkine voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexei Svitkine
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 37 (Latest):
Alexei Svitkine . resolved
+khorimoto for chromeos/
+blundell for chrome/ and ui/ and ash/
+etiennep for services/tracing/
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- Dominic Farolino
- Etienne Pierre-Doray
- Kyle Horimoto
- Roger McFarlane
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexei Svitkine (Gerrit)
Feb 13, 2026, 1:15:40 PM (7 days ago) Feb 13
to Dominic Farolino, Kyle Horimoto, Colin Blundell, Etienne Pierre-Doray, Arthur Sonzogni, Roger McFarlane, Chromium IPC Reviews, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell, Dominic Farolino, Etienne Pierre-Doray, Kyle Horimoto and Roger McFarlane
Alexei Svitkine added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Alexei Svitkine . resolved
Moving dom@ to cc since arthursonzogni@ owns a superset of files
Etienne Pierre-Doray (Gerrit)
Feb 13, 2026, 1:19:11 PM (7 days ago) Feb 13
to Alexei Svitkine, Dominic Farolino, Kyle Horimoto, Colin Blundell, Arthur Sonzogni, Roger McFarlane, Chromium IPC Reviews, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Alexei Svitkine, Arthur Sonzogni, Colin Blundell, Dominic Farolino, Kyle Horimoto and Roger McFarlane
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Etienne Pierre-Doray . resolved
services/tracing LGTM, thanks for the improvement!
Related details
Attention is currently required from:
- Alexei Svitkine
- Arthur Sonzogni
- Colin Blundell
- Dominic Farolino
- Kyle Horimoto
- Roger McFarlane
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Feb 16, 2026, 3:12:51 AM (4 days ago) Feb 16
to Alexei Svitkine, Colin Blundell, Etienne Pierre-Doray, Dominic Farolino, Kyle Horimoto, Arthur Sonzogni, Roger McFarlane, Chromium IPC Reviews, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Alexei Svitkine, Arthur Sonzogni, Dominic Farolino, Kyle Horimoto and Roger McFarlane
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Alexei Svitkine
- Arthur Sonzogni
- Dominic Farolino
- Kyle Horimoto
- Roger McFarlane
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Feb 16, 2026, 8:20:01 AM (4 days ago) Feb 16
to Alexei Svitkine, Colin Blundell, Etienne Pierre-Doray, Dominic Farolino, Kyle Horimoto, Roger McFarlane, Chromium IPC Reviews, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Alexei Svitkine, Colin Blundell, Dominic Farolino, Kyle Horimoto and Roger McFarlane
Arthur Sonzogni voted and added 4 comments![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Code-Review | +1 |
4 comments
Patchset-level comments
Arthur Sonzogni . resolved
Thanks!
This is a nice refactoring.
LGTM % minor suggestions.
File base/memory/shared_memory_switch.h
Line 111, Patchset 38 (Latest):
std::string_view switch_name;Arthur Sonzogni . unresolved
Opinion about `std::string` vs `std::string_view`?
I see you replaced the function argument by this class to store the argument, but maybe you should have used `std::string`, because there is a risk for the string_view to be dangling?
I understand this is only going to store a view to static string in theory. Maybe this class should be `STACK_ALLOCATED()`, to enforce it is only going to be used to pass as an argument, but never stored?
Using `std::string`, `std::string_view`, `STACK_ALLOCATED()` decision is up to you.
File content/browser/child_process_launcher_helper.cc
Line 70, Patchset 38 (Latest):
base::shared_memory::SharedMemorySwitch& shared_memory_switch,Arthur Sonzogni . unresolved
`shared_memory_switch` is modified. Maybe this should be a pointer instead of a reference?
According to the Google C++ Style Guide, input/output parameters should usually be pointers to indicate that the object may be modified.
(Unsure how well this is enforced in chrome)
File services/tracing/public/cpp/trace_startup_shared_memory_unittest.cc
Line 9, Patchset 38 (Latest):
#include "base/memory/raw_ref.h"Arthur Sonzogni . unresolved
Is this used?
Related details
Attention is currently required from:
- Alexei Svitkine
- Colin Blundell
- Dominic Farolino
- Kyle Horimoto
- Roger McFarlane
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Roger McFarlane (Gerrit)
Feb 17, 2026, 9:21:59 AM (3 days ago) Feb 17
to Alexei Svitkine, Arthur Sonzogni, Colin Blundell, Etienne Pierre-Doray, Dominic Farolino, Kyle Horimoto, Chromium IPC Reviews, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Alexei Svitkine, Colin Blundell, Dominic Farolino and Kyle Horimoto
Roger McFarlane voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alexei Svitkine
- Colin Blundell
- Dominic Farolino
- Kyle Horimoto
Alexei Svitkine (Gerrit)
Feb 17, 2026, 9:45:15 AM (3 days ago) Feb 17
to Roger McFarlane, Arthur Sonzogni, Colin Blundell, Etienne Pierre-Doray, Dominic Farolino, Kyle Horimoto, Chromium IPC Reviews, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Colin Blundell, Dominic Farolino and Kyle Horimoto
Alexei Svitkine voted and added 4 comments![]( "Open in Gerrit")
Votes added by Alexei Svitkine
| Auto-Submit | +1 |
4 comments
Patchset-level comments
File-level comment, Patchset 37:
Alexei Svitkine . resolved
-etieenep since Colin is an owner for services/ already
File base/memory/shared_memory_switch.h
Opinion about `std::string` vs `std::string_view`?
I see you replaced the function argument by this class to store the argument, but maybe you should have used `std::string`, because there is a risk for the string_view to be dangling?
I understand this is only going to store a view to static string in theory. Maybe this class should be `STACK_ALLOCATED()`, to enforce it is only going to be used to pass as an argument, but never stored?
Using `std::string`, `std::string_view`, `STACK_ALLOCATED()` decision is up to you.
Alexei Svitkine
Went with STACK_ALLOCATED() plus a comment, thanks!
File content/browser/child_process_launcher_helper.cc
Line 70, Patchset 38:
base::shared_memory::SharedMemorySwitch& shared_memory_switch,Arthur Sonzogni . resolved
`shared_memory_switch` is modified. Maybe this should be a pointer instead of a reference?
According to the Google C++ Style Guide, input/output parameters should usually be pointers to indicate that the object may be modified.
(Unsure how well this is enforced in chrome)
Alexei Svitkine
The guidance has actually changed and non-null params are preferred to be passed by ref.
https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs
"non-optional output and input/output parameters should usually be references (which cannot be null)."
Also some internal links:
go/c-readability-advice#prefer-references
go/cstyle#Inputs_and_Outputs
In terms of Chromium, there's definitely a mix and I think pointer params are still more common, but for new code I've been following the new guidance.
File services/tracing/public/cpp/trace_startup_shared_memory_unittest.cc
Line 9, Patchset 38:
#include "base/memory/raw_ref.h"Arthur Sonzogni . resolved
Alexei SvitkineIs this used?
Removed, thanks!
Related details
Attention is currently required from:
- Colin Blundell
- Dominic Farolino
- Kyle Horimoto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kyle Horimoto (Gerrit)
Feb 17, 2026, 11:31:00 AM (3 days ago) Feb 17
to Alexei Svitkine, Kyle Horimoto, Roger McFarlane, Arthur Sonzogni, Colin Blundell, Etienne Pierre-Doray, Dominic Farolino, Chromium IPC Reviews, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Alexei Svitkine, Colin Blundell and Dominic Farolino
Kyle Horimoto voted![]( "Open in Gerrit")
Attention is currently required from:
- Alexei Svitkine
- Colin Blundell
- Dominic Farolino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexei Svitkine (Gerrit)
Feb 17, 2026, 11:32:24 AM (3 days ago) Feb 17
to Kyle Horimoto, Roger McFarlane, Arthur Sonzogni, Colin Blundell, Etienne Pierre-Doray, Dominic Farolino, Chromium IPC Reviews, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Attention needed from Colin Blundell and Dominic Farolino
Alexei Svitkine voted![]( "Open in Gerrit")
Attention is currently required from:
- Colin Blundell
- Dominic Farolino
Chromium LUCI CQ (Gerrit)
Feb 17, 2026, 11:34:27 AM (3 days ago) Feb 17
to Alexei Svitkine, Kyle Horimoto, Roger McFarlane, Arthur Sonzogni, Colin Blundell, Etienne Pierre-Doray, Dominic Farolino, Chromium IPC Reviews, Enterprise Policy Reviews, AyeAye, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Refactor shared memory switch handling.
This change introduces a `base::shared_memory::SharedMemorySwitch`
struct to encapsulate the platform-specific details required to pass
shared memory handles to child processes.
The `AddToLaunchParameters` functions are now methods of this struct,
simplifying the interface by removing platform-specific arguments from
the function signatures. Call sites are updated to create and use a
`SharedMemorySwitch` object.
On POSIX platforms, the `out_descriptor_to_share` is now a member of
`SharedMemorySwitch`, and a helper function
`TransferSharedMemorySwitchDescriptor` is added to manage the transfer
of the descriptor to `FileMappedForLaunch`.
This refactoring reduces code duplication and makes the shared memory
passing mechanism more consistent across different platforms.
Also includes some IWYU fixes resulting from removing some header
imports.
Bug: 389713696
Change-Id: I1c06a46c8ef9acaeacae4437864bdcb3568950da
Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
Reviewed-by: Roger McFarlane <rog...@chromium.org>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Reviewed-by: Kyle Horimoto <khor...@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Commit-Queue: Alexei Svitkine <asvi...@chromium.org>
Auto-Submit: Alexei Svitkine <asvi...@chromium.org>
Commit-Queue: Kyle Horimoto <khor...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1585787}
Files:
- M ash/capture_mode/capture_mode_test_util.cc
- M base/memory/shared_memory_switch.cc
- M base/memory/shared_memory_switch.h
- M base/memory/shared_memory_switch_unittest.cc
- M base/metrics/field_trial.cc
- M base/metrics/field_trial.h
- M base/metrics/field_trial_unittest.cc
- M base/metrics/histogram_shared_memory.cc
- M base/metrics/histogram_shared_memory.h
- M base/metrics/histogram_shared_memory_unittest.cc
- M chrome/browser/ash/app_list/search/system_info/system_info_card_provider_unittest.cc
- M chrome/browser/ash/policy/skyvault/local_files_migration_manager_unittest.cc
- M chrome/browser/extensions/extension_keybinding_browsertest.cc
- M chrome/browser/ui/webui/ash/settings/pages/storage/device_storage_handler_unittest.cc
- M chrome/browser/web_applications/os_integration/mac/web_app_shortcut_creator.mm
- M chromeos/ash/components/dbus/fwupd/fwupd_client_unittest.cc
- M chromeos/ash/components/nearby/common/connections_manager/nearby_connections_manager_impl_unittest.cc
- M components/variations/active_field_trials.cc
- M components/variations/active_field_trials.h
- M content/browser/child_process_launcher_helper.cc
- M services/tracing/public/cpp/trace_startup.cc
- M services/tracing/public/cpp/trace_startup.h
- M services/tracing/public/cpp/trace_startup_shared_memory_unittest.cc
- M ui/ozone/platform/wayland/host/wayland_surface_unittest.cc
- M ui/ozone/platform/wayland/host/wayland_syncobj_timeline_unittest.cc
Change size: L
Delta: 25 files changed, 263 insertions(+), 573 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kyle Horimoto, +1 by Colin Blundell, +1 by Roger McFarlane, +1 by Arthur Sonzogni, +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexei Svitkine (Gerrit)
Feb 17, 2026, 5:29:05 PM (2 days ago) Feb 17
to Chromium LUCI CQ, Kyle Horimoto, Roger McFarlane, Arthur Sonzogni, Colin Blundell, Etienne Pierre-Doray, Dominic Farolino, Chromium IPC Reviews, Enterprise Policy Reviews, AyeAye, jackshira+w...@google.com, ajayramamurth...@google.com, xlythe+wa...@google.com, jimmyxgong+f...@chromium.org, michaelcheco+...@google.com, hais+wat...@google.com, suetfei+wa...@google.com, crisrael+w...@google.com, oshima...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, dclasson+w...@google.com, pushi+wat...@google.com, hansenmichael...@google.com, max+watc...@igalia.com, chromium-a...@chromium.org, nickdiego+wa...@igalia.com, extension...@chromium.org, ozone-...@chromium.org, cros-setti...@google.com, croissant-...@chromium.org, rrsilva+wat...@google.com, zelin+watch-we...@chromium.org, loyso...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org, philli...@chromium.org, mek+w...@chromium.org, dibyapal+wa...@chromium.org, aixba+wat...@chromium.org, mac-r...@chromium.org, gavinp...@chromium.org, security-...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, tracing...@chromium.org, asvitki...@chromium.org
Alexei Svitkine has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages