media/gpu/v4l2/test: Replace native references with raw_ref<T> [chromium/src : main]

64 views
Skip to first unread message

Chen-Yu Tsai (Gerrit)

unread,
Jul 24, 2023, 5:05:24 AM7/24/23
to Miguel Casas-Sanchez, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ozone-...@chromium.org, poscia...@chromium.org, Bijan Choobineh‎, Steve Cho

Attention is currently required from: Miguel Casas-Sanchez.

Chen-Yu Tsai would like Miguel Casas-Sanchez to review this change.

View Change

media/gpu/v4l2/test: Replace native references with raw_ref<T>

Required by Chromium code style checks:

error: [chromium-rawref] Use raw_ref<T> instead of a native reference.

Bug: b:258331312, b:291169645
Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
---
M media/gpu/v4l2/test/h264_decoder.cc
M media/gpu/v4l2/test/h264_decoder.h
M media/gpu/v4l2/test/h265_decoder.cc
M media/gpu/v4l2/test/h265_decoder.h
4 files changed, 6 insertions(+), 4 deletions(-)


To view, visit change 4710351. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
Gerrit-Change-Number: 4710351
Gerrit-PatchSet: 1
Gerrit-Owner: Chen-Yu Tsai <we...@chromium.org>
Gerrit-Reviewer: Chen-Yu Tsai <we...@chromium.org>
Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
Gerrit-CC: Bijan Choobineh‎ <bchoo...@chromium.org>
Gerrit-CC: Steve Cho <stev...@chromium.org>
Gerrit-Attention: Miguel Casas-Sanchez <mca...@chromium.org>

Chen-Yu Tsai (Gerrit)

unread,
Jul 24, 2023, 6:28:57 AM7/24/23
to chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ozone-...@chromium.org, poscia...@chromium.org, Miguel Casas-Sanchez, Steve Cho, Bijan Choobineh‎, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Miguel Casas-Sanchez.

Patch set 1:Commit-Queue +1

View Change

    To view, visit change 4710351. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
    Gerrit-Change-Number: 4710351
    Gerrit-PatchSet: 1
    Gerrit-Owner: Chen-Yu Tsai <we...@chromium.org>
    Gerrit-Reviewer: Chen-Yu Tsai <we...@chromium.org>
    Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
    Gerrit-CC: Bijan Choobineh‎ <bchoo...@chromium.org>
    Gerrit-CC: Steve Cho <stev...@chromium.org>
    Gerrit-Attention: Miguel Casas-Sanchez <mca...@chromium.org>
    Gerrit-Comment-Date: Mon, 24 Jul 2023 10:28:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    Miguel Casas-Sanchez (Gerrit)

    unread,
    Jul 24, 2023, 1:52:08 PM7/24/23
    to Bijan Choobineh‎, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ozone-...@chromium.org, poscia...@chromium.org, Chen-Yu Tsai

    Attention is currently required from: Bijan Choobineh‎, Chen-Yu Tsai.

    Miguel Casas-Sanchez would like Bijan Choobineh‎ to review this change authored by Chen-Yu Tsai.

    View Change

    media/gpu/v4l2/test: Replace native references with raw_ref<T>

    Required by Chromium code style checks:

    error: [chromium-rawref] Use raw_ref<T> instead of a native reference.

    Bug: b:258331312, b:291169645
    Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
    ---
    M media/gpu/v4l2/test/h264_decoder.cc
    M media/gpu/v4l2/test/h264_decoder.h
    M media/gpu/v4l2/test/h265_decoder.cc
    M media/gpu/v4l2/test/h265_decoder.h
    4 files changed, 6 insertions(+), 4 deletions(-)


    To view, visit change 4710351. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: newchange
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
    Gerrit-Change-Number: 4710351
    Gerrit-PatchSet: 1
    Gerrit-Owner: Chen-Yu Tsai <we...@chromium.org>
    Gerrit-Reviewer: Bijan Choobineh‎ <bchoo...@chromium.org>
    Gerrit-Reviewer: Chen-Yu Tsai <we...@chromium.org>
    Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
    Gerrit-CC: Steve Cho <stev...@chromium.org>
    Gerrit-Attention: Bijan Choobineh‎ <bchoo...@chromium.org>
    Gerrit-Attention: Chen-Yu Tsai <we...@chromium.org>

    Miguel Casas-Sanchez (Gerrit)

    unread,
    Jul 24, 2023, 1:52:12 PM7/24/23
    to Chen-Yu Tsai, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ozone-...@chromium.org, poscia...@chromium.org, Bijan Choobineh‎, Steve Cho, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Bijan Choobineh‎, Chen-Yu Tsai.

    Patch set 1:Code-Review +1

    View Change

    1 comment:

    To view, visit change 4710351. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
    Gerrit-Change-Number: 4710351
    Gerrit-PatchSet: 1
    Gerrit-Owner: Chen-Yu Tsai <we...@chromium.org>
    Gerrit-Reviewer: Bijan Choobineh‎ <bchoo...@chromium.org>
    Gerrit-Reviewer: Chen-Yu Tsai <we...@chromium.org>
    Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
    Gerrit-CC: Steve Cho <stev...@chromium.org>
    Gerrit-Attention: Bijan Choobineh‎ <bchoo...@chromium.org>
    Gerrit-Attention: Chen-Yu Tsai <we...@chromium.org>
    Gerrit-Comment-Date: Mon, 24 Jul 2023 17:52:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes

    Chen-Yu Tsai (Gerrit)

    unread,
    Jul 25, 2023, 5:58:22 AM7/25/23
    to chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ozone-...@chromium.org, poscia...@chromium.org, Bijan Choobineh‎, Miguel Casas-Sanchez, Steve Cho, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Bijan Choobineh‎.

    Patch set 1:Commit-Queue +1

    View Change

      To view, visit change 4710351. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
      Gerrit-Change-Number: 4710351
      Gerrit-PatchSet: 1
      Gerrit-Owner: Chen-Yu Tsai <we...@chromium.org>
      Gerrit-Reviewer: Bijan Choobineh‎ <bchoo...@chromium.org>
      Gerrit-Reviewer: Chen-Yu Tsai <we...@chromium.org>
      Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
      Gerrit-CC: Steve Cho <stev...@chromium.org>
      Gerrit-Attention: Bijan Choobineh‎ <bchoo...@chromium.org>
      Gerrit-Comment-Date: Tue, 25 Jul 2023 09:58:10 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes

      Bijan Choobineh‎ (Gerrit)

      unread,
      Jul 25, 2023, 12:54:08 PM7/25/23
      to Chen-Yu Tsai, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ozone-...@chromium.org, poscia...@chromium.org, Miguel Casas-Sanchez, Steve Cho, Chromium LUCI CQ, chromium...@chromium.org

      Attention is currently required from: Chen-Yu Tsai.

      View Change

      1 comment:

      To view, visit change 4710351. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
      Gerrit-Change-Number: 4710351
      Gerrit-PatchSet: 1
      Gerrit-Owner: Chen-Yu Tsai <we...@chromium.org>
      Gerrit-Reviewer: Bijan Choobineh‎ <bchoo...@chromium.org>
      Gerrit-Reviewer: Chen-Yu Tsai <we...@chromium.org>
      Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
      Gerrit-CC: Steve Cho <stev...@chromium.org>
      Gerrit-Attention: Chen-Yu Tsai <we...@chromium.org>
      Gerrit-Comment-Date: Tue, 25 Jul 2023 16:53:59 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No

      Chen-Yu Tsai (Gerrit)

      unread,
      Jul 26, 2023, 2:44:33 AM7/26/23
      to chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ozone-...@chromium.org, poscia...@chromium.org, Bijan Choobineh‎, Miguel Casas-Sanchez, Steve Cho, Chromium LUCI CQ, chromium...@chromium.org

      Patch set 2:Commit-Queue +2

      View Change

        To view, visit change 4710351. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
        Gerrit-Change-Number: 4710351
        Gerrit-PatchSet: 2
        Gerrit-Owner: Chen-Yu Tsai <we...@chromium.org>
        Gerrit-Reviewer: Bijan Choobineh‎ <bchoo...@chromium.org>
        Gerrit-Reviewer: Chen-Yu Tsai <we...@chromium.org>
        Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
        Gerrit-CC: Steve Cho <stev...@chromium.org>
        Gerrit-Comment-Date: Wed, 26 Jul 2023 06:44:21 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes

        Chen-Yu Tsai (Gerrit)

        unread,
        Jul 26, 2023, 3:28:36 AM7/26/23
        to chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ozone-...@chromium.org, poscia...@chromium.org, Bijan Choobineh‎, Miguel Casas-Sanchez, Steve Cho, Chromium LUCI CQ, chromium...@chromium.org

        Attention is currently required from: Chen-Yu Tsai.

        Patch set 2:Commit-Queue +2

        View Change

          To view, visit change 4710351. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
          Gerrit-Change-Number: 4710351
          Gerrit-PatchSet: 2
          Gerrit-Owner: Chen-Yu Tsai <we...@chromium.org>
          Gerrit-Reviewer: Bijan Choobineh‎ <bchoo...@chromium.org>
          Gerrit-Reviewer: Chen-Yu Tsai <we...@chromium.org>
          Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
          Gerrit-CC: Steve Cho <stev...@chromium.org>
          Gerrit-Attention: Chen-Yu Tsai <we...@chromium.org>
          Gerrit-Comment-Date: Wed, 26 Jul 2023 07:28:25 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes

          Chromium LUCI CQ (Gerrit)

          unread,
          Jul 26, 2023, 3:33:10 AM7/26/23
          to Chen-Yu Tsai, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ozone-...@chromium.org, poscia...@chromium.org, Bijan Choobineh‎, Miguel Casas-Sanchez, Steve Cho, chromium...@chromium.org

          Chromium LUCI CQ submitted this change.

          View Change



          1 is the latest approved patch-set.
          No files were changed between the latest approved patch-set and the submitted one.

          Approvals: Chen-Yu Tsai: Commit Miguel Casas-Sanchez: Looks good to me
          media/gpu/v4l2/test: Replace native references with raw_ref<T>

          Required by Chromium code style checks:

          error: [chromium-rawref] Use raw_ref<T> instead of a native reference.

          Bug: b:258331312, b:291169645
          Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
          Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4710351
          Reviewed-by: Miguel Casas-Sanchez <mca...@chromium.org>
          Commit-Queue: Chen-Yu Tsai <we...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1175274}

          ---
          M media/gpu/v4l2/test/h264_decoder.cc
          M media/gpu/v4l2/test/h264_decoder.h
          M media/gpu/v4l2/test/h265_decoder.cc
          M media/gpu/v4l2/test/h265_decoder.h
          4 files changed, 6 insertions(+), 4 deletions(-)


          To view, visit change 4710351. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I8fbfc59dce3a720e9c087796e37109a62121282c
          Gerrit-Change-Number: 4710351
          Gerrit-PatchSet: 3
          Gerrit-Owner: Chen-Yu Tsai <we...@chromium.org>
          Gerrit-Reviewer: Bijan Choobineh‎ <bchoo...@chromium.org>
          Gerrit-Reviewer: Chen-Yu Tsai <we...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
          Reply all
          Reply to author
          Forward
          0 new messages