[ozone/wayland] text-input-v3 Part 8: Enable via command line switch [chromium/src : main]
0 views
Skip to first unread message
Orko Garai (Gerrit)
Jul 16, 2024, 2:03:23 AM (11 days ago) Jul 16
to Hidehiko Abe, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Hidehiko Abe and Kramer Ge
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Hidehiko Abe
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jul 22, 2024, 2:05:32 PM (5 days ago) Jul 22
to Orko Garai, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge and Orko Garai
Hidehiko Abe added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/wayland/host/wayland_connection.cc
Line 101, Patchset 5 (Latest):
// Can be specified as value for --enable-wayland-ime to use text-input-v3Hidehiko Abe . unresolved
enable-wayland-ime is a bool flag. Could you introduce another one for v1/v3 swtiching?
Related details
Attention is currently required from:
- Kramer Ge
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Jul 22, 2024, 3:32:13 PM (5 days ago) Jul 22
to Hidehiko Abe, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Hidehiko Abe and Kramer Ge
Orko Garai added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/wayland/host/wayland_connection.cc
Line 101, Patchset 5:
// Can be specified as value for --enable-wayland-ime to use text-input-v3Hidehiko Abe . resolved
enable-wayland-ime is a bool flag. Could you introduce another one for v1/v3 swtiching?
Attention is currently required from:
- Hidehiko Abe
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jul 23, 2024, 3:41:08 AM (4 days ago) Jul 23
to Orko Garai, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge and Orko Garai
Hidehiko Abe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hidehiko Abe
| Code-Review | +1 |
1 comment
File ui/ozone/platform/wayland/host/wayland_connection.cc
Line 286, Patchset 8 (Latest):
text_input_wrapper_type_ = ZWPTextInputWrapperType::kV3;Hidehiko Abe . unresolved
LOG(WARNING) if the value is neither 1 nor 3?
Related details
Attention is currently required from:
- Kramer Ge
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Jul 24, 2024, 10:06:10 AM (3 days ago) Jul 24
to Hidehiko Abe, Kramer Ge, Nick Yamane, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge
Orko Garai added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/wayland/host/wayland_connection.cc
Line 286, Patchset 8:
text_input_wrapper_type_ = ZWPTextInputWrapperType::kV3;Hidehiko Abe . resolved
LOG(WARNING) if the value is neither 1 nor 3?
Orko Garai
Done
Related details
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nick Yamane (Gerrit)
Jul 25, 2024, 12:11:51 PM (2 days ago) Jul 25
to Orko Garai, Hidehiko Abe, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Hidehiko Abe, Kramer Ge and Orko Garai
Nick Yamane voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nick Yamane
| Code-Review | +1 |
2 comments
Patchset-level comments
File ui/ozone/platform/wayland/host/wayland_connection.cc
Line 292, Patchset 11 (Latest):
LOG(WARNING) << "text input version should be either 1 or 3.";Nick Yamane . unresolved
nit: Could we be a bit clearer on this message. eg: by mentioning which version will be used in this case? Also, shouldn't this get logged only if wayland IME is enabled?
Related details
Attention is currently required from:
- Hidehiko Abe
- Kramer Ge
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Jul 25, 2024, 12:30:41 PM (2 days ago) Jul 25
to Peter McNeeley, Scott Violet, Nick Yamane, Hidehiko Abe, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Hidehiko Abe, Kramer Ge and Peter McNeeley
Orko Garai added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 12 (Latest):
Orko Garai . resolved
As Kramer is OOO, adding @peterm...@chromium.org for new switch added in ui/ozone/public/ ozone_switches*
File ui/ozone/platform/wayland/host/wayland_connection.cc
Line 292, Patchset 11:
LOG(WARNING) << "text input version should be either 1 or 3.";Nick Yamane . resolved
nit: Could we be a bit clearer on this message. eg: by mentioning which version will be used in this case? Also, shouldn't this get logged only if wayland IME is enabled?
Attention is currently required from:
- Hidehiko Abe
- Kramer Ge
- Peter McNeeley
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Jul 25, 2024, 12:53:09 PM (2 days ago) Jul 25
to Peter McNeeley, Scott Violet, Nick Yamane, Hidehiko Abe, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Hidehiko Abe, Kramer Ge and Peter McNeeley
Orko Garai added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Orko Garai . resolved
as a side-note, I've created https://issues.chromium.org/issues/355409303 to move wayland-specific switches into files inside ozone/platform/wayland.
Peter McNeeley (Gerrit)
Jul 25, 2024, 1:08:17 PM (2 days ago) Jul 25
to Orko Garai, Scott Violet, Nick Yamane, Hidehiko Abe, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Hidehiko Abe, Kramer Ge and Orko Garai
Peter McNeeley voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hidehiko Abe
- Kramer Ge
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Jul 26, 2024, 9:53:25 AM (23 hours ago) Jul 26
to Peter McNeeley, Scott Violet, Nick Yamane, Hidehiko Abe, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Hidehiko Abe and Kramer Ge
Orko Garai voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Hidehiko Abe
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 26, 2024, 11:01:14 AM (21 hours ago) Jul 26
to Orko Garai, Peter McNeeley, Scott Violet, Nick Yamane, Hidehiko Abe, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
12 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[ozone/wayland] text-input-v3 Part 8: Enable via command line switch
Support enabling text-input-v3 when --wayland-text-input-version=3 is passed
along with --enable-wayland-ime.
Latest wayland governance meeting notes:
https://gitlab.freedesktop.org/wayland/wayland-protocols/-/wikis/meetings#2024-07-02---text-input-32-2
Design doc:
https://docs.google.com/document/d/1GkOphcAQBMdW4iPiMOd9eKd70tlXWQaR7M3GJXGUDpQ/edit
Bug: 40113488
Change-Id: I24d70d67f47bc89968b09120b4274e8a3cdcad8d
Commit-Queue: Orko Garai <or...@igalia.com>
Reviewed-by: Nick Yamane <nick...@igalia.com>
Reviewed-by: Peter McNeeley <peterm...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1333556}
Files:
- M ui/ozone/platform/wayland/host/wayland_connection.cc
- M ui/ozone/platform/wayland/host/wayland_connection.h
- M ui/ozone/platform/wayland/host/wayland_input_method_context.cc
- M ui/ozone/public/ozone_switches.cc
- M ui/ozone/public/ozone_switches.h
Change size: M
Delta: 5 files changed, 59 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Peter McNeeley, +1 by Nick Yamane
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages