[//gpu] Remove disable_es3gl_context workaround [chromium/src : main]
Geoff Lang (Gerrit)
Geoff Lang voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Colin Blundell
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peng Zhou (Gerrit)
Peng Zhou added 1 comment![]( "Open in Gerrit")
It seems our current D3D9 build is not using SW yet. I submitted a [commit](https://chromium-review.googlesource.com/c/chromium/src/+/6990804) to
enable `disable_es3gl_context` under D3D9 to address
https://issues.chromium.org/issues/447833945. There appears to be some conflict
with this change.
Related details
- Colin Blundell
- Geoff Lang
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Colin Blundell added 1 comment![]( "Open in Gerrit")
It seems our current D3D9 build is not using SW yet. I submitted a [commit](https://chromium-review.googlesource.com/c/chromium/src/+/6990804) to
enable `disable_es3gl_context` under D3D9 to address
https://issues.chromium.org/issues/447833945. There appears to be some conflict
with this change.
Thanks for reaching out! Naively, I would think that you'd be able to hook in [here](https://source.chromium.org/chromium/chromium/src/+/main:gpu/config/gpu_util.cc;l=329-333?q=DISABLE_D3D11&ss=chromium) without needing to use `disable_es3gl_context`? e.g., by leveraging the `disable_d3d11` workaround or adding a new workaround?
In any case, what you're describing sounds like a bug to me, as if ANGLE is backed by D3D9 it will only be able to support ES2 and thus won't be able to support WebGL2? i.e., naively I would think that WebGL2 *should* end up blocked with ANGLE=D3D9 without any need for a workaround?
Related details
- Peng Zhou
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Colin Blundell voted and added 2 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Commit-Queue | +1 |
Colin BlundellIt seems our current D3D9 build is not using SW yet. I submitted a [commit](https://chromium-review.googlesource.com/c/chromium/src/+/6990804) to
enable `disable_es3gl_context` under D3D9 to address
https://issues.chromium.org/issues/447833945. There appears to be some conflict
with this change.
Thanks for reaching out! Naively, I would think that you'd be able to hook in [here](https://source.chromium.org/chromium/chromium/src/+/main:gpu/config/gpu_util.cc;l=329-333?q=DISABLE_D3D11&ss=chromium) without needing to use `disable_es3gl_context`? e.g., by leveraging the `disable_d3d11` workaround or adding a new workaround?
In any case, what you're describing sounds like a bug to me, as if ANGLE is backed by D3D9 it will only be able to support ES2 and thus won't be able to support WebGL2? i.e., naively I would think that WebGL2 *should* end up blocked with ANGLE=D3D9 without any need for a workaround?
Peng: I'm going to move forward with this CL and in parallel we can discuss on your CL how to move forward there - we should find a solution but I don't think that the solution is to reuse this workaround (even in the near-term).
+kbr@ for context_lost_integration_test.py
Related details
- Colin Blundell
- Kenneth Russell
- Peng Zhou
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peng Zhou (Gerrit)
Peng Zhou added 1 comment![]( "Open in Gerrit")
Colin BlundellIt seems our current D3D9 build is not using SW yet. I submitted a [commit](https://chromium-review.googlesource.com/c/chromium/src/+/6990804) to
enable `disable_es3gl_context` under D3D9 to address
https://issues.chromium.org/issues/447833945. There appears to be some conflict
with this change.
Colin BlundellThanks for reaching out! Naively, I would think that you'd be able to hook in [here](https://source.chromium.org/chromium/chromium/src/+/main:gpu/config/gpu_util.cc;l=329-333?q=DISABLE_D3D11&ss=chromium) without needing to use `disable_es3gl_context`? e.g., by leveraging the `disable_d3d11` workaround or adding a new workaround?
In any case, what you're describing sounds like a bug to me, as if ANGLE is backed by D3D9 it will only be able to support ES2 and thus won't be able to support WebGL2? i.e., naively I would think that WebGL2 *should* end up blocked with ANGLE=D3D9 without any need for a workaround?
Peng: I'm going to move forward with this CL and in parallel we can discuss on your CL how to move forward there - we should find a solution but I don't think that the solution is to reuse this workaround (even in the near-term).
Thank you for your reply! Let’s continue the discussion on a solution here: https://chromium-review.googlesource.com/c/chromium/src/+/6990804.
Related details
- Colin Blundell
- Kenneth Russell
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Colin Blundell added 1 comment![]( "Open in Gerrit")
+Yuly in case you get to context_lost_integration_test.py first, thanks!
Related details
- Kenneth Russell
- Yuly Novikov
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuly Novikov (Gerrit)
Yuly Novikov voted Code-Review+1![]( "Open in Gerrit")
- Colin Blundell
- Kenneth Russell
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Commit-Queue | +2 |
1 comment
- Kenneth Russell
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Colin Blundell voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[//gpu] Remove disable_es3gl_context workaround
The devices that this applies to are EOL [1] and the workaround is no
longer triggered [2].
[1] https://uma.googleplex.com/p/chrome/timeline_v2?sid=61a74ebf9f73beee53ba7356402cd039
[2] https://uma.googleplex.com/p/chrome/timeline_v2?sid=602382904a280922d3f3bcf568950b3c
- M content/test/content_test_bundle_data.filelist
- D content/test/data/gpu/webgl2-context-blocked.html
- M content/test/gpu/gpu_tests/context_lost_integration_test.py
- M content/test/gpu/gpu_tests/test_expectations/context_lost_expectations.txt
- M gpu/command_buffer/service/service_utils.cc
- M gpu/config/gpu_driver_bug_list.json
- M gpu/config/gpu_util.cc
- M gpu/config/gpu_workaround_list.txt
- M ui/gl/gl_surface_egl.cc
- M ui/gl/gl_utils.h
Code-Review: +1 by Yuly Novikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |