[M129] Reland "Per-window scale: Skip display scale comparison on display metrics change" [chromium/src : refs/branch-heads/6668]

0 views
Skip to first unread message

Orko Garai (Gerrit)

unread,
Sep 6, 2024, 3:38:15 PM9/6/24
to Rubber Stamper, Scott Violet, Jonathan Ross, Nick Yamane, James Su, Sadrul Chowdhury, AyeAye, creis...@chromium.org, alexmo...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, keithle...@chromium.org, max+watc...@igalia.com, tranbaod...@chromium.org, jbauma...@chromium.org, ozone-...@chromium.org, nickdiego+wa...@igalia.com, navigation...@chromium.org, yhanad...@chromium.org
Attention needed from Jonathan Ross, Nick Yamane and Scott Violet

Orko Garai voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
  • Nick Yamane
  • Scott Violet
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I86119b8df4637b4ffbac0c540de3420f15db2678
Gerrit-Change-Number: 5838808
Gerrit-PatchSet: 1
Gerrit-Owner: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Nick Yamane <nick...@igalia.com>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Sep 2024 15:38:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Sep 6, 2024, 3:39:16 PM9/6/24
to Orko Garai, Chromium LUCI CQ, Scott Violet, Jonathan Ross, Nick Yamane, James Su, Sadrul Chowdhury, AyeAye, creis...@chromium.org, alexmo...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, keithle...@chromium.org, max+watc...@igalia.com, tranbaod...@chromium.org, jbauma...@chromium.org, ozone-...@chromium.org, nickdiego+wa...@igalia.com, navigation...@chromium.org, yhanad...@chromium.org
Attention needed from Jonathan Ross, Nick Yamane and Scott Violet

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
  • Nick Yamane
  • Scott Violet
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I86119b8df4637b4ffbac0c540de3420f15db2678
Gerrit-Change-Number: 5838808
Gerrit-PatchSet: 1
Gerrit-Owner: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Nick Yamane <nick...@igalia.com>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Sep 2024 15:39:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Sep 6, 2024, 3:43:16 PM9/6/24
to Orko Garai, Chromium LUCI CQ, Scott Violet, Jonathan Ross, Nick Yamane, James Su, Sadrul Chowdhury, AyeAye, creis...@chromium.org, alexmo...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, keithle...@chromium.org, max+watc...@igalia.com, tranbaod...@chromium.org, jbauma...@chromium.org, ozone-...@chromium.org, nickdiego+wa...@igalia.com, navigation...@chromium.org, yhanad...@chromium.org
Attention needed from Jonathan Ross, Nick Yamane, Orko Garai and Scott Violet

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
  • Nick Yamane
  • Orko Garai
  • Scott Violet
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I86119b8df4637b4ffbac0c540de3420f15db2678
Gerrit-Change-Number: 5838808
Gerrit-PatchSet: 2
Gerrit-Owner: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Nick Yamane <nick...@igalia.com>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Attention: Orko Garai <or...@igalia.com>
Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Sep 2024 15:43:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jonathan Ross (Gerrit)

unread,
Sep 6, 2024, 5:07:45 PM9/6/24
to Orko Garai, Rubber Stamper, Chromium LUCI CQ, Scott Violet, Nick Yamane, James Su, Sadrul Chowdhury, AyeAye, creis...@chromium.org, alexmo...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, keithle...@chromium.org, max+watc...@igalia.com, tranbaod...@chromium.org, jbauma...@chromium.org, ozone-...@chromium.org, nickdiego+wa...@igalia.com, navigation...@chromium.org, yhanad...@chromium.org
Attention needed from Nick Yamane, Orko Garai and Scott Violet

Jonathan Ross voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
Gerrit-Comment-Date: Fri, 06 Sep 2024 17:07:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Scott Violet (Gerrit)

unread,
Sep 6, 2024, 7:51:50 PM9/6/24
to Orko Garai, Scott Violet, Jonathan Ross, Rubber Stamper, Chromium LUCI CQ, Nick Yamane, James Su, Sadrul Chowdhury, AyeAye, creis...@chromium.org, alexmo...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, keithle...@chromium.org, max+watc...@igalia.com, tranbaod...@chromium.org, jbauma...@chromium.org, ozone-...@chromium.org, nickdiego+wa...@igalia.com, navigation...@chromium.org, yhanad...@chromium.org
Attention needed from Jonathan Ross, Nick Yamane and Orko Garai

Scott Violet voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
  • Nick Yamane
  • Orko Garai
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I86119b8df4637b4ffbac0c540de3420f15db2678
Gerrit-Change-Number: 5838808
Gerrit-PatchSet: 2
Gerrit-Owner: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Nick Yamane <nick...@igalia.com>
Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
Gerrit-Attention: Orko Garai <or...@igalia.com>
Gerrit-Comment-Date: Fri, 06 Sep 2024 19:51:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Orko Garai (Gerrit)

unread,
Sep 6, 2024, 7:55:10 PM9/6/24
to Scott Violet, Jonathan Ross, Rubber Stamper, Chromium LUCI CQ, Nick Yamane, James Su, Sadrul Chowdhury, AyeAye, creis...@chromium.org, alexmo...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, keithle...@chromium.org, max+watc...@igalia.com, tranbaod...@chromium.org, jbauma...@chromium.org, ozone-...@chromium.org, nickdiego+wa...@igalia.com, navigation...@chromium.org, yhanad...@chromium.org
Attention needed from Jonathan Ross and Nick Yamane

Orko Garai voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
  • Nick Yamane
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I86119b8df4637b4ffbac0c540de3420f15db2678
Gerrit-Change-Number: 5838808
Gerrit-PatchSet: 2
Gerrit-Owner: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Nick Yamane <nick...@igalia.com>
Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Sep 2024 19:55:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 6, 2024, 8:02:30 PM9/6/24
to Orko Garai, Scott Violet, Jonathan Ross, Rubber Stamper, Nick Yamane, James Su, Sadrul Chowdhury, AyeAye, creis...@chromium.org, alexmo...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, keithle...@chromium.org, max+watc...@igalia.com, tranbaod...@chromium.org, jbauma...@chromium.org, ozone-...@chromium.org, nickdiego+wa...@igalia.com, navigation...@chromium.org, yhanad...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[M129] Reland "Per-window scale: Skip display scale comparison on display metrics change"

This is a reland of commit 389ee9785b3b9a55791bb3faf8fcfe4d1bc31ff2

In the previous approach to change runtime properties from tests,
the runtime properties were getting overridden again on each call to
GetRuntimeProperties(). So use a specific override for the
supports_per_window_scaling property and limit the test scope only to
wayland as this is not used in any other platform at this time.

Fixed: 360147125

Original change's description:
> Per-window scale: Skip display scale comparison on display metrics
> change
>
> Ensure that if per-window scaling is enabled,
> RenderWidgetHostViewAura::OnDisplayMetricsChanged shouldn't compare
> WindowTreeHost scale with display scale which leads to visual properties
> synchronization being suppressed when the inferred display scale value
> has rounding errors.
>
> Fixed: 360147125
> Change-Id: I85e18ec6ea698a0cffb719ed0637fd74dcbfdfa6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5800157
> Reviewed-by: Jonathan Ross <jon...@chromium.org>
> Reviewed-by: Scott Violet <s...@chromium.org>
> Reviewed-by: Kramer Ge <fang...@chromium.org>
> Commit-Queue: Orko Garai <or...@igalia.com>
> Cr-Commit-Position: refs/heads/main@{#1348652}

(cherry picked from commit f231408b8608b9c88742293d61c07f131865ed86)
Change-Id: I86119b8df4637b4ffbac0c540de3420f15db2678
Auto-Submit: Orko Garai <or...@igalia.com>
Commit-Queue: Jonathan Ross <jon...@chromium.org>
Reviewed-by: Scott Violet <s...@chromium.org>
Reviewed-by: Nick Yamane <nick...@igalia.com>
Reviewed-by: Jonathan Ross <jon...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1350523}
Commit-Queue: Orko Garai <or...@igalia.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6668@{#958}
Cr-Branched-From: 05bc664984ca075216b7f2198c88b9725bfa1b9b-refs/heads/main@{#1343869}
Files:
  • M chrome/browser/ui/views/frame/desktop_browser_frame_aura_linux_browsertest.cc
  • M content/browser/renderer_host/DEPS
  • M content/browser/renderer_host/render_widget_host_view_aura.cc
  • M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
  • M ui/aura/test/test_screen.cc
  • M ui/aura/test/test_screen.h
  • M ui/ozone/platform/wayland/ozone_platform_wayland.cc
  • M ui/ozone/public/ozone_platform.cc
  • M ui/ozone/public/ozone_platform.h
Change size: M
Delta: 9 files changed, 115 insertions(+), 15 deletions(-)
Branch: refs/branch-heads/6668
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Scott Violet, +1 by Jonathan Ross, Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I86119b8df4637b4ffbac0c540de3420f15db2678
Gerrit-Change-Number: 5838808
Gerrit-PatchSet: 3
Gerrit-Owner: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages