Refactor OSExchangeData to consolidate URL retrieval into GetURLs() [chromium/src : main]

0 views
Skip to first unread message

Mikel Astiz (Gerrit)

unread,
Jan 22, 2026, 11:06:57 AM (11 days ago) Jan 22
to Joone Hur, Avi Drissman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, dcheng+c...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Avi Drissman and Joone Hur

Mikel Astiz voted and added 1 comment

Votes added by Mikel Astiz

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Mikel Astiz . resolved

bookmarks LGTM, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
  • Joone Hur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee236ed4c353f715a0227db96e13d116f6dc64f2
Gerrit-Change-Number: 7499503
Gerrit-PatchSet: 11
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Joone Hur <joon...@microsoft.com>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Jan 2026 16:06:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Avi Drissman (Gerrit)

unread,
Jan 22, 2026, 11:15:53 AM (11 days ago) Jan 22
to Joone Hur, Mikel Astiz, Avi Drissman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, dcheng+c...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Joone Hur

Avi Drissman added 1 comment

Patchset-level comments
Avi Drissman . resolved

Mac LGTM, please get OKs from other platform folks.

Not +1-ing as my approval is global and I’m not qualified to opine on the other platforms.

But happy to see this cleanup.

Open in Gerrit

Related details

Attention is currently required from:
  • Joone Hur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee236ed4c353f715a0227db96e13d116f6dc64f2
Gerrit-Change-Number: 7499503
Gerrit-PatchSet: 11
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Joone Hur <joon...@microsoft.com>
Gerrit-Comment-Date: Thu, 22 Jan 2026 16:15:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Jan 22, 2026, 2:40:37 PM (10 days ago) Jan 22
to Joone Hur, Mikel Astiz, Avi Drissman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, dcheng+c...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Joone Hur

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

Code-Review+1

1 comment

Patchset-level comments
Thomas Anderson . resolved

ui/base/x and ui/ozone/platform/wayland lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Joone Hur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee236ed4c353f715a0227db96e13d116f6dc64f2
Gerrit-Change-Number: 7499503
Gerrit-PatchSet: 11
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Joone Hur <joon...@microsoft.com>
Gerrit-Comment-Date: Thu, 22 Jan 2026 19:40:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dana Fried (Gerrit)

unread,
Jan 26, 2026, 12:45:27 PM (7 days ago) Jan 26
to Joone Hur, Dan Clark, Thomas Anderson, Mikel Astiz, Avi Drissman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, dcheng+c...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Dan Clark and Joone Hur

Dana Fried added 1 comment

Patchset-level comments
Dana Fried . resolved

Adding Dan Clark, who is OWNERS on clipboard/dragdrop

Open in Gerrit

Related details

Attention is currently required from:
  • Dan Clark
  • Joone Hur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee236ed4c353f715a0227db96e13d116f6dc64f2
Gerrit-Change-Number: 7499503
Gerrit-PatchSet: 11
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Joone Hur <joon...@microsoft.com>
Gerrit-Attention: Dan Clark <dan...@microsoft.com>
Gerrit-Comment-Date: Mon, 26 Jan 2026 17:45:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dana Fried (Gerrit)

unread,
Jan 26, 2026, 12:46:13 PM (7 days ago) Jan 26
to Joone Hur, Dan Clark, Thomas Anderson, Mikel Astiz, Avi Drissman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, dcheng+c...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Dan Clark and Joone Hur

Dana Fried voted and added 1 comment

Votes added by Dana Fried

Code-Review+1

1 comment

Patchset-level comments
Dana Fried . resolved

LGTM for c/b/ui

Gerrit-Comment-Date: Mon, 26 Jan 2026 17:46:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dan Clark (Gerrit)

unread,
Jan 26, 2026, 7:25:39 PM (6 days ago) Jan 26
to Joone Hur, Dana Fried, Thomas Anderson, Mikel Astiz, Avi Drissman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, dcheng+c...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Joone Hur

Dan Clark voted and added 1 comment

Votes added by Dan Clark

Code-Review+1

1 comment

Patchset-level comments
Dan Clark . resolved

dragdrop LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Joone Hur
Gerrit-Comment-Date: Tue, 27 Jan 2026 00:25:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joone Hur (Gerrit)

unread,
Jan 26, 2026, 8:24:45 PM (6 days ago) Jan 26
to Dan Clark, Dana Fried, Thomas Anderson, Mikel Astiz, Avi Drissman, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, dcheng+c...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Avi Drissman

Joone Hur added 1 comment

Patchset-level comments
Avi Drissman . resolved

Mac LGTM, please get OKs from other platform folks.

Not +1-ing as my approval is global and I’m not qualified to opine on the other platforms.

But happy to see this cleanup.

Joone Hur

@a...@chromium.org Do we need any additional reviews? If not, could you help me land this CL?

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee236ed4c353f715a0227db96e13d116f6dc64f2
Gerrit-Change-Number: 7499503
Gerrit-PatchSet: 11
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Tue, 27 Jan 2026 01:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Avi Drissman <a...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Avi Drissman (Gerrit)

unread,
Jan 26, 2026, 8:50:30 PM (6 days ago) Jan 26
to Joone Hur, Avi Drissman, Dan Clark, Dana Fried, Thomas Anderson, Mikel Astiz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, dcheng+c...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Joone Hur

Avi Drissman voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joone Hur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee236ed4c353f715a0227db96e13d116f6dc64f2
Gerrit-Change-Number: 7499503
Gerrit-PatchSet: 11
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Joone Hur <joon...@microsoft.com>
Gerrit-Comment-Date: Tue, 27 Jan 2026 01:50:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Avi Drissman (Gerrit)

unread,
Jan 26, 2026, 8:50:31 PM (6 days ago) Jan 26
to Joone Hur, Avi Drissman, Dan Clark, Dana Fried, Thomas Anderson, Mikel Astiz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, dcheng+c...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Joone Hur

Avi Drissman voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Tue, 27 Jan 2026 01:50:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Joone Hur (Gerrit)

unread,
Jan 27, 2026, 12:10:14 AM (6 days ago) Jan 27
to Avi Drissman, Dan Clark, Dana Fried, Thomas Anderson, Mikel Astiz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, dcheng+c...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Avi Drissman

Joone Hur voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee236ed4c353f715a0227db96e13d116f6dc64f2
Gerrit-Change-Number: 7499503
Gerrit-PatchSet: 11
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Tue, 27 Jan 2026 05:10:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 27, 2026, 1:03:26 AM (6 days ago) Jan 27
to Joone Hur, Avi Drissman, Dan Clark, Dana Fried, Thomas Anderson, Mikel Astiz, AyeAye, chromium...@chromium.org, Sadrul Chowdhury, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, dcheng+c...@chromium.org, jdonnel...@chromium.org, mac-r...@chromium.org, omnibox-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Refactor OSExchangeData to consolidate URL retrieval into GetURLs()

This patch removes the redundant GetURLsAndTitles() method and replaces
its usage with GetURLs(). Since GetURLs() returns a vector of
ui::ClipboardUrlInfo (which already contains both the URL and the
title), a separate method for "Titles" is no longer necessary.

This cleanup simplifies the OSExchangeData and OSExchangeDataProvider
interfaces across all platforms (Win, Mac, X11, and Non-Backed).
Bug: 41011768
Change-Id: Iee236ed4c353f715a0227db96e13d116f6dc64f2
Reviewed-by: Mikel Astiz <mas...@chromium.org>
Reviewed-by: Dana Fried <dfr...@chromium.org>
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Commit-Queue: Joone Hur <joon...@microsoft.com>
Reviewed-by: Dan Clark <dan...@microsoft.com>
Reviewed-by: Avi Drissman <a...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1574993}
Files:
  • M chrome/browser/ui/bookmarks/bookmark_browsertest.cc
  • M chrome/browser/ui/views/omnibox/omnibox_view_views.cc
  • M chrome/browser/ui/views/toolbar/home_button.cc
  • M components/bookmarks/browser/bookmark_node_data_unittest.cc
  • M components/bookmarks/browser/bookmark_node_data_views.cc
  • M content/browser/web_contents/web_contents_view_aura.cc
  • M ui/base/dragdrop/os_exchange_data.cc
  • M ui/base/dragdrop/os_exchange_data.h
  • M ui/base/dragdrop/os_exchange_data_provider.h
  • M ui/base/dragdrop/os_exchange_data_provider_mac.h
  • M ui/base/dragdrop/os_exchange_data_provider_mac.mm
  • M ui/base/dragdrop/os_exchange_data_provider_non_backed.cc
  • M ui/base/dragdrop/os_exchange_data_provider_non_backed.h
  • M ui/base/dragdrop/os_exchange_data_provider_non_backed_unittest.cc
  • M ui/base/dragdrop/os_exchange_data_provider_win.cc
  • M ui/base/dragdrop/os_exchange_data_provider_win.h
  • M ui/base/dragdrop/os_exchange_data_unittest.cc
  • M ui/base/dragdrop/os_exchange_data_win_unittest.cc
  • M ui/base/x/x11_os_exchange_data_provider.cc
  • M ui/base/x/x11_os_exchange_data_provider.h
  • M ui/ozone/platform/wayland/host/wayland_data_drag_controller_unittest.cc
  • M ui/ozone/platform/wayland/host/wayland_exchange_data_provider.cc
  • M ui/ozone/platform/x11/test/os_exchange_data_provider_x11_unittest.cc
Change size: M
Delta: 23 files changed, 54 insertions(+), 165 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Thomas Anderson, +1 by Avi Drissman, +1 by Dan Clark, +1 by Mikel Astiz, +1 by Dana Fried
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee236ed4c353f715a0227db96e13d116f6dc64f2
Gerrit-Change-Number: 7499503
Gerrit-PatchSet: 12
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Mikel Astiz <mas...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages