Multi-EGL display [chromium/src : main]

1 view
Skip to first unread message

Zhenyao Mo (Gerrit)

unread,
Oct 25, 2021, 3:00:23 AM10/25/21
to Geoff Lang, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, Tricium, chromium...@chromium.org

Attention is currently required from: Geoff Lang.

View Change

3 comments:

  • Patchset:

    • Patch Set #5:

      Geoff, I think I need a bit more time to fully wire this up. I believe what's left are the two places (I left a comment at each place), but both of them do not seem trivia.

  • File gpu/command_buffer/service/shared_image_backing_gl_image.cc:

    • Patch Set #5, Line 265: // TODO(zmo): maybe add an ANGLE extention function to do the copying?

      When I reached here, I realized I don't have access to the D3D textures for me to copy the data. Geoff, any suggestions? Maybe the easiest is to provide an ANGLE extension function to do the trick.

  • File gpu/command_buffer/service/shared_image_backing_gl_texture.cc:

    • Patch Set #5, Line 217: service_id = gl_service_id_on_integrated_gpu_;

      This doesn't seem to provide a valid texture for Skia to use. I will need to ask someone to help me understand how this SkiPromiseImageTexture mechanism works.

To view, visit change 3238182. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5ac4d5afc63847b78a735add18120887d6018168
Gerrit-Change-Number: 3238182
Gerrit-PatchSet: 5
Gerrit-Owner: Geoff Lang <geof...@chromium.org>
Gerrit-CC: Zhenyao Mo <z...@chromium.org>
Gerrit-Attention: Geoff Lang <geof...@chromium.org>
Gerrit-Comment-Date: Mon, 25 Oct 2021 07:00:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Geoff Lang (Gerrit)

unread,
Apr 16, 2026, 4:29:23 PM (13 days ago) Apr 16
to Zhenyao Mo, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org

Geoff Lang abandoned this change.

View Change

Abandoned

Geoff Lang abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5ac4d5afc63847b78a735add18120887d6018168
Gerrit-Change-Number: 3238182
Gerrit-PatchSet: 10
Gerrit-Owner: Geoff Lang <geof...@chromium.org>
Gerrit-CC: Name of user not set #1242319
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages