Kramer Ge (Gerrit)

unread,

Jun 24, 2025, 1:28:48 PM6/24/25

to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Colin Blundell

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Jun 24, 2025, 4:40:01 PM6/24/25

to Peter McNeeley, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Colin Blundell and Peter McNeeley

Kramer Ge added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Kramer Ge . resolved

+colin for `ui/gl/`,`ui/gfx/`, +petermcneeley for `ui/ozone/platform/wayland/`

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Peter McNeeley

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Peter McNeeley (Gerrit)

unread,

Jun 24, 2025, 4:43:02 PM6/24/25

to Kramer Ge, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Kramer Ge

Peter McNeeley added 1 comment

File ui/ozone/platform/wayland/gpu/wayland_surface_factory.cc

Line 187, Patchset 7: native_display_ = gl::EGLDisplayPlatform(EGL_DEFAULT_DISPLAY,

Peter McNeeley . unresolved

feels odd to reinit. Maybe have an else?

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Jun 24, 2025, 4:52:20 PM6/24/25

to Peter McNeeley, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Colin Blundell and Peter McNeeley

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

Commit-Queue

+1

1 comment

File ui/ozone/platform/wayland/gpu/wayland_surface_factory.cc

Line 187, Patchset 7: native_display_ = gl::EGLDisplayPlatform(EGL_DEFAULT_DISPLAY,

Peter McNeeley . resolved

feels odd to reinit. Maybe have an else?

Kramer Ge

Done

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Peter McNeeley

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Jun 25, 2025, 2:44:25 AM6/25/25

to Kramer Ge, Peter McNeeley, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Kramer Ge and Peter McNeeley

Colin Blundell added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Colin Blundell . resolved

Thanks! Test failure looks related?

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge
Peter McNeeley

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Jun 25, 2025, 2:01:45 PM6/25/25

to Peter McNeeley, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Colin Blundell and Peter McNeeley

Kramer Ge added 1 comment

Patchset-level comments

File-level comment, Patchset 9:

Colin Blundell . resolved

Thanks! Test failure looks related?

Kramer Ge

Yep, caught by the new `linux-wayland-mutter-rel` \o/. Just fixed.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Peter McNeeley

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Jun 26, 2025, 2:47:33 AM6/26/25

to Kramer Ge, Colin Blundell, Peter McNeeley, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Kramer Ge and Peter McNeeley

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Colin Blundell . resolved

Thanks! //ui/gfx and //ui/gl LGTM for OWNERS, but I defer to Peter on the technical change - please wait for his LGTM as well.

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge
Peter McNeeley

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Peter McNeeley (Gerrit)

unread,

Jun 26, 2025, 1:16:19 PM6/26/25

to Kramer Ge, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Kramer Ge

Peter McNeeley voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Jun 26, 2025, 1:18:00 PM6/26/25

to Peter McNeeley, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Kramer Ge . resolved

ping

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 26, 2025, 2:55:36 PM6/26/25

to Kramer Ge, Peter McNeeley, Colin Blundell, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[Ozone/Wayland]Init EGL display using EGL_PLATFORM_GBM_KHR

For users with multiple GPUs:

--render-node-override=/dev/dri/renderDX can specify the path for
gbm_device. wayland_buffer_manager_gpu uses it for dmabuf allocation but
it's not used for GL initialization.

This patch uses said gbm_device as the native_display of type
EGL_PLATFORM_GBM_KHR for eglDisplay so compositing and buffer allocation
both use the same device.

In ozone/wayland when using ANGLE, platform is EGL_PLATFORM_ANGLE_ANGLE,
so EGL_PLATFORM_GBM_KHR is added as the
EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE attribute.

ANGLE will expose EGL_KHR_platform_gbm extension when
https://chromium-review.googlesource.com/c/angle/angle/+/6663699 lands.

Bug: 396434686

Change-Id: Ie0e3198278424a4fb321f8bb99138364d1422df1

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6663458

Commit-Queue: Kramer Ge <fang...@chromium.org>

Reviewed-by: Colin Blundell <blun...@chromium.org>

Reviewed-by: Peter McNeeley <peterm...@google.com>

Cr-Commit-Position: refs/heads/main@{#1479355}

Files:

M ui/gfx/linux/gbm_device.h
M ui/gfx/linux/gbm_wrapper.cc
M ui/gfx/linux/gbm_wrapper.h
M ui/gl/generate_bindings.py
M ui/gl/gl_bindings_autogen_egl.cc
M ui/gl/gl_bindings_autogen_egl.h
M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.cc
M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.h
M ui/ozone/platform/wayland/gpu/wayland_gl_egl_utility.cc
M ui/ozone/platform/wayland/gpu/wayland_surface_factory.cc

Change size: M

Delta: 10 files changed, 83 insertions(+), 16 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Colin Blundell, +1 by Peter McNeeley

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

vsl blink (Gerrit)

unread,

Jan 30, 2026, 1:48:16 AM (3 days ago) Jan 30

to Chromium LUCI CQ, Peter McNeeley, Colin Blundell, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

vsl blink added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

vsl blink . resolved

Hi, I'm having with EGL_PLATFORM_GBM_KHR for qualcomm gpu vendor, is there anyway to exclude EGL_KHR_platform_gbm extensions from our environment?

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Jan 30, 2026, 11:24:51 AM (3 days ago) Jan 30

to Chromium LUCI CQ, vsl blink, Peter McNeeley, Colin Blundell, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Kramer Ge added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

vsl blink . resolved

Hi, I'm having with EGL_PLATFORM_GBM_KHR for qualcomm gpu vendor, is there anyway to exclude EGL_KHR_platform_gbm extensions from our environment?

Kramer Ge

Use `--ozone-platform=x11` which will lead to `EGL_PLATFORM_X11_EXT` instead.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[Ozone/Wayland]Init EGL display using EGL_PLATFORM_GBM_KHR [chromium/src : main]

Kramer Ge (Gerrit)

New activity on the change

Related details

Kramer Ge (Gerrit)

Kramer Ge added 1 comment

Related details

Peter McNeeley (Gerrit)

Peter McNeeley added 1 comment

Related details

Kramer Ge (Gerrit)

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

1 comment

Related details

Colin Blundell (Gerrit)

Colin Blundell added 1 comment

Related details

Kramer Ge (Gerrit)

Kramer Ge added 1 comment

Related details

Colin Blundell (Gerrit)

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

1 comment

Related details

Peter McNeeley (Gerrit)

Peter McNeeley voted Code-Review+1

Related details

Kramer Ge (Gerrit)

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

vsl blink (Gerrit)

vsl blink added 1 comment

Related details

Kramer Ge (Gerrit)

Kramer Ge added 1 comment

Related details