[Ozone/Wayland]Init EGL display using EGL_PLATFORM_GBM_KHR [chromium/src : main]
Kramer Ge (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Colin Blundell
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Kramer Ge added 1 comment![]( "Open in Gerrit")
+colin for `ui/gl/`,`ui/gfx/`, +petermcneeley for `ui/ozone/platform/wayland/`
Related details
- Colin Blundell
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley added 1 comment![]( "Open in Gerrit")
native_display_ = gl::EGLDisplayPlatform(EGL_DEFAULT_DISPLAY,feels odd to reinit. Maybe have an else?
Related details
- Kramer Ge
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Commit-Queue | +1 |
1 comment
native_display_ = gl::EGLDisplayPlatform(EGL_DEFAULT_DISPLAY,feels odd to reinit. Maybe have an else?
- Colin Blundell
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Colin Blundell added 1 comment![]( "Open in Gerrit")
Thanks! Test failure looks related?
Related details
- Kramer Ge
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Kramer Ge added 1 comment![]( "Open in Gerrit")
Thanks! Test failure looks related?
Yep, caught by the new `linux-wayland-mutter-rel` \o/. Just fixed.
Related details
- Colin Blundell
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Thanks! //ui/gfx and //ui/gl LGTM for OWNERS, but I defer to Peter on the technical change - please wait for his LGTM as well.
Related details
- Kramer Ge
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Kramer Ge
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Commit-Queue | +2 |
1 comment
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[Ozone/Wayland]Init EGL display using EGL_PLATFORM_GBM_KHR
For users with multiple GPUs:
--render-node-override=/dev/dri/renderDX can specify the path for
gbm_device. wayland_buffer_manager_gpu uses it for dmabuf allocation but
it's not used for GL initialization.
This patch uses said gbm_device as the native_display of type
EGL_PLATFORM_GBM_KHR for eglDisplay so compositing and buffer allocation
both use the same device.
In ozone/wayland when using ANGLE, platform is EGL_PLATFORM_ANGLE_ANGLE,
so EGL_PLATFORM_GBM_KHR is added as the
EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE attribute.
ANGLE will expose EGL_KHR_platform_gbm extension when
https://chromium-review.googlesource.com/c/angle/angle/+/6663699 lands.
- M ui/gfx/linux/gbm_device.h
- M ui/gfx/linux/gbm_wrapper.cc
- M ui/gfx/linux/gbm_wrapper.h
- M ui/gl/generate_bindings.py
- M ui/gl/gl_bindings_autogen_egl.cc
- M ui/gl/gl_bindings_autogen_egl.h
- M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.cc
- M ui/ozone/platform/wayland/gpu/wayland_buffer_manager_gpu.h
- M ui/ozone/platform/wayland/gpu/wayland_gl_egl_utility.cc
- M ui/ozone/platform/wayland/gpu/wayland_surface_factory.cc
Code-Review: +1 by Colin Blundell, +1 by Peter McNeeley
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
vsl blink (Gerrit)
vsl blink added 1 comment![]( "Open in Gerrit")
Hi, I'm having with EGL_PLATFORM_GBM_KHR for qualcomm gpu vendor, is there anyway to exclude EGL_KHR_platform_gbm extensions from our environment?
Related details
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Kramer Ge added 1 comment![]( "Open in Gerrit")
Hi, I'm having with EGL_PLATFORM_GBM_KHR for qualcomm gpu vendor, is there anyway to exclude EGL_KHR_platform_gbm extensions from our environment?
Use `--ozone-platform=x11` which will lead to `EGL_PLATFORM_X11_EXT` instead.
Related details
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
vsl blink (Gerrit)
vsl blink added 1 comment![]( "Open in Gerrit")
Kramer GeHi, I'm having with EGL_PLATFORM_GBM_KHR for qualcomm gpu vendor, is there anyway to exclude EGL_KHR_platform_gbm extensions from our environment?
Use `--ozone-platform=x11` which will lead to `EGL_PLATFORM_X11_EXT` instead.
Thank you for your suggestion. But we can't use that method because the Ozone platform is already using Wayland. What happens if our devices have only one GPU and we don't apply this patch?
Related details
- Kramer Ge
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Kramer Ge added 1 comment![]( "Open in Gerrit")
Kramer GeHi, I'm having with EGL_PLATFORM_GBM_KHR for qualcomm gpu vendor, is there anyway to exclude EGL_KHR_platform_gbm extensions from our environment?
vsl blinkUse `--ozone-platform=x11` which will lead to `EGL_PLATFORM_X11_EXT` instead.
Thank you for your suggestion. But we can't use that method because the Ozone platform is already using Wayland. What happens if our devices have only one GPU and we don't apply this patch?
This patch is to make buffer allocation and GL init use the same gpu device. If your device only have one GPU this patch should make no difference.
Related details
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
vsl blink (Gerrit)
vsl blink added 1 comment![]( "Open in Gerrit")
Kramer GeHi, I'm having with EGL_PLATFORM_GBM_KHR for qualcomm gpu vendor, is there anyway to exclude EGL_KHR_platform_gbm extensions from our environment?
vsl blinkUse `--ozone-platform=x11` which will lead to `EGL_PLATFORM_X11_EXT` instead.
Kramer GeThank you for your suggestion. But we can't use that method because the Ozone platform is already using Wayland. What happens if our devices have only one GPU and we don't apply this patch?
This patch is to make buffer allocation and GL init use the same gpu device. If your device only have one GPU this patch should make no difference.
I got it.
Does it strictly depend on the driver? Our board crashes after the following attributes are added:
```
display_attributes->push_back(EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE);
display_attributes->push_back(EGL_PLATFORM_GBM_KHR);
```
Related details
- Kramer Ge
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Kramer Ge added 1 comment![]( "Open in Gerrit")
Kramer GeHi, I'm having with EGL_PLATFORM_GBM_KHR for qualcomm gpu vendor, is there anyway to exclude EGL_KHR_platform_gbm extensions from our environment?
vsl blinkUse `--ozone-platform=x11` which will lead to `EGL_PLATFORM_X11_EXT` instead.
Kramer GeThank you for your suggestion. But we can't use that method because the Ozone platform is already using Wayland. What happens if our devices have only one GPU and we don't apply this patch?
vsl blinkThis patch is to make buffer allocation and GL init use the same gpu device. If your device only have one GPU this patch should make no difference.
I got it.
Does it strictly depend on the driver? Our board crashes after the following attributes are added:
```
display_attributes->push_back(EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE);
display_attributes->push_back(EGL_PLATFORM_GBM_KHR);
```
It depends on whether ANGLE sees the driver [has such extension](https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/src/libANGLE/validationEGL.cpp;l=663?ss=chromium&q=-f:third_party%2F.*%2Fthird_party%2F%7Cout%2F%20EGL_PLATFORM_GBM_KHR)
It may provide an error string about it. You can try other `EGL_PLATFORM_*` in that list.
Related details
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
vsl blink (Gerrit)
vsl blink added 1 comment![]( "Open in Gerrit")
Kramer GeHi, I'm having with EGL_PLATFORM_GBM_KHR for qualcomm gpu vendor, is there anyway to exclude EGL_KHR_platform_gbm extensions from our environment?
vsl blinkUse `--ozone-platform=x11` which will lead to `EGL_PLATFORM_X11_EXT` instead.
Kramer GeThank you for your suggestion. But we can't use that method because the Ozone platform is already using Wayland. What happens if our devices have only one GPU and we don't apply this patch?
vsl blinkThis patch is to make buffer allocation and GL init use the same gpu device. If your device only have one GPU this patch should make no difference.
Kramer GeI got it.
Does it strictly depend on the driver? Our board crashes after the following attributes are added:
```
display_attributes->push_back(EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE);
display_attributes->push_back(EGL_PLATFORM_GBM_KHR);
```
vsl blinkIt depends on whether ANGLE sees the driver [has such extension](https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/src/libANGLE/validationEGL.cpp;l=663?ss=chromium&q=-f:third_party%2F.*%2Fthird_party%2F%7Cout%2F%20EGL_PLATFORM_GBM_KHR)
It may provide an error string about it. You can try other `EGL_PLATFORM_*` in that list.
Thank you for the explanation!
Related details
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |