drm: Add flag to disable explicit dma fences [chromium/src : master]
Daniele Castagna (Gerrit)
Daniele Castagna would like Kenneth Russell to review this change.
drm: Add flag to disable explicit dma fences
On Eve, Nocturne and Soraka we noticed some glitches that look like we're
scanning out a buffer while it's being composited.
This patch adds an about://flags to disable explicit dma fences, in this
way we can try to see if those glitches are still presen when using
implicit fences instead of explicit ones.
Bug: 889530
Change-Id: I34c79a65ba0691ccd442e5c30f49b05394398a42
---
M chrome/browser/about_flags.cc
M chrome/browser/chromeos/login/chrome_restart_request.cc
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M content/browser/gpu/gpu_process_host.cc
M ui/ozone/platform/drm/gpu/drm_window_proxy.cc
M ui/ozone/public/ozone_switches.cc
M ui/ozone/public/ozone_switches.h
8 files changed, 23 insertions(+), 1 deletion(-)
To view, visit change 1294300. To unsubscribe, or for help writing mail filters, visit settings.
Daniele Castagna (Gerrit)
This change is ready for review.
Kenneth Russell (Gerrit)
lgtm with one question
Patch set 2:Code-Review +1
1 comment:
File content/browser/gpu/gpu_process_host.cc:
Patch Set #2, Line 243:
switches::kDisableExplicitDmaFences,Since the other flags are #ifdef OS_CHROMEOS does this one need to match?
To view, visit change 1294300. To unsubscribe, or for help writing mail filters, visit settings.
Michael Spang (Gerrit)
1 comment:
Patch Set #2, Line 243:
switches::kDisableExplicitDmaFences,Since the other flags are #ifdef OS_CHROMEOS does this one need to match?
I'd rather not guard any DRM platform features or related code by OS_CHROMEOS unless truly necessary because there are non-Chrome OS products using that code nowadays.
To view, visit change 1294300. To unsubscribe, or for help writing mail filters, visit settings.
Michael Spang (Gerrit)
1 comment:
Patch Set #2, Line 243:
switches::kDisableExplicitDmaFences,
I'd rather not guard any DRM platform features or related code by OS_CHROMEOS unless truly necessary […]
Minor clarification, it's just the GPU internals that I'd like to be the same.
For chrome browser UI such as chrome://flags I think it's fine to use OS_CHROMEOS. So the patch seems correct as-is.
To view, visit change 1294300. To unsubscribe, or for help writing mail filters, visit settings.
Daniele Castagna (Gerrit)
Patch set 3:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Add histograms enum entry" https://chromium-review.googlesource.com/c/1294300/3
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1294300/3
Bot data: {"action": "start", "triggered_at": "2018-10-23T00:10:33.0Z", "cq_cfg_revision": "b62fa55343ae752de4c938affba0490094dda6c4", "revision": "6e2f9b7b05d8a02d2487cb58fc4653e14d59cf41"}
Daniele Castagna (Gerrit)
1 comment:
Patch Set #2, Line 243:
switches::kDisableExplicitDmaFences,
Minor clarification, it's just the GPU internals that I'd like to be the same. […]
Michael, thank you for answering kbr question.
Would you mind giving a +1 to this patch if you're ok with it since I need an owner for ui/ozone/*?
To view, visit change 1294300. To unsubscribe, or for help writing mail filters, visit settings.
Commit Bot (Gerrit)
Try jobs failed on following builders:
chromium_presubmit on luci.chromium.try (JOB_FAILED, https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit/260962)
Daniele Castagna (Gerrit)
Moving spang to reviewers for owners approval.
Michael Spang (Gerrit)
Patch set 3:Code-Review +1
Daniele Castagna (Gerrit)
Commit Bot (Gerrit)
Commit Bot merged this change.
drm: Add flag to disable explicit dma fences
On Eve, Nocturne and Soraka we noticed some glitches that look like we're
scanning out a buffer while it's being composited.
This patch adds an about://flags to disable explicit dma fences, in this
way we can try to see if those glitches are still presen when using
implicit fences instead of explicit ones.
Bug: 889530
Change-Id: I34c79a65ba0691ccd442e5c30f49b05394398a42
Reviewed-on: https://chromium-review.googlesource.com/c/1294300
Reviewed-by: Michael Spang <sp...@chromium.org>
Reviewed-by: Kenneth Russell <k...@chromium.org>
Commit-Queue: Daniele Castagna <dcas...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601979}
---
M chrome/browser/about_flags.cc
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M content/browser/gpu/gpu_process_host.cc
M tools/metrics/histograms/enums.xml
M ui/ozone/platform/drm/gpu/drm_window_proxy.cc
M ui/ozone/public/ozone_switches.cc
M ui/ozone/public/ozone_switches.h
8 files changed, 23 insertions(+), 1 deletion(-)