[base] Rename Pickle::WithData() to emphasize copying [chromium/src : main]

0 views

Skip to first unread message

Mikel Astiz (Gerrit)

unread,

Jan 30, 2026, 4:27:01 AM (3 days ago) Jan 30

to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, alexmo...@chromium.org, bnc+...@chromium.org, creis...@chromium.org, dcheng+c...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, navigation...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Mikel Astiz added 2 comments

Patchset-level comments

File-level comment, Patchset 1:

Daniel Cheng . resolved

TBH I'm kind of fine with the existing name too. In my mind, `Pickle::WithData()` and `PickleIterator:WithData()` are both pretty clear, since Pickle is owning and PickleIterator is non-owning.
So the exceptional case is already called out (Pickle::With*Unowned*Buffer).
But if you want, I'm not really against this, though I don't love the current name. Maybe `Pickle::WithCopyOf()` or something instead would be better (from my perspective).
Whether or not we choose to rename, I think it's probably also worth throwing a `LIFETIME_BOUND` attribute on `WithUnownedBuffer()` even in the short-term.

Mikel Astiz

Given the feedback above, I will abandon this rename. Thanks!

We should discuss `LIFETIME_BOUND` separately because honestly I don't know how it can be used with spans (which are copied by value).

Commit Message

Line 7, Patchset 1:[base] Rename Pickle::ForData() to emphasize copying

Daniel Cheng . resolved

WithData

Mikel Astiz

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Mikel Astiz (Gerrit)

unread,

Jan 30, 2026, 4:27:23 AM (3 days ago) Jan 30

Mikel Astiz abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages