[Wayland] Use PQ/HLG TF instead of Gamma 2.2 for HDR color spaces [chromium/src : main]

0 views
Skip to first unread message

Thomas Anderson (Gerrit)

unread,
Nov 3, 2025, 3:09:34 PM (3 days ago) Nov 3
to Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge

Thomas Anderson voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If10548e32b01ef702b89291182e6bda77eb096ac
Gerrit-Change-Number: 7113881
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Mon, 03 Nov 2025 20:09:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
Nov 4, 2025, 4:37:50 PM (2 days ago) Nov 4
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kramer Ge . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If10548e32b01ef702b89291182e6bda77eb096ac
    Gerrit-Change-Number: 7113881
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 21:37:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Thomas Anderson (Gerrit)

    unread,
    Nov 4, 2025, 5:08:21 PM (2 days ago) Nov 4
    to Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

    Thomas Anderson voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If10548e32b01ef702b89291182e6bda77eb096ac
    Gerrit-Change-Number: 7113881
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 22:08:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Nov 4, 2025, 6:41:25 PM (2 days ago) Nov 4
    to Thomas Anderson, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [Wayland] Use PQ/HLG TF instead of Gamma 2.2 for HDR color spaces

    * If the compositor reports HDR headroom but suggests a TF of gamma
    2.2, fallback to an HDR TF like PQ or HLG. This is required because
    gfx::ColorSpace::IsHDR() will return false for gamma 2.2.
    gfx::ColorSpace::GetAsHDR() cannot always be used because that sets
    a custom TF, which is not supported by any compositors.
    * Call wp_image_description_creator_params_v1_set_luminances for HDR
    content. This is required for correct compositor tonemapping.
    * Remove WaylandWpImageDescription::color_space() and
    WaylandWpImageDescription::hdr_metadata(). These were never used.
    * Properly report output reference luminance and headroom.

    R=fangzhoug
    Fixed: 446254087
    Change-Id: If10548e32b01ef702b89291182e6bda77eb096ac
    Reviewed-by: Kramer Ge <fang...@chromium.org>
    Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1540360}
    Files:
    • M ui/ozone/platform/wayland/host/wayland_wp_color_manager.cc
    • M ui/ozone/platform/wayland/host/wayland_wp_image_description.cc
    • M ui/ozone/platform/wayland/host/wayland_wp_image_description.h
    Change size: M
    Delta: 3 files changed, 168 insertions(+), 78 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kramer Ge
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If10548e32b01ef702b89291182e6bda77eb096ac
    Gerrit-Change-Number: 7113881
    Gerrit-PatchSet: 4
    Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages