Remove SWAP_NON_SIMPLE_OVERLAYS_FAILED [chromium/src : main]
0 views
Skip to first unread message
Jonathan Ross (Gerrit)
Jan 7, 2026, 3:18:27 PM (4 days ago) Jan 7
to Colin Blundell, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Colin Blundell
Jonathan Ross added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jonathan Ross . resolved
+blundell as owner of ui/* third CL in a chain to remove a disabled-by-default feature. This change removes an enum value that it added, and was not used outside the feature. Could you PTAL? Thanks!
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 8, 2026, 3:24:00 AM (4 days ago) Jan 8
to Jonathan Ross, Colin Blundell, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Jonathan Ross
Colin Blundell voted and added 3 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
3 comments
Patchset-level comments
Colin Blundell . resolved
Thanks!
File components/viz/service/display/display.cc
Line 1307, Patchset 1 (Latest):
// Both cases require full damage. That is, if buffers are recreated orColin Blundell . unresolved
nit: update comment
File components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
Line 2491, Patchset 1 (Latest):
// 2) If non-simple overlays failed, full damage is expected as the frame isColin Blundell . unresolved
nit: update comment
Related details
Attention is currently required from:
- Jonathan Ross
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonathan Ross (Gerrit)
Jan 8, 2026, 1:44:13 PM (3 days ago) Jan 8
to Colin Blundell, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Jonathan Ross added 2 comments![]( "Open in Gerrit")
File components/viz/service/display/display.cc
Line 1307, Patchset 1:
// Both cases require full damage. That is, if buffers are recreated orColin Blundell . resolved
Jonathan Rossnit: update comment
Done
File components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
Line 2491, Patchset 1:
// 2) If non-simple overlays failed, full damage is expected as the frame isColin Blundell . resolved
Jonathan Rossnit: update comment
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonathan Ross (Gerrit)
Jan 8, 2026, 1:45:07 PM (3 days ago) Jan 8
to Chromium IPC Reviews, Colin Blundell, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Chromium IPC Reviews
Jonathan Ross added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Jonathan Ross . resolved
+chrome-ip...@google.com for ui/gfx/mojom as we are removing an entry in an enum
Related details
Attention is currently required from:
- Chromium IPC Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Jan 8, 2026, 1:51:00 PM (3 days ago) Jan 8
to Jonathan Ross, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Colin Blundell, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Giovanni Ortuno Urquidi
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ort...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ort...@chromium.org
Reviewer source(s):
ort...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Giovanni Ortuno Urquidi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Ortuno Urquidi (Gerrit)
Jan 8, 2026, 1:55:29 PM (3 days ago) Jan 8
to Jonathan Ross, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Colin Blundell, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Jonathan Ross
Giovanni Ortuno Urquidi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Giovanni Ortuno Urquidi
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jonathan Ross
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonathan Ross (Gerrit)
Jan 8, 2026, 1:59:57 PM (3 days ago) Jan 8
to Giovanni Ortuno Urquidi, Chromium IPC Reviews, Colin Blundell, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Jonathan Ross voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonathan Ross (Gerrit)
Jan 9, 2026, 10:54:51 AM (2 days ago) Jan 9
to Chromium LUCI CQ, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Colin Blundell, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Jonathan Ross voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 11:57:53 AM (2 days ago) Jan 9
to Jonathan Ross, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Colin Blundell, chromium...@chromium.org, cc-...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove SWAP_NON_SIMPLE_OVERLAYS_FAILED
This was only used by SetNotifyNonSimpleOverlayFailure tied to
kHandleOverlaysSwapFailure which did not ship. This removes the enum
after removing the usage.
Bug: 379691125
Change-Id: Ifacf89149ca22a5fe218a45eff8bc0dd6bbe8fd5
Reviewed-by: Colin Blundell <blun...@chromium.org>
Reviewed-by: Giovanni Ortuno Urquidi <ort...@chromium.org>
Commit-Queue: Jonathan Ross <jon...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566978}
Files:
- M components/viz/service/display/display.cc
- M components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
- M ui/gfx/mojom/swap_result.mojom
- M ui/gfx/mojom/swap_result_mojom_traits.h
- M ui/gfx/swap_result.h
- M ui/gl/dcomp_presenter_unittest.cc
- M ui/ozone/demo/skia/skia_surfaceless_gl_renderer.cc
- M ui/ozone/demo/surfaceless_gl_renderer.cc
Change size: S
Delta: 8 files changed, 5 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell, +1 by Giovanni Ortuno Urquidi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages