[M144-LTS][Ozone/X11] Guard against synchronous deletion in OnWindowMapped [chromium/src : refs/branch-heads/7559]
1 view
Skip to first unread message
Gyuyoung Kim (xWF) (Gerrit)
Jul 30, 2026, 10:17:59 PM (13 days ago) Jul 30
to Thomas Anderson, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Gyuyoung Kim (xWF)
Gyuyoung Kim (xWF) removed a vote from this change![]( "Open in Gerrit")
Removed Lint-1 by android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>
Related details
Attention is currently required from:
- Gyuyoung Kim (xWF)
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Aug 6, 2026, 9:33:51 PM (6 days ago) Aug 6
to Thomas Anderson, Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Artem Sumaneev, Lei Zhang and Thomas Anderson
Gyuyoung Kim (xWF) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Gyuyoung Kim (xWF) . resolved
The bug was approved for M144 LTS. PTAL.
Related details
Attention is currently required from:
- Artem Sumaneev
- Lei Zhang
- Thomas Anderson
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Aug 6, 2026, 9:36:23 PM (6 days ago) Aug 6
to Gyuyoung Kim (xWF), Thomas Anderson, Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Artem Sumaneev, Gyuyoung Kim (xWF) and Thomas Anderson
Lei Zhang added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/x11/x11_window_ozone_unittest.cc
Line 485, Patchset 3 (Latest):
}Lei Zhang . unresolved
Is there a missing `connection->DestroyWindow({new_parent});` call here?
Related details
Attention is currently required from:
- Artem Sumaneev
- Gyuyoung Kim (xWF)
- Thomas Anderson
Submit Requirements:
Code-Owners
Code-Review
Lint
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Aug 9, 2026, 10:30:39 PM (3 days ago) Aug 9
to Thomas Anderson, Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Artem Sumaneev, Lei Zhang and Thomas Anderson
Gyuyoung Kim (xWF) added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/x11/x11_window_ozone_unittest.cc
Is there a missing `connection->DestroyWindow({new_parent});` call here?
Gyuyoung Kim (xWF)
Thank you for catching it! It looks like I missed it while I cherry-picked this CL.
Related details
Attention is currently required from:
- Artem Sumaneev
- Lei Zhang
- Thomas Anderson
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Artem Sumaneev (Gerrit)
Aug 10, 2026, 5:07:54 AM (3 days ago) Aug 10
to Gyuyoung Kim (xWF), Thomas Anderson, Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Gyuyoung Kim (xWF), Lei Zhang and Thomas Anderson
Artem Sumaneev voted and added 1 comment![]( "Open in Gerrit")
Votes added by Artem Sumaneev
| Code-Review | +1 |
| Owners-Override | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Gyuyoung Kim (xWF)
- Lei Zhang
- Thomas Anderson
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Aug 10, 2026, 12:18:29 PM (3 days ago) Aug 10
to Gyuyoung Kim (xWF), Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Gyuyoung Kim (xWF) and Lei Zhang
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Gyuyoung Kim (xWF)
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Aug 10, 2026, 8:24:44 PM (2 days ago) Aug 10
to Thomas Anderson, Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Lei Zhang
Gyuyoung Kim (xWF) voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 10, 2026, 9:14:56 PM (2 days ago) Aug 10
to Thomas Anderson, Gyuyoung Kim (xWF), Lei Zhang, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M144-LTS][Ozone/X11] Guard against synchronous deletion in OnWindowMapped
Maximize() may synchronously delete X11Window via OnBoundsChanged bounds
changes notifications. MapNotify dispatch path (which routes to
OnWindowMapped()) is not covered by the standard EventDispatcher
weak_this guard, leading to a UAF upon stack unwinding.
This CL introduces a weak_this guard in X11Window::OnWindowMapped() to
safely abort execution if the window is synchronously deleted.
(cherry picked from commit 6674e8db67016bbed31d9491e5caa47ba3e4fc5a)
Fixed: 517050585
Change-Id: I3ab1ae86cc0c16d08c359d18076c6815ef6fb061
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1637736}
Owners-Override: Artem Sumaneev <asum...@google.com>
Reviewed-by: Artem Sumaneev <asum...@google.com>
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Commit-Queue: Gyuyoung Kim (xWF) <qk...@google.com>
Cr-Commit-Position: refs/branch-heads/7559@{#5238}
Cr-Branched-From: 223dfbac1c7542a06b422390d954afe5b560b607-refs/heads/main@{#1552494}
Files:
- M ui/ozone/platform/x11/x11_window.cc
- M ui/ozone/platform/x11/x11_window_ozone_unittest.cc
Change size: M
Delta: 2 files changed, 106 insertions(+), 0 deletions(-)
Branch: refs/branch-heads/7559
Submit Requirements:
Code-Review: +1 by Thomas Anderson, +1 by Artem Sumaneev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages