Disable flaky XdgActivationTest.RequestNewToken on Linux ASan/TSan [chromium/src : main]

0 views
Skip to first unread message

Olga Gerchikov (Gerrit)

unread,
Dec 15, 2025, 2:28:49 PM (7 days ago) Dec 15
to Eain Chen, Chromium LUCI CQ, Claire Chambers, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Claire Chambers and Eain Chen

Olga Gerchikov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Claire Chambers
  • Eain Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5445d889588828238a656a8721ba7e0e951b51cf
Gerrit-Change-Number: 7243898
Gerrit-PatchSet: 3
Gerrit-Owner: Eain Chen <eain...@microsoft.com>
Gerrit-Reviewer: Claire Chambers <clcha...@microsoft.com>
Gerrit-Reviewer: Eain Chen <eain...@microsoft.com>
Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Eain Chen <eain...@microsoft.com>
Gerrit-Attention: Claire Chambers <clcha...@microsoft.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 19:28:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Eain Chen (Gerrit)

unread,
Dec 15, 2025, 4:47:26 PM (6 days ago) Dec 15
to Eliot Courtney, Mitsuru Oshima, Olga Gerchikov, Chromium LUCI CQ, Claire Chambers, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Claire Chambers and Eliot Courtney

Eain Chen added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Eain Chen . resolved

Hello Eliot, could you please review this change when possible? I find you might be the owner of this folder, thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Claire Chambers
  • Eliot Courtney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5445d889588828238a656a8721ba7e0e951b51cf
Gerrit-Change-Number: 7243898
Gerrit-PatchSet: 3
Gerrit-Owner: Eain Chen <eain...@microsoft.com>
Gerrit-Reviewer: Claire Chambers <clcha...@microsoft.com>
Gerrit-Reviewer: Eain Chen <eain...@microsoft.com>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Claire Chambers <clcha...@microsoft.com>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 21:47:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Dec 19, 2025, 5:37:25 PM (2 days ago) Dec 19
to Eain Chen, AbdAlRahman Gad, Maksim Sisov, Eliot Courtney, Olga Gerchikov, Chromium LUCI CQ, Claire Chambers, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Claire Chambers, Eain Chen and Eliot Courtney

Mitsuru Oshima voted and added 2 comments

Votes added by Mitsuru Oshima

Code-Review+1

2 comments

Patchset-level comments
Mitsuru Oshima . resolved

FYI a few igalia folks. lgtm % a nit

File ui/ozone/platform/wayland/host/xdg_activation_unittest.cc
Line 43, Patchset 3 (Latest):// TODO(crbug/454227184): Flaky in general, mostly under linux_chromium_tsan_rel_ng.
Mitsuru Oshima . unresolved

Please fix this WARNING reported by No short links in OSS: Do not use crbug/<number> in OSS code. Use crbug.com/<number> instead; see https...

Do not use crbug/<number> in OSS code. Use crbug.com/<number> instead; see https://www.chromium.org/issue-tracking/googler-guidelines/.

Open in Gerrit

Related details

Attention is currently required from:
  • Claire Chambers
  • Eain Chen
  • Eliot Courtney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5445d889588828238a656a8721ba7e0e951b51cf
Gerrit-Change-Number: 7243898
Gerrit-PatchSet: 3
Gerrit-Owner: Eain Chen <eain...@microsoft.com>
Gerrit-Reviewer: Claire Chambers <clcha...@microsoft.com>
Gerrit-Reviewer: Eain Chen <eain...@microsoft.com>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: AbdAlRahman Gad <abdo...@chromium.org>
Gerrit-CC: Maksim Sisov <msi...@igalia.com>
Gerrit-CC: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Attention: Eain Chen <eain...@microsoft.com>
Gerrit-Attention: Claire Chambers <clcha...@microsoft.com>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 22:37:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Eain Chen (Gerrit)

unread,
Dec 19, 2025, 5:54:21 PM (2 days ago) Dec 19
to Mitsuru Oshima, AbdAlRahman Gad, Maksim Sisov, Eliot Courtney, Olga Gerchikov, Chromium LUCI CQ, Claire Chambers, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Claire Chambers, Eliot Courtney, Mitsuru Oshima and Olga Gerchikov

Eain Chen added 1 comment

File ui/ozone/platform/wayland/host/xdg_activation_unittest.cc
Line 43, Patchset 3:// TODO(crbug/454227184): Flaky in general, mostly under linux_chromium_tsan_rel_ng.
Mitsuru Oshima . resolved

Please fix this WARNING reported by No short links in OSS: Do not use crbug/<number> in OSS code. Use crbug.com/<number> instead; see https...

Do not use crbug/<number> in OSS code. Use crbug.com/<number> instead; see https://www.chromium.org/issue-tracking/googler-guidelines/.

Eain Chen

Thank you. The link format has been changed.

Open in Gerrit

Related details

Attention is currently required from:
  • Claire Chambers
  • Eliot Courtney
  • Mitsuru Oshima
  • Olga Gerchikov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5445d889588828238a656a8721ba7e0e951b51cf
    Gerrit-Change-Number: 7243898
    Gerrit-PatchSet: 4
    Gerrit-Owner: Eain Chen <eain...@microsoft.com>
    Gerrit-Reviewer: Claire Chambers <clcha...@microsoft.com>
    Gerrit-Reviewer: Eain Chen <eain...@microsoft.com>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: AbdAlRahman Gad <abdo...@chromium.org>
    Gerrit-CC: Maksim Sisov <msi...@igalia.com>
    Gerrit-CC: Max Ihlenfeldt <m...@igalia.com>
    Gerrit-Attention: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Claire Chambers <clcha...@microsoft.com>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 22:54:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mitsuru Oshima (Gerrit)

    unread,
    Dec 19, 2025, 6:27:43 PM (2 days ago) Dec 19
    to Eain Chen, AbdAlRahman Gad, Maksim Sisov, Eliot Courtney, Olga Gerchikov, Chromium LUCI CQ, Claire Chambers, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
    Attention needed from Claire Chambers, Eain Chen, Eliot Courtney and Olga Gerchikov

    Mitsuru Oshima voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Claire Chambers
    • Eain Chen
    • Eliot Courtney
    • Olga Gerchikov
    Gerrit-Attention: Eain Chen <eain...@microsoft.com>
    Gerrit-Attention: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Claire Chambers <clcha...@microsoft.com>
    Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 23:27:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Claire Chambers (Gerrit)

    unread,
    Dec 19, 2025, 7:02:44 PM (2 days ago) Dec 19
    to Eain Chen, Mitsuru Oshima, AbdAlRahman Gad, Maksim Sisov, Eliot Courtney, Olga Gerchikov, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
    Attention needed from Eain Chen, Eliot Courtney and Olga Gerchikov

    Claire Chambers voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eain Chen
    • Eliot Courtney
    • Olga Gerchikov
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I5445d889588828238a656a8721ba7e0e951b51cf
      Gerrit-Change-Number: 7243898
      Gerrit-PatchSet: 4
      Gerrit-Owner: Eain Chen <eain...@microsoft.com>
      Gerrit-Reviewer: Claire Chambers <clcha...@microsoft.com>
      Gerrit-Reviewer: Eain Chen <eain...@microsoft.com>
      Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: AbdAlRahman Gad <abdo...@chromium.org>
      Gerrit-CC: Maksim Sisov <msi...@igalia.com>
      Gerrit-CC: Max Ihlenfeldt <m...@igalia.com>
      Gerrit-Attention: Eain Chen <eain...@microsoft.com>
      Gerrit-Attention: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
      Gerrit-Comment-Date: Sat, 20 Dec 2025 00:02:32 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Eain Chen (Gerrit)

      unread,
      Dec 19, 2025, 7:12:35 PM (2 days ago) Dec 19
      to Claire Chambers, Mitsuru Oshima, AbdAlRahman Gad, Maksim Sisov, Eliot Courtney, Olga Gerchikov, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
      Attention needed from Eliot Courtney and Olga Gerchikov

      Eain Chen voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Eliot Courtney
      • Olga Gerchikov
      Gerrit-Attention: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
      Gerrit-Comment-Date: Sat, 20 Dec 2025 00:12:22 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Dec 19, 2025, 7:16:41 PM (2 days ago) Dec 19
      to Eain Chen, Claire Chambers, Mitsuru Oshima, AbdAlRahman Gad, Maksim Sisov, Eliot Courtney, Olga Gerchikov, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Disable flaky XdgActivationTest.RequestNewToken on Linux ASan/TSan

      This CL disables XdgActivationTest.RequestNewToken on Linux when built
      with AddressSanitizer (ASan) or ThreadSanitizer (TSan).

      We've experienced the flakiness on our ASan configurations.
      Additionally, TSan flakiness has been observed to be high on LUCI. We
      should disable them while further investigation is undertaken.

      https://ci.chromium.org/ui/test/chromium/%3A%2F%2Fui%2Fozone%5C%3Aozone_unittests!gtest%3A%3AXdgActivationTest%23RequestNewToken?redirected=true
      Bug: 454227184
      Change-Id: I5445d889588828238a656a8721ba7e0e951b51cf
      Reviewed-by: Mitsuru Oshima <osh...@chromium.org>
      Reviewed-by: Claire Chambers <clcha...@microsoft.com>
      Commit-Queue: Eain Chen <eain...@microsoft.com>
      Cr-Commit-Position: refs/heads/main@{#1561440}
      Files:
      • M ui/ozone/platform/wayland/host/xdg_activation_unittest.cc
      Change size: S
      Delta: 1 file changed, 11 insertions(+), 1 deletion(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Mitsuru Oshima, +1 by Claire Chambers
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I5445d889588828238a656a8721ba7e0e951b51cf
      Gerrit-Change-Number: 7243898
      Gerrit-PatchSet: 5
      Gerrit-Owner: Eain Chen <eain...@microsoft.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Claire Chambers <clcha...@microsoft.com>
      Gerrit-Reviewer: Eain Chen <eain...@microsoft.com>
      Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: AbdAlRahman Gad <abdo...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages