[ozone/wayland] Add ExtractData() support for text/uri-list [chromium/src : main]
0 views
Skip to first unread message
Łukasz Patron (Gerrit)
Nov 12, 2025, 2:36:37 AMNov 12
to AyeAye, Chromium LUCI CQ, Antonio Gomes, Maksim Sisov, Hidehiko Abe, Orko Garai, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Łukasz Patron abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Nov 12, 2025, 11:50:15 AMNov 12
to Łukasz Patron, AyeAye, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Maksim Sisov, Max Ihlenfeldt, Orko Garai and Łukasz Patron
Hidehiko Abe added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Commit Message
Line 17, Patchset 1 (Latest):
Change-Id: Iab0144ca7d3d3983d0e61d74f42a53b366f9e830Hidehiko Abe . unresolved
could you add tracking bug?
Related details
Attention is currently required from:
- Antonio Gomes
- Maksim Sisov
- Max Ihlenfeldt
- Orko Garai
- Łukasz Patron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Patron (Gerrit)
Nov 12, 2025, 12:05:47 PMNov 12
to AyeAye, Hidehiko Abe, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Maksim Sisov, Max Ihlenfeldt and Orko Garai
Łukasz Patron voted and added 2 comments![]( "Open in Gerrit")
Votes added by Łukasz Patron
| Auto-Submit | +1 |
Hidehiko Abe . resolved
Could you add test?
Łukasz Patron
as first time external contributor I don't exactly feel like learning new test framework and I don't see any test that'd cover already supported kMimeTypeMozillaUrl MIME type where I could just add kMimeTypeUriList and be done with it.
Commit Message
could you add tracking bug?
Attention is currently required from:
- Antonio Gomes
- Hidehiko Abe
- Maksim Sisov
- Max Ihlenfeldt
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Nov 13, 2025, 12:10:44 PMNov 13
to Łukasz Patron, AyeAye, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Maksim Sisov, Max Ihlenfeldt, Orko Garai and Łukasz Patron
Hidehiko Abe added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Łukasz PatronCould you add test?
as first time external contributor I don't exactly feel like learning new test framework and I don't see any test that'd cover already supported kMimeTypeMozillaUrl MIME type where I could just add kMimeTypeUriList and be done with it.
Hidehiko Abe
as first time external contributor
this does not sound like any excuse to avoid testing.
At least, because you should have intention (user journey) this change fixes, could you add the test scenario in the way (i.e. some of the browser test covers your use cases), even if you do not want to build the basic unit_test testing from the scratch here?
If there's no existing test, it's unfortunate, but we as chromium developer should keep a good citizenship anyways.
Related details
Attention is currently required from:
- Antonio Gomes
- Maksim Sisov
- Max Ihlenfeldt
- Orko Garai
- Łukasz Patron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Nov 17, 2025, 2:11:00 PM (14 days ago) Nov 17
to Łukasz Patron, AyeAye, Hidehiko Abe, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Max Ihlenfeldt, Orko Garai and Łukasz Patron
Kramer Ge added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kramer Ge . resolved
Approach looks good to me, but test cases should be differentiated from picked data.
File ui/ozone/platform/wayland/host/wayland_exchange_data_provider_unittest.cc
Line 32, Patchset 4 (Latest):
TEST(WaylandExchangeDataProviderTest, ExtractPickledData) {
WaylandExchangeDataProvider provider;
std::string extracted;
EXPECT_FALSE(provider.ExtractData(kMimeTypePlainText, &extracted));
EXPECT_FALSE(provider.ExtractData(kMimeTypeUriList, &extracted));
EXPECT_FALSE(
provider.ExtractData(kMimeTypeDataTransferCustomData, &extracted));
extracted.clear();
provider.SetString(u"dnd-string");
EXPECT_TRUE(provider.ExtractData(kMimeTypePlainText, &extracted));
EXPECT_EQ("dnd-string", extracted);
extracted.clear();
provider.AddData(ToClipboardData("file:///dev/null"), kMimeTypeUriList);
EXPECT_TRUE(provider.ExtractData(kMimeTypeUriList, &extracted));
EXPECT_EQ("file:///dev/null", extracted);
extracted.clear();
base::Pickle pickle;
pickle.WriteString("pickled-str");
provider.SetPickledData(ClipboardFormatType::DataTransferCustomType(),
pickle);
EXPECT_TRUE(
provider.ExtractData(kMimeTypeDataTransferCustomData, &extracted));
// Ensure Pickle "reconstruction" works as expected.
std::string read_pickled_str;
base::Pickle read_pickle =
base::Pickle::WithData(base::as_byte_span(extracted));
base::PickleIterator iter(read_pickle);
ASSERT_TRUE(read_pickle.data());
EXPECT_FALSE(iter.ReachedEnd());
EXPECT_TRUE(iter.ReadString(&read_pickled_str));
EXPECT_EQ("pickled-str", read_pickled_str);
}Kramer Ge . unresolved
This test is testing for `WebCustomDataType`. Can you move the `kMimeTypeUriList` into a new test `FileNameAsUriList`?
```suggestion
TEST(WaylandExchangeDataProviderTest, ExtractPickledData) {
WaylandExchangeDataProvider provider;
std::string extracted;
EXPECT_FALSE(provider.ExtractData(kMimeTypePlainText, &extracted));
EXPECT_FALSE(provider.ExtractData(kMimeTypeUriList, &extracted));
EXPECT_FALSE(
provider.ExtractData(kMimeTypeDataTransferCustomData, &extracted));
extracted.clear();
provider.SetString(u"dnd-string");
EXPECT_TRUE(provider.ExtractData(kMimeTypePlainText, &extracted));
EXPECT_EQ("dnd-string", extracted);
extracted.clear();
base::Pickle pickle;
pickle.WriteString("pickled-str");
provider.SetPickledData(ClipboardFormatType::DataTransferCustomType(),
pickle);
EXPECT_TRUE(
provider.ExtractData(kMimeTypeDataTransferCustomData, &extracted));
// Ensure Pickle "reconstruction" works as expected.
std::string read_pickled_str;
base::Pickle read_pickle =
base::Pickle::WithData(base::as_byte_span(extracted));
base::PickleIterator iter(read_pickle);
ASSERT_TRUE(read_pickle.data());
EXPECT_FALSE(iter.ReachedEnd());
EXPECT_TRUE(iter.ReadString(&read_pickled_str));
EXPECT_EQ("pickled-str", read_pickled_str);
}
TEST(WaylandExchangeDataProviderTest, FileNameAsUriList) {
WaylandExchangeDataProvider provider;
std::string extracted;EXPECT_FALSE(provider.ExtractData(kMimeTypeUriList, &extracted));
EXPECT_FALSE(
provider.ExtractData(kMimeTypeDataTransferCustomData, &extracted));
extracted.clear();
provider.AddData(ToClipboardData("file:///dev/null"), kMimeTypeUriList);
EXPECT_TRUE(provider.ExtractData(kMimeTypeUriList, &extracted));
EXPECT_EQ("file:///dev/null", extracted);
extracted.clear();
}
```
Related details
Attention is currently required from:
- Antonio Gomes
- Max Ihlenfeldt
- Orko Garai
- Łukasz Patron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Patron (Gerrit)
Nov 17, 2025, 2:13:43 PM (14 days ago) Nov 17
to AyeAye, Hidehiko Abe, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Max Ihlenfeldt and Orko Garai
Łukasz Patron voted and added 1 comment![]( "Open in Gerrit")
Votes added by Łukasz Patron
| Auto-Submit | +1 |
1 comment
File ui/ozone/platform/wayland/host/wayland_exchange_data_provider_unittest.cc
Kramer Ge . resolved
Łukasz Patron
Fix applied.
Related details
Attention is currently required from:
- Antonio Gomes
- Max Ihlenfeldt
- Orko Garai
Łukasz Patron (Gerrit)
Nov 17, 2025, 2:14:36 PM (14 days ago) Nov 17
to AyeAye, Hidehiko Abe, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Max Ihlenfeldt and Orko Garai
Łukasz Patron voted and added 1 comment![]( "Open in Gerrit")
Votes added by Łukasz Patron
| Auto-Submit | +1 |
1 comment
File ui/ozone/platform/wayland/host/wayland_exchange_data_provider_unittest.cc
Line 37, Patchset 5 (Latest):
EXPECT_FALSE(provider.ExtractData(kMimeTypeUriList, &extracted));Łukasz Patron . unresolved
should i leave that?
Related details
Attention is currently required from:
- Antonio Gomes
- Max Ihlenfeldt
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Nov 17, 2025, 2:18:43 PM (14 days ago) Nov 17
to Łukasz Patron, AyeAye, Hidehiko Abe, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Max Ihlenfeldt, Orko Garai and Łukasz Patron
Kramer Ge added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/wayland/host/wayland_exchange_data_provider_unittest.cc
Line 37, Patchset 5 (Latest):
EXPECT_FALSE(provider.ExtractData(kMimeTypeUriList, &extracted));Łukasz Patron . unresolved
should i leave that?
Kramer Ge
You may delete this, I missed this part in my code suggest, sorry.
Related details
Attention is currently required from:
- Antonio Gomes
- Max Ihlenfeldt
- Orko Garai
- Łukasz Patron
Łukasz Patron (Gerrit)
Nov 17, 2025, 2:21:21 PM (14 days ago) Nov 17
to Kramer Ge, AyeAye, Hidehiko Abe, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Kramer Ge, Max Ihlenfeldt and Orko Garai
Łukasz Patron voted and added 1 comment![]( "Open in Gerrit")
Votes added by Łukasz Patron
| Auto-Submit | +1 |
1 comment
File ui/ozone/platform/wayland/host/wayland_exchange_data_provider_unittest.cc
Line 37, Patchset 5:
EXPECT_FALSE(provider.ExtractData(kMimeTypeUriList, &extracted));Łukasz Patron . resolved
Kramer Geshould i leave that?
You may delete this, I missed this part in my code suggest, sorry.
Attention is currently required from:
- Antonio Gomes
- Kramer Ge
- Max Ihlenfeldt
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Nov 17, 2025, 2:30:57 PM (14 days ago) Nov 17
to Łukasz Patron, AyeAye, Hidehiko Abe, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Max Ihlenfeldt, Orko Garai and Łukasz Patron
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Łukasz Patron
Hidehiko Abeas first time external contributor I don't exactly feel like learning new test framework and I don't see any test that'd cover already supported kMimeTypeMozillaUrl MIME type where I could just add kMimeTypeUriList and be done with it.
as first time external contributor
this does not sound like any excuse to avoid testing.
At least, because you should have intention (user journey) this change fixes, could you add the test scenario in the way (i.e. some of the browser test covers your use cases), even if you do not want to build the basic unit_test testing from the scratch here?
If there's no existing test, it's unfortunate, but we as chromium developer should keep a good citizenship anyways.
Attention is currently required from:
- Antonio Gomes
- Hidehiko Abe
- Max Ihlenfeldt
- Orko Garai
- Łukasz Patron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Nov 17, 2025, 2:40:37 PM (14 days ago) Nov 17
to Łukasz Patron, Chromium LUCI CQ, AyeAye, Hidehiko Abe, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Max Ihlenfeldt, Orko Garai and Łukasz Patron
Kramer Ge added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Kramer Ge . unresolved
b/c I'm an uploader now it's missing a second pair of eyes, I think.
Related details
Attention is currently required from:
- Antonio Gomes
- Hidehiko Abe
- Max Ihlenfeldt
- Orko Garai
- Łukasz Patron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Patron (Gerrit)
Nov 17, 2025, 2:47:44 PM (14 days ago) Nov 17
to Kramer Ge, Chromium LUCI CQ, AyeAye, Hidehiko Abe, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Kramer Ge, Max Ihlenfeldt and Orko Garai
Łukasz Patron voted and added 1 comment![]( "Open in Gerrit")
Votes added by Łukasz Patron
| Auto-Submit | +1 |
Kramer Ge . unresolved
b/c I'm an uploader now it's missing a second pair of eyes, I think.
Attention is currently required from:
- Antonio Gomes
- Hidehiko Abe
- Kramer Ge
- Max Ihlenfeldt
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Patron (Gerrit)
Nov 17, 2025, 2:48:58 PM (14 days ago) Nov 17
to Chromium LUCI CQ, Kramer Ge, AyeAye, Hidehiko Abe, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Kramer Ge, Max Ihlenfeldt and Orko Garai
Łukasz Patron voted and added 1 comment![]( "Open in Gerrit")
Votes added by Łukasz Patron
| Auto-Submit | +1 |
Łukasz Patronb/c I'm an uploader now it's missing a second pair of eyes, I think.
pushed --amend with no edit, maybe that's enough?
Łukasz Patron
seems like `Review-Enforcement` is still not satisfied, someone else must also CR+1
Related details
Attention is currently required from:
- Antonio Gomes
- Hidehiko Abe
- Kramer Ge
- Max Ihlenfeldt
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Nov 17, 2025, 2:55:31 PM (14 days ago) Nov 17
to Łukasz Patron, Chromium LUCI CQ, AyeAye, Hidehiko Abe, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Max Ihlenfeldt and Orko Garai
Kramer Ge voted![]( "Open in Gerrit")
Attention is currently required from:
- Antonio Gomes
- Hidehiko Abe
- Max Ihlenfeldt
- Orko Garai
Hidehiko Abe (Gerrit)
Nov 18, 2025, 1:29:27 AM (13 days ago) Nov 18
to Łukasz Patron, Kramer Ge, Chromium LUCI CQ, AyeAye, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Kramer Ge, Max Ihlenfeldt, Orko Garai and Łukasz Patron
Hidehiko Abe voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Gomes
- Kramer Ge
- Max Ihlenfeldt
- Orko Garai
- Łukasz Patron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Patron (Gerrit)
Nov 18, 2025, 2:57:13 AM (13 days ago) Nov 18
to Hidehiko Abe, Kramer Ge, Chromium LUCI CQ, AyeAye, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Kramer Ge, Max Ihlenfeldt and Orko Garai
Łukasz Patron voted and added 1 comment![]( "Open in Gerrit")
Votes added by Łukasz Patron
| Auto-Submit | +1 |
Attention is currently required from:
- Antonio Gomes
- Hidehiko Abe
- Kramer Ge
- Max Ihlenfeldt
- Orko Garai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Nov 18, 2025, 11:35:01 AM (13 days ago) Nov 18
to Łukasz Patron, Hidehiko Abe, Chromium LUCI CQ, AyeAye, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Max Ihlenfeldt, Orko Garai and Łukasz Patron
Kramer Ge voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Antonio Gomes
- Hidehiko Abe
- Max Ihlenfeldt
- Orko Garai
- Łukasz Patron
Peter McNeeley (Gerrit)
Nov 18, 2025, 1:40:29 PM (13 days ago) Nov 18
to Łukasz Patron, Hidehiko Abe, Chromium LUCI CQ, AyeAye, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Max Ihlenfeldt, Orko Garai and Łukasz Patron
Peter McNeeley voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Antonio Gomes
- Hidehiko Abe
- Max Ihlenfeldt
- Orko Garai
- Łukasz Patron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Patron (Gerrit)
Nov 18, 2025, 1:44:01 PM (13 days ago) Nov 18
to Peter McNeeley, Hidehiko Abe, Chromium LUCI CQ, AyeAye, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Max Ihlenfeldt and Orko Garai
Łukasz Patron voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Antonio Gomes
- Hidehiko Abe
- Max Ihlenfeldt
- Orko Garai
Łukasz Patron (Gerrit)
Nov 20, 2025, 3:45:59 PM (11 days ago) Nov 20
to Peter McNeeley, Hidehiko Abe, Chromium LUCI CQ, AyeAye, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Max Ihlenfeldt and Orko Garai
Łukasz Patron added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Łukasz Patron . resolved
can someone cq?
Peter McNeeley (Gerrit)
Nov 20, 2025, 4:31:47 PM (11 days ago) Nov 20
to Łukasz Patron, Hidehiko Abe, Chromium LUCI CQ, AyeAye, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Antonio Gomes, Hidehiko Abe, Max Ihlenfeldt, Orko Garai and Łukasz Patron
Peter McNeeley voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Antonio Gomes
- Hidehiko Abe
- Max Ihlenfeldt
- Orko Garai
- Łukasz Patron
Chromium LUCI CQ (Gerrit)
Nov 20, 2025, 5:28:09 PM (11 days ago) Nov 20
to Łukasz Patron, Peter McNeeley, Kramer Ge, Hidehiko Abe, AyeAye, Antonio Gomes, Orko Garai, Maksim Sisov, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ozone/wayland] Add ExtractData() support for text/uri-list
When dragging a file from chrome://downloads to KDE Konsole, the
following message shows up in the debug output: "Cannot deliver data of
type text/uri-list and no text representation is available.".
After making it so text/uri-list is handled the same way as
text/x-moz-url, the log message is gone and path to file is pasted into
terminal as one would expect.
Bug: 460074619
Test: ozone_unittests
Change-Id: Iab0144ca7d3d3983d0e61d74f42a53b366f9e830
Auto-Submit: Łukasz Patron <priv...@gmail.com>
Reviewed-by: Kramer Ge <fang...@chromium.org>
Reviewed-by: Peter McNeeley <peterm...@google.com>
Commit-Queue: Peter McNeeley <peterm...@google.com>
Cr-Commit-Position: refs/heads/main@{#1548075}
Files:
- M AUTHORS
- M ui/ozone/platform/wayland/host/wayland_exchange_data_provider.cc
- M ui/ozone/platform/wayland/host/wayland_exchange_data_provider_unittest.cc
Change size: S
Delta: 3 files changed, 14 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Peter McNeeley, +1 by Kramer Ge
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages