[M148] Revert "[ozone/wayland]Treat xdg_toplevel::state::suspended as minimized" [chromium/src : refs/branch-heads/7778]

1 view
Skip to first unread message

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Apr 14, 2026, 12:47:19 PMApr 14
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, nickdiego+wa...@igalia.com, max+watc...@igalia.com, ozone-...@chromium.org

rubber-...@appspot.gserviceaccount.com voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7778
Gerrit-Change-Id: I753b0fd0b7b370ee172725e0dffa44a6d84d32de
Gerrit-Change-Number: 7760369
Gerrit-PatchSet: 2
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Tue, 14 Apr 2026 16:47:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Apr 14, 2026, 3:27:21 PMApr 14
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Kramer Ge, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, nickdiego+wa...@igalia.com, max+watc...@igalia.com, ozone-...@chromium.org

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[M148] Revert "[ozone/wayland]Treat xdg_toplevel::state::suspended as minimized"

Original change's description:
> Revert "[ozone/wayland]Treat xdg_toplevel::state::suspended as minimized"
>
> This reverts commit ac4eed7b549169cd64f0e15b503f4f0635dc1bd9.
>
> Reason for revert: causing crbug.com/501166026, crbug.com/501157180, crbug.com/501147572
>
> Original change's description:
> > [ozone/wayland]Treat xdg_toplevel::state::suspended as minimized
> >
> > minimized was a state used by chromium aura-shell extension for lacros,
> > it is now unreachable. Linux Wayland compositors (KDE and GNOME) send
> > xdg_toplevel::state::suspended when minimizing a window, use it to set
> > window state to minimized instead.
> >
> > R=thomasanderson
> >
> > Fixed: 459509272
> > Change-Id: If5cfbf3be52d72c09e8630ab56ce45a738ac7d67
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7625941
> > Commit-Queue: Kramer Ge <fang...@chromium.org>
> > Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1593405}
>
> Bug: 459509272, 501166026, 500659303, 501147572
> Change-Id: I753b0fd0b7b370ee172725e0dffa44a6d84d32de
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7757304
> Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
> Commit-Queue: Kramer Ge <fang...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1613945}

(cherry picked from commit 2cc049a108e7920f107c473374eceb42375ae825)
Bug: 502281918,459509272,501166026,500659303,501147572
Change-Id: I753b0fd0b7b370ee172725e0dffa44a6d84d32de
Cr-Commit-Position: refs/branch-heads/7778@{#599}
Cr-Branched-From: 77f495ee216d4c3cc784d33658bad4778c0680ee-refs/heads/main@{#1610480}
Files:
  • M ui/ozone/platform/wayland/host/wayland_toplevel_window.cc
  • M ui/ozone/platform/wayland/host/wayland_window.cc
  • M ui/ozone/platform/wayland/host/wayland_window.h
  • M ui/ozone/platform/wayland/host/wayland_window_unittest.cc
Change size: XS
Delta: 4 files changed, 6 insertions(+), 2 deletions(-)
Branch: refs/branch-heads/7778
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7778
Gerrit-Change-Id: I753b0fd0b7b370ee172725e0dffa44a6d84d32de
Gerrit-Change-Number: 7760369
Gerrit-PatchSet: 3
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages