[Wayland] Ensure popup bounds are relative to parent window geometry [chromium/src : main]
0 views
Skip to first unread message
Keren Zhu (Gerrit)
Aug 5, 2026, 1:39:18 AM (8 days ago) Aug 5
to Thomas Anderson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, navigation...@chromium.org, alexmo...@chromium.org, creis...@chromium.org
Attention needed from Thomas Anderson
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Aug 5, 2026, 4:23:42 PM (8 days ago) Aug 5
to Keren Zhu, Mason Freed, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, navigation...@chromium.org, alexmo...@chromium.org, creis...@chromium.org
Attention needed from Keren Zhu
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Keren Zhu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keren Zhu (Gerrit)
Aug 5, 2026, 4:32:55 PM (8 days ago) Aug 5
to Thomas Anderson, Mason Freed, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, navigation...@chromium.org, alexmo...@chromium.org, creis...@chromium.org
Keren Zhu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Moshchuk (Gerrit)
Aug 5, 2026, 4:36:26 PM (8 days ago) Aug 5
to Keren Zhu, Thomas Anderson, Mason Freed, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, navigation...@chromium.org, alexmo...@chromium.org
Attention needed from Keren Zhu
Alex Moshchuk voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Moshchuk
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Keren Zhu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keren Zhu (Gerrit)
Aug 5, 2026, 4:37:38 PM (8 days ago) Aug 5
to Alex Moshchuk, Thomas Anderson, Mason Freed, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, navigation...@chromium.org, alexmo...@chromium.org
Keren Zhu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 5, 2026, 4:41:57 PM (8 days ago) Aug 5
to Keren Zhu, Alex Moshchuk, Thomas Anderson, Mason Freed, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, navigation...@chromium.org, alexmo...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Wayland] Ensure popup bounds are relative to parent window geometry
Update a few places in WaylandPopup to subtract
GetWindowGeometryOffsetInDIP() when translating popup bounds into parent
coordinates. This fixes misalignment and input routing issue in Blink's
Unbounded Elements popups.
Previously, the offset subtracting only occurred when an
OwnedWindowAnchor was provided [1]. If no anchor is provided,
XdgPopup::FillAnchorData() incorrectly calculates the anchor rect in the
parent's wl_surface coordinate space (containing the decoration area,
e.g. shadow or border). This conflicts with
WaylandPopup::HandlePopupConfigure() that assumes the bounds in window
geometry (no decoration area). As a result, unanchored popups were
incorrectly shifted by the parent window's decorated frame insets.
With this change, re-enable a few input routing tests in
UnboundedElementBrowserTest.
[1]
https://source.chromium.org/chromium/chromium/src/+/main:ui/ozone/platform/wayland/host/wayland_popup.cc;l=81-87;drc=87abcfa5b16b689587f94f40e6e7de88db11313a
Test: ozone_unittests --test_filter="*WaylandWindow*"
Test: content_browsertests --test_filter="*UnboundedElement*"
Fixed: 529023344
Bug: 523970924
Change-Id: Ia5c150a21d81026cc2e4d1b34e984c60e1685c6f
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Alex Moshchuk <ale...@chromium.org>
Commit-Queue: Keren Zhu <kere...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1674463}
Files:
- M content/browser/renderer_host/unbounded_element_browsertest.cc
- M ui/ozone/platform/wayland/host/wayland_popup.cc
Change size: S
Delta: 2 files changed, 6 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Moshchuk, +1 by Thomas Anderson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages