[M147] [XKB] Harden the layout name parser. [chromium/src : refs/branch-heads/7727]

[rubber-stamper@appspot.gserviceaccount.com (Gerrit)]

rubber-...@appspot.gserviceaccount.com voted

Bot-Commit	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Lint
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: refs/branch-heads/7727

Gerrit-Change-Id: I22864f9deb130a697da2c768a76fa63c8d9429fe

Gerrit-Change-Number: 7784432

Gerrit-PatchSet: 2

Gerrit-Owner: chrome-che...@chops-service-accounts.iam.gserviceaccount.com <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: chrome-che...@chops-service-accounts.iam.gserviceaccount.com <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Gerrit-CC: Mike West <mk...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-Comment-Date: Wed, 22 Apr 2026 01:02:09 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

[M147] [XKB] Harden the layout name parser.

Original change's description:
> [XKB] Harden the layout name parser.
>
> This CL adds validation to the input component layout name parser and
> the XKB layout name parser in order to ensure that they match reasonable
> expectations. Since they're used as filenames in `libxkbcommon`, this
> might prevent unexpected path traversal.
>
> Bug: 499130207
> Change-Id: I22864f9deb130a697da2c768a76fa63c8d9429fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7735525
> Commit-Queue: Mike West <mk...@chromium.org>
> Reviewed-by: Finnur Thorarinsson <fin...@chromium.org>
> Reviewed-by: Sean O'Brien <seob...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1612696}

(cherry picked from commit 73daddbbeb66872bfa5352783bd4422614b55eee)

Bug: 501628761,499130207

Change-Id: I22864f9deb130a697da2c768a76fa63c8d9429fe

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7784432

Commit-Queue: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Auto-Submit: chrome-che...@chops-service-accounts.iam.gserviceaccount.com <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>

Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>

Cr-Commit-Position: refs/branch-heads/7727@{#3438}

Cr-Branched-From: ce01102937348db7b88c8a4257ee4b3ac702eb1a-refs/heads/main@{#1596535}

Files:

• M extensions/common/BUILD.gn
• M extensions/common/manifest_handlers/input_components_handler.cc
• A extensions/common/manifest_handlers/input_components_handler_unittest.cc
• M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
• M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc

Change size: M

Delta: 5 files changed, 143 insertions(+), 5 deletions(-)

Branch: refs/branch-heads/7727

Submit Requirements:

• Code-Review: Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: refs/branch-heads/7727

Gerrit-Change-Id: I22864f9deb130a697da2c768a76fa63c8d9429fe

Gerrit-Change-Number: 7784432

Gerrit-PatchSet: 3

Gerrit-Owner: chrome-che...@chops-service-accounts.iam.gserviceaccount.com <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>