Avi Drissman (Gerrit)

unread,

Jan 24, 2026, 6:01:13 PM (8 days ago) Jan 24

to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, abigailbk...@google.com, cros-print...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mac-r...@chromium.org, max+watc...@igalia.com, nektar...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, print-rev...@chromium.org, yuzo+...@chromium.org

Attention needed from Daniel Cheng

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Avi Drissman . resolved

dcheng: please review; this is strictly mechanical except where noted, so OO-ing is appropriate.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Jan 25, 2026, 3:00:31 PM (8 days ago) Jan 25

to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, abigailbk...@google.com, cros-print...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mac-r...@chromium.org, max+watc...@igalia.com, nektar...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, print-rev...@chromium.org, yuzo+...@chromium.org

Attention needed from Avi Drissman

Daniel Cheng voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 25, 2026, 4:26:23 PM (7 days ago) Jan 25

to Avi Drissman, Daniel Cheng, Akihiro Ota, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, abigailbk...@google.com, cros-print...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mac-r...@chromium.org, max+watc...@igalia.com, nektar...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, print-rev...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Use modern names for base::DictValue and base::ListValue

These classes were hoisted and renamed; switch all usage of these
classes to use the new names.

This is a strictly mechanical change.

Bug: 478100525

Change-Id: I5f05cccb6ccf77a2945518b868c958f059a99c22

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7509301

Auto-Submit: Avi Drissman <a...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1574274}

Files:

M ui/accessibility/platform/automation/automation_tree_manager_owner_unittest.cc
M ui/accessibility/platform/automation/automation_v8_bindings.cc
M ui/accessibility/platform/automation/automation_v8_router.h
M ui/accessibility/platform/ax_platform_node_win.cc
M ui/accessibility/platform/ax_platform_node_win_unittest.cc
M ui/accessibility/platform/inspect/ax_inspect_utils_unittest.cc
M ui/accessibility/platform/inspect/ax_transform_mac.h
M ui/accessibility/platform/inspect/ax_transform_mac.mm
M ui/accessibility/platform/inspect/ax_tree_formatter.cc
M ui/accessibility/platform/inspect/ax_tree_formatter.h
M ui/accessibility/platform/inspect/ax_tree_formatter_auralinux.cc
M ui/accessibility/platform/inspect/ax_tree_formatter_auralinux.h
M ui/accessibility/platform/inspect/ax_tree_formatter_base.cc
M ui/accessibility/platform/inspect/ax_tree_formatter_base.h
M ui/accessibility/platform/inspect/ax_tree_formatter_mac.h
M ui/accessibility/platform/inspect/ax_tree_formatter_mac.mm
M ui/accessibility/platform/inspect/ax_tree_formatter_uia_win.cc
M ui/accessibility/platform/inspect/ax_tree_formatter_uia_win.h
M ui/accessibility/platform/inspect/ax_tree_formatter_win.cc
M ui/accessibility/platform/inspect/ax_tree_formatter_win.h
M ui/aura/screen_ozone.cc
M ui/aura/screen_ozone.h
M ui/base/clipboard/scoped_clipboard_writer.cc
M ui/base/dragdrop/os_exchange_data_provider_win.cc
M ui/base/linux/linux_desktop.cc
M ui/base/linux/linux_desktop.h
M ui/base/template_expressions.cc
M ui/base/template_expressions.h
M ui/base/test/skia_gold_pixel_diff.cc
M ui/base/webui/jstemplate_builder.cc
M ui/base/webui/jstemplate_builder.h
M ui/base/webui/web_ui_util.cc
M ui/base/webui/web_ui_util.h
M ui/display/manager/json_converter.cc
M ui/display/manager/json_converter.h
M ui/display/manager/json_converter_unittest.cc
M ui/display/screen.cc
M ui/display/screen.h
M ui/display/util/gpu_info_util.cc
M ui/display/util/gpu_info_util.h
M ui/events/ozone/evdev/touch_filter/neural_stylus_palm_detection_filter.cc
M ui/gl/os_compositor_tree_base_unittest.cc
M ui/gtk/printing/print_dialog_gtk.cc
M ui/gtk/printing/printing_gtk_util.cc
M ui/native_theme/caption_style.cc
M ui/ozone/platform/drm/gpu/screen_manager.cc
M ui/ozone/platform/wayland/host/wayland_screen.cc
M ui/ozone/platform/wayland/host/wayland_screen.h
M ui/ozone/platform/x11/x11_screen_ozone.cc
M ui/ozone/platform/x11/x11_screen_ozone.h
M ui/ozone/public/platform_screen.cc
M ui/ozone/public/platform_screen.h
M ui/web_dialogs/web_dialog_ui.cc
M ui/web_dialogs/web_dialog_ui.h
M ui/webui/examples/browser/devtools/devtools_frontend.cc

Change size: L

Delta: 55 files changed, 382 insertions(+), 399 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Use modern names for base::DictValue and base::ListValue [chromium/src : main]

Avi Drissman (Gerrit)

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

1 comment

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information