Disable Fontations FontConfig indexing and disregard old caches [chromium/src : main]
0 views
Skip to first unread message
Dominik Röttsches (Gerrit)
Sep 5, 2025, 12:26:39 PM (2 days ago) Sep 5
to Ben Wagner, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Ben Wagner
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ben Wagner
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Wagner (Gerrit)
Sep 5, 2025, 12:49:49 PM (2 days ago) Sep 5
to Dominik Röttsches, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Dominik Röttsches
Ben Wagner voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Röttsches
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Wagner (Gerrit)
Sep 5, 2025, 12:52:30 PM (2 days ago) Sep 5
to Dominik Röttsches, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Dominik Röttsches
Ben Wagner added 1 comment![]( "Open in Gerrit")
Commit Message
Line 16, Patchset 1 (Latest):
added, fore example for the HEJI2Text.otf font, see bug.Ben Wagner . unresolved
for example
Related details
Attention is currently required from:
- Dominik Röttsches
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
Sep 5, 2025, 1:14:54 PM (2 days ago) Sep 5
to Ben Wagner, chromium...@chromium.org, ozone-...@chromium.org
Dominik Röttsches voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
Sep 5, 2025, 1:16:53 PM (2 days ago) Sep 5
to Chromium LUCI CQ, Ben Wagner, chromium...@chromium.org, ozone-...@chromium.org
Dominik Röttsches added 1 comment![]( "Open in Gerrit")
Commit Message
Line 16, Patchset 1:
added, fore example for the HEJI2Text.otf font, see bug.Ben Wagner . resolved
Dominik Röttschesfor example
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
Sep 5, 2025, 1:17:00 PM (2 days ago) Sep 5
to Chromium LUCI CQ, Ben Wagner, chromium...@chromium.org, ozone-...@chromium.org
Dominik Röttsches voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 5, 2025, 2:01:49 PM (2 days ago) Sep 5
to Dominik Röttsches, Ben Wagner, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Disable Fontations FontConfig indexing and disregard old caches
As a stop-gap solution, disable Fontations indexing in FontConfig, and
move back to using FreeType while we sort out why specific broken
fonts cause incorrect indexing.
Note: When reverting this, we need to make sure that if FontConfig cache
version has not been changed since this was broken, the code then also
needs to be able to handle cache entries that may have been incorrectly
added, for example for the HEJI2Text.otf font, see bug.
Bug: 442747781
Change-Id: Iff53de2d73131e6ddcf6256ae77baac0d4eb6ce0
Reviewed-by: Ben Wagner <bung...@google.com>
Commit-Queue: Dominik Röttsches <dr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511734}
Files:
- M third_party/fontconfig/include/fontconfig/fontconfig.h
- M third_party/test_fonts/fontconfig/BUILD.gn
- M third_party/test_fonts/fontconfig/generate_fontconfig_caches.cc
- M ui/gfx/linux/fontconfig_util.cc
Change size: XS
Delta: 4 files changed, 4 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ben Wagner
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages