Mitsuru Oshima (Gerrit)

unread,

Sep 4, 2025, 5:51:23 AM (4 days ago) Sep 4

to Shu Yang, Dana Fried, David Song, Pi-Hsun Shih, Lambros Lambrou, Rick Byers, Reilly Grant, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, Victor Tan, Zijie He, dullweb...@chromium.org, msrame...@chromium.org, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, anastas...@google.com, andrewxu+wat...@google.com, arc-review...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bici...@google.com, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-report...@google.com, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblack+watc...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wa...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jackshira+...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, longbowei+watc...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+...@google.com, milicau+watchlis...@google.com, multipaste-...@google.com, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, pushi+wa...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, toshikikikuch...@chromium.org, toshikikikuch...@chromium.org, toshikikikuchi+...@chromium.org, toshikikikuch...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Dana Fried, David Song, Lambros Lambrou, Pi-Hsun Shih, Reilly Grant, Rick Byers and Shu Yang

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Dana Fried
David Song
Lambros Lambrou
Pi-Hsun Shih
Reilly Grant
Rick Byers
Shu Yang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dana Fried (Gerrit)

unread,

Sep 4, 2025, 10:18:04 AM (4 days ago) Sep 4

to Mitsuru Oshima, Shu Yang, David Song, Pi-Hsun Shih, Lambros Lambrou, Rick Byers, Reilly Grant, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, Victor Tan, Zijie He, dullweb...@chromium.org, msrame...@chromium.org, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, anastas...@google.com, andrewxu+wat...@google.com, arc-review...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bici...@google.com, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-report...@google.com, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblack+watc...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wa...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jackshira+...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, longbowei+watc...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+...@google.com, milicau+watchlis...@google.com, multipaste-...@google.com, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, pushi+wa...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, toshikikikuch...@chromium.org, toshikikikuch...@chromium.org, toshikikikuchi+...@chromium.org, toshikikikuch...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from David Song, Lambros Lambrou, Mitsuru Oshima, Pi-Hsun Shih, Reilly Grant, Rick Byers and Shu Yang

Dana Fried voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

David Song
Lambros Lambrou
Mitsuru Oshima

Pi-Hsun Shih
Reilly Grant
Rick Byers
Shu Yang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

satisfied_requirement

unsatisfied_requirement

open

diffy

Rick Byers (Gerrit)

unread,

Sep 4, 2025, 11:52:47 AM (4 days ago) Sep 4

to Mitsuru Oshima, David Song, Shu Yang, Reilly Grant, Lambros Lambrou, Pi-Hsun Shih, Dana Fried, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, Victor Tan, Zijie He, dullweb...@chromium.org, msrame...@chromium.org, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, anastas...@google.com, andrewxu+wat...@google.com, arc-review...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bici...@google.com, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-report...@google.com, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblack+watc...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wa...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jackshira+...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, longbowei+watc...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+...@google.com, milicau+watchlis...@google.com, multipaste-...@google.com, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, pushi+wa...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, toshikikikuch...@chromium.org, toshikikikuch...@chromium.org, toshikikikuchi+...@chromium.org, toshikikikuch...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from David Song, Lambros Lambrou, Mitsuru Oshima, Pi-Hsun Shih, Reilly Grant and Shu Yang

Rick Byers voted and added 1 comment

Votes added by Rick Byers

Code-Review	+1
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Rick Byers . resolved

All changes outside ui/display (in which you are an OWNER) are mechanical. So LGTM and OO+1, no need to get review from a diversity of OWNERS for this.

Open in Gerrit

Related details

Attention is currently required from:

David Song
Lambros Lambrou
Mitsuru Oshima
Pi-Hsun Shih
Reilly Grant

Shu Yang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Shu Yang (Gerrit)

unread,

Sep 4, 2025, 1:25:35 PM (4 days ago) Sep 4

to Mitsuru Oshima, Rick Byers, David Song, Reilly Grant, Lambros Lambrou, Pi-Hsun Shih, Dana Fried, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, Victor Tan, Zijie He, dullweb...@chromium.org, msrame...@chromium.org, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, anastas...@google.com, andrewxu+wat...@google.com, arc-review...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bici...@google.com, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-report...@google.com, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblack+watc...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wa...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jackshira+...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, longbowei+watc...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+...@google.com, milicau+watchlis...@google.com, multipaste-...@google.com, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, pushi+wa...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, toshikikikuch...@chromium.org, toshikikikuch...@chromium.org, toshikikikuchi+...@chromium.org, toshikikikuch...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from David Song, Lambros Lambrou, Mitsuru Oshima, Pi-Hsun Shih and Reilly Grant

Shu Yang voted and added 1 comment

Votes added by Shu Yang

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Shu Yang . resolved

chrome/browser/content_settings/request_desktop_site_web_contents_observer_android.cc lgtm

Open in Gerrit

Related details

Attention is currently required from:

David Song
Lambros Lambrou
Mitsuru Oshima
Pi-Hsun Shih
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lambros Lambrou (Gerrit)

unread,

Sep 4, 2025, 1:38:59 PM (4 days ago) Sep 4

to Mitsuru Oshima, Shu Yang, Rick Byers, David Song, Reilly Grant, Pi-Hsun Shih, Dana Fried, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, Victor Tan, Zijie He, dullweb...@chromium.org, msrame...@chromium.org, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, anastas...@google.com, andrewxu+wat...@google.com, arc-review...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bici...@google.com, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-report...@google.com, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblack+watc...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wa...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jackshira+...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, longbowei+watc...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+...@google.com, milicau+watchlis...@google.com, multipaste-...@google.com, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, pushi+wa...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, toshikikikuch...@chromium.org, toshikikikuch...@chromium.org, toshikikikuchi+...@chromium.org, toshikikikuch...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from David Song, Mitsuru Oshima, Pi-Hsun Shih and Reilly Grant

Lambros Lambrou voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

David Song

Mitsuru Oshima
Pi-Hsun Shih
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

David Song (Gerrit)

unread,

Sep 4, 2025, 3:52:45 PM (4 days ago) Sep 4

to Mitsuru Oshima, Lambros Lambrou, Shu Yang, Rick Byers, Reilly Grant, Pi-Hsun Shih, Dana Fried, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, Victor Tan, Zijie He, dullweb...@chromium.org, msrame...@chromium.org, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, anastas...@google.com, andrewxu+wat...@google.com, arc-review...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bici...@google.com, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-report...@google.com, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblack+watc...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wa...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jackshira+...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, longbowei+watc...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+...@google.com, milicau+watchlis...@google.com, multipaste-...@google.com, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, pushi+wa...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, toshikikikuch...@chromium.org, toshikikikuch...@chromium.org, toshikikikuchi+...@chromium.org, toshikikikuch...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Mitsuru Oshima, Pi-Hsun Shih and Reilly Grant

David Song voted and added 1 comment

Votes added by David Song

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

David Song . resolved

lgtm fuchsia_web/webengine/browser/receiver_session_client.cc

Open in Gerrit

Related details

Attention is currently required from:

Mitsuru Oshima
Pi-Hsun Shih
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reilly Grant (Gerrit)

unread,

Sep 4, 2025, 3:57:11 PM (4 days ago) Sep 4

to Mitsuru Oshima, Reilly Grant, David Song, Lambros Lambrou, Shu Yang, Rick Byers, Pi-Hsun Shih, Dana Fried, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, Victor Tan, Zijie He, dullweb...@chromium.org, msrame...@chromium.org, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, anastas...@google.com, andrewxu+wat...@google.com, arc-review...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bici...@google.com, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-report...@google.com, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblack+watc...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wa...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jackshira+...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, longbowei+watc...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+...@google.com, milicau+watchlis...@google.com, multipaste-...@google.com, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, pushi+wa...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, toshikikikuch...@chromium.org, toshikikikuch...@chromium.org, toshikikikuchi+...@chromium.org, toshikikikuch...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Mitsuru Oshima and Pi-Hsun Shih

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Mitsuru Oshima
Pi-Hsun Shih

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

Sep 4, 2025, 6:56:44 PM (3 days ago) Sep 4

to Reilly Grant, David Song, Lambros Lambrou, Shu Yang, Rick Byers, Pi-Hsun Shih, Dana Fried, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, Victor Tan, Zijie He, dullweb...@chromium.org, msrame...@chromium.org, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, anastas...@google.com, andrewxu+wat...@google.com, arc-review...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bici...@google.com, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-report...@google.com, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblack+watc...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wa...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jackshira+...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, longbowei+watc...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+...@google.com, milicau+watchlis...@google.com, multipaste-...@google.com, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, pushi+wa...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, toshikikikuch...@chromium.org, toshikikikuch...@chromium.org, toshikikikuchi+...@chromium.org, toshikikikuch...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Pi-Hsun Shih

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Mitsuru Oshima . resolved

thank you!

Open in Gerrit

Related details

Attention is currently required from:

Pi-Hsun Shih

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Sep 4, 2025, 6:59:55 PM (3 days ago) Sep 4

to Mitsuru Oshima, Reilly Grant, David Song, Lambros Lambrou, Shu Yang, Rick Byers, Pi-Hsun Shih, Dana Fried, AyeAye, Akihiro Ota, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, Victor Tan, Zijie He, dullweb...@chromium.org, msrame...@chromium.org, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, anastas...@google.com, andrewxu+wat...@google.com, arc-review...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bici...@google.com, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-report...@google.com, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblack+watc...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wa...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jackshira+...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, longbowei+watc...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+...@google.com, milicau+watchlis...@google.com, multipaste-...@google.com, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, pushi+wa...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, toshikikikuch...@chromium.org, toshikikikuch...@chromium.org, toshikikikuchi+...@chromium.org, toshikikikuch...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

13 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Rename display::Screen::GetScreen() to display::Screen::Get()

This is the last change and removes GetScreen() as well.

Fixed: 439672783

Change-Id: Ie747ec3a3f5eeb63192d9e27550da86045409abd

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6860363

Reviewed-by: Dana Fried <dfr...@chromium.org>

Reviewed-by: Lambros Lambrou <lambros...@chromium.org>

Commit-Queue: Mitsuru Oshima <osh...@chromium.org>

Reviewed-by: Reilly Grant <rei...@chromium.org>

Reviewed-by: Rick Byers <rby...@chromium.org>

Reviewed-by: David Song <winter...@google.com>

Owners-Override: Rick Byers <rby...@chromium.org>

Reviewed-by: Shu Yang <shu...@google.com>

Cr-Commit-Position: refs/heads/main@{#1511205}

Files:

M chrome/browser/content_settings/request_desktop_site_web_contents_observer_android.cc
M chrome/test/interaction/interactive_browser_test_interactive_uitest.cc
M device/vr/orientation/orientation_device.cc
M fuchsia_web/webengine/browser/receiver_session_client.cc
M media/capture/video/chromeos/system_event_monitor_impl.cc
M remoting/host/chromeos/ash_proxy.cc
M services/device/wake_lock/power_save_blocker/power_save_blocker_linux.cc
M third_party/blink/common/page_state/page_state_serialization.cc
M ui/display/screen.cc
M ui/display/screen.h

Change size: S

Delta: 10 files changed, 12 insertions(+), 22 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by David Song, +1 by Lambros Lambrou, +1 by Rick Byers, +1 by Dana Fried, +1 by Shu Yang, +1 by Reilly Grant

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Andrey Kosyakov (Gerrit)

unread,

Sep 4, 2025, 7:48:11 PM (3 days ago) Sep 4

to Mitsuru Oshima, Chromium LUCI CQ, Reilly Grant, David Song, Lambros Lambrou, Shu Yang, Rick Byers, Pi-Hsun Shih, Dana Fried, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Henrique Ferreiro, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Simon Hangl, James Su, Victor Tan, Zijie He, dullweb...@chromium.org, msrame...@chromium.org, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, anastas...@google.com, andrewxu+wat...@google.com, arc-review...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bici...@google.com, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, chadduffin+w...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromeos-ca...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-ed...@google.com, cros-report...@google.com, cros-setti...@google.com, cros-system-ui-prod...@google.com, crostin...@chromium.org, crost...@chromium.org, dennyh...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmblack+watc...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, gcasto+w...@chromium.org, gogerald+pa...@chromium.org, halliwe...@chromium.org, hansberry+wa...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jackshira+...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrobe...@google.com, jbauma...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, keithle...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, longbowei+watc...@google.com, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+...@google.com, milicau+watchlis...@google.com, multipaste-...@google.com, navigation...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, nona+...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, pushi+wa...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, sloboda...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, toshikikikuch...@chromium.org, toshikikikuch...@chromium.org, toshikikikuchi+...@chromium.org, toshikikikuch...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, weiluanw...@google.com, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Andrey Kosyakov has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Rename display::Screen::GetScreen() to display::Screen::Get() [chromium/src : main]

Mitsuru Oshima (Gerrit)

New activity on the change

Related details

Dana Fried (Gerrit)

Dana Fried voted Code-Review+1

Related details

Rick Byers (Gerrit)

Rick Byers voted and added 1 comment

Votes added by Rick Byers

1 comment

Related details

Shu Yang (Gerrit)

Shu Yang voted and added 1 comment

Votes added by Shu Yang

1 comment

Related details

Lambros Lambrou (Gerrit)

Lambros Lambrou voted Code-Review+1

Related details

David Song (Gerrit)

David Song voted and added 1 comment

Votes added by David Song

1 comment

Related details

Reilly Grant (Gerrit)

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

1 comment

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Unreviewed changes

Change information

Andrey Kosyakov (Gerrit)

Andrey Kosyakov has created a revert of this change

Related details