Remove unsafe buffer pragma from GL bindings autogen [chromium/src : main]
0 views
Skip to first unread message
Arthur Sonzogni (Gerrit)
Apr 30, 2026, 8:02:08 AMApr 30
to Geoff Lang, Stephen Nusko, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Geoff Lang
Arthur Sonzogni voted and added 2 comments![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Arthur Sonzogni . resolved
Hi Geoff,
Could you please take a look?
File ui/gl/gl_enums_implementation_autogen.h
Line 7173, Patchset 2 (Latest):
{
0x9770,
"GL_SHADER_BINARY_HUAWEI",
},
{
0x9771,
"GL_PROGRAM_BINARY_HUAWEI",
},
{Arthur Sonzogni . resolved
Note: This is unrelated to my change. I guess something was updated without running the autogen scripts. This is (enum => string) debugging stuff, so this probably don't matter much.
Related details
Attention is currently required from:
- Geoff Lang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Geoff Lang (Gerrit)
May 4, 2026, 11:00:11 AMMay 4
to Arthur Sonzogni, Stephen Nusko, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Attention needed from Arthur Sonzogni
Geoff Lang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Arthur Sonzogni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
May 7, 2026, 11:28:57 AMMay 7
to Geoff Lang, Stephen Nusko, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Arthur Sonzogni voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 7, 2026, 1:50:13 PMMay 7
to Arthur Sonzogni, Geoff Lang, Stephen Nusko, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove unsafe buffer pragma from GL bindings autogen
This CL modifies ui/gl/generate_bindings.py to stop emitting the
`#pragma allow_unsafe_buffers` directive in the generated GL and EGL
binding files.
To avoid unsafe buffer usage warnings in the generated mock files that
previously relied on `strcmp`, the generator has been updated to emit
comparisons using `std::string_view` instantiated once outside the loop.
Bug: 508160130
Change-Id: I959b1b481d1ca576091ad0f05e86925029bb7020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7805767
Reviewed-by: Geoff Lang <geof...@chromium.org>
Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1627062}
Files:
- M ui/gl/egl_bindings_autogen_mock.cc
- M ui/gl/egl_bindings_autogen_mock.h
- M ui/gl/generate_bindings.py
- M ui/gl/gl_bindings_api_autogen_egl.h
- M ui/gl/gl_bindings_api_autogen_gl.h
- M ui/gl/gl_bindings_autogen_egl.cc
- M ui/gl/gl_bindings_autogen_egl.h
- M ui/gl/gl_bindings_autogen_gl.cc
- M ui/gl/gl_bindings_autogen_gl.h
- M ui/gl/gl_bindings_autogen_mock.cc
- M ui/gl/gl_bindings_autogen_mock.h
- M ui/gl/gl_enums_implementation_autogen.h
- M ui/gl/gl_mock_autogen_egl.h
- M ui/gl/gl_mock_autogen_gl.h
- M ui/gl/gl_stub_autogen_gl.cc
- M ui/gl/gl_stub_autogen_gl.h
Change size: XL
Delta: 16 files changed, 1081 insertions(+), 627 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Geoff Lang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages